[libvirt] [PATCH] daemon: Enhance documentation for changinging NOFILE limit

Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- daemon/libvirtd.sysconf | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/daemon/libvirtd.sysconf b/daemon/libvirtd.sysconf index 3af1f03..06f6a2c 100644 --- a/daemon/libvirtd.sysconf +++ b/daemon/libvirtd.sysconf @@ -20,5 +20,7 @@ # #SDL_AUDIODRIVER=pulse -# Override the maximum number of opened files +# Override the maximum number of opened files. +# This only works with traditional init scripts. In systemd world, limits +# can only be changed by setting LimitNOFILE in libvirtd.service unit file. #LIBVIRTD_NOFILES_LIMIT=2048 -- 1.8.5.4

On 02/10/2014 07:26 AM, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- daemon/libvirtd.sysconf | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/daemon/libvirtd.sysconf b/daemon/libvirtd.sysconf index 3af1f03..06f6a2c 100644 --- a/daemon/libvirtd.sysconf +++ b/daemon/libvirtd.sysconf @@ -20,5 +20,7 @@ # #SDL_AUDIODRIVER=pulse
-# Override the maximum number of opened files +# Override the maximum number of opened files. +# This only works with traditional init scripts. In systemd world, limits
s/In/In the/
+# can only be changed by setting LimitNOFILE in libvirtd.service unit file. #LIBVIRTD_NOFILES_LIMIT=2048
Doesn't systemd provide a way to provide tuning to a service unit file by modifying /usr/lib/systemd/system/* while still inheriting defaults from the installed /etc/systemd/system/*? That is, should our comment be a hint to the user to modify the files under their direct control instead of telling them to modify the files installed by rpm? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

BTW, I filed a similar bug 1059518 for LXC guide. -- Regards, Alex ----- Original Message ----- From: "Eric Blake" <eblake@redhat.com> To: libvir-list@redhat.com Sent: Tuesday, February 11, 2014 12:51:23 AM Subject: Re: [libvirt] [PATCH] daemon: Enhance documentation for changinging NOFILE limit On 02/10/2014 07:26 AM, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- daemon/libvirtd.sysconf | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/daemon/libvirtd.sysconf b/daemon/libvirtd.sysconf index 3af1f03..06f6a2c 100644 --- a/daemon/libvirtd.sysconf +++ b/daemon/libvirtd.sysconf @@ -20,5 +20,7 @@ # #SDL_AUDIODRIVER=pulse
-# Override the maximum number of opened files +# Override the maximum number of opened files. +# This only works with traditional init scripts. In systemd world, limits
s/In/In the/
+# can only be changed by setting LimitNOFILE in libvirtd.service unit file. #LIBVIRTD_NOFILES_LIMIT=2048
Doesn't systemd provide a way to provide tuning to a service unit file by modifying /usr/lib/systemd/system/* while still inheriting defaults from the installed /etc/systemd/system/*? That is, should our comment be a hint to the user to modify the files under their direct control instead of telling them to modify the files installed by rpm? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (3)
-
Alex Jia
-
Eric Blake
-
Jiri Denemark