Commit id '7bf3198df' neglected to initialize deflate leading to a possibility if model allocation/checks fail, then the VIR_FREE(deflate) would be erroneous. Noted by Jan Tomko. Signed-off-by: John Ferlan <jferlan@redhat.com> --- I would have pushed as trivial, but it still wasn't 100% clear that this was the only 'issue' Jan was concerned about... src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1e78da1..a9706b0 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11354,7 +11354,7 @@ virDomainMemballoonDefParseXML(xmlNodePtr node, unsigned int flags) { char *model; - char *deflate; + char *deflate = NULL; virDomainMemballoonDefPtr def; xmlNodePtr save = ctxt->node; unsigned int period = 0; -- 2.5.0