[libvirt] Entering freeze for libvirt-1.3.0

As planned I have tagged RC1 in git and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ there is significant changes in this release so people are really encouraged to give it a good try. I will try to push rc2 possibly in the week-end and shooting for a release on Tuesday next week i.e. Dec 8th, thanks for testing it ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

Hi, On Wed, Dec 02, 2015 at 11:55:21PM +0800, Daniel Veillard wrote:
As planned I have tagged RC1 in git and pushed signed tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
there is significant changes in this release so people are really encouraged to give it a good try.
RC1 looks good on Debian's autobuilders: https://buildd.debian.org/status/package.php?p=libvirt&suite=experimental Cheers, -- Guido

So as planned I tagged rc2 in git and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ but in my testing I'm hitting a serious issue. After upgrading to the new set of rpms and restarting the service and virt-manager, while virt-manager can connect and list the guests it fails to start a guest with the following error message: Error starting domain: Failed to connect socket to '/var/run/libvirt/virtlogd-sock': No such file or directory That to me is a release blocker we need to have that in place upgrade working, we can't just pull the socket even if we may have another better mechanism. So unless there is a good reason for this due to my setup and not the update I would delay 1.3.0 and put an rc3 instead on Wednesday. So please give it some testing, and let's try to solve this (though I'm travelling until tomorrow and won't be able to look at this seriously until tomorrow). thanks ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

On Mon, Dec 07, 2015 at 11:06:52AM +0800, Daniel Veillard wrote:
So as planned I tagged rc2 in git and pushed signed tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
but in my testing I'm hitting a serious issue. After upgrading to the new set of rpms and restarting the service and virt-manager, while virt-manager can connect and list the guests it fails to start a guest with the following error message:
Error starting domain: Failed to connect socket to '/var/run/libvirt/virtlogd-sock': No such file or directory
That to me is a release blocker we need to have that in place upgrade working, we can't just pull the socket even if we may have another better mechanism. So unless there is a good reason for this due to my setup and not the update I would delay 1.3.0 and put an rc3 instead on Wednesday.
Are you suggesting we keep the default of stdio_handler = "file" or enable virtlogd service when installing and libvirtd is enabled? It took me a while to deal with this and it'd be a shame if everyone who will update to 1.3.0 would have to go through that "why do I need some new socket" phase. Even worse if they are not following up on the development and starting machines will just stop working. So I agree, but I don't have a proper solution, I guess.
So please give it some testing, and let's try to solve this (though I'm travelling until tomorrow and won't be able to look at this seriously until tomorrow).
thanks !
Daniel
-- Daniel Veillard | Open Source and Standards, Red Hat veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

On Mon, Dec 07, 2015 at 11:06:52AM +0800, Daniel Veillard wrote:
So as planned I tagged rc2 in git and pushed signed tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
but in my testing I'm hitting a serious issue. After upgrading to the new set of rpms and restarting the service and virt-manager, while virt-manager can connect and list the guests it fails to start a guest with the following error message:
Error starting domain: Failed to connect socket to '/var/run/libvirt/virtlogd-sock': No such file or directory
That to me is a release blocker we need to have that in place upgrade working, we can't just pull the socket even if we may have another better mechanism. So unless there is a good reason for this due to my setup and not the update I would delay 1.3.0 and put an rc3 instead on Wednesday.
We register virtlogd with systemd for socket activation so that it should automatically start when first needed. Obviously non-systemd distros lack this, but that's like with obsolete init systems, and I think its fine for people to start it manually. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

On Mon, Dec 07, 2015 at 09:35:42AM +0000, Daniel P. Berrange wrote:
On Mon, Dec 07, 2015 at 11:06:52AM +0800, Daniel Veillard wrote:
So as planned I tagged rc2 in git and pushed signed tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
but in my testing I'm hitting a serious issue. After upgrading to the new set of rpms and restarting the service and virt-manager, while virt-manager can connect and list the guests it fails to start a guest with the following error message:
Error starting domain: Failed to connect socket to '/var/run/libvirt/virtlogd-sock': No such file or directory
That to me is a release blocker we need to have that in place upgrade working, we can't just pull the socket even if we may have another better mechanism. So unless there is a good reason for this due to my setup and not the update I would delay 1.3.0 and put an rc3 instead on Wednesday.
We register virtlogd with systemd for socket activation so that it should automatically start when first needed.
So it seems we merely get it enabled, but not started, unless you reboot. So we'll need to add some more logic to %post to ensure it is started if libvirtd is seen as running already Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

On Mon, Dec 07, 2015 at 10:27:15AM +0000, Daniel P. Berrange wrote:
On Mon, Dec 07, 2015 at 09:35:42AM +0000, Daniel P. Berrange wrote:
On Mon, Dec 07, 2015 at 11:06:52AM +0800, Daniel Veillard wrote:
So as planned I tagged rc2 in git and pushed signed tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
but in my testing I'm hitting a serious issue. After upgrading to the new set of rpms and restarting the service and virt-manager, while virt-manager can connect and list the guests it fails to start a guest with the following error message:
Error starting domain: Failed to connect socket to '/var/run/libvirt/virtlogd-sock': No such file or directory
That to me is a release blocker we need to have that in place upgrade working, we can't just pull the socket even if we may have another better mechanism. So unless there is a good reason for this due to my setup and not the update I would delay 1.3.0 and put an rc3 instead on Wednesday.
We register virtlogd with systemd for socket activation so that it should automatically start when first needed.
So it seems we merely get it enabled, but not started, unless you reboot. So we'll need to add some more logic to %post to ensure it is started if libvirtd is seen as running already
Right, I didn't rebooted, merely upgraded the rpms from rc2 and restarted the libvirtd service, i.e. my usual testing routine thanks, Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

On Mon, Dec 07, 2015 at 11:51:01PM +0800, Daniel Veillard wrote:
On Mon, Dec 07, 2015 at 10:27:15AM +0000, Daniel P. Berrange wrote:
On Mon, Dec 07, 2015 at 09:35:42AM +0000, Daniel P. Berrange wrote:
On Mon, Dec 07, 2015 at 11:06:52AM +0800, Daniel Veillard wrote:
So as planned I tagged rc2 in git and pushed signed tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
but in my testing I'm hitting a serious issue. After upgrading to the new set of rpms and restarting the service and virt-manager, while virt-manager can connect and list the guests it fails to start a guest with the following error message:
Error starting domain: Failed to connect socket to '/var/run/libvirt/virtlogd-sock': No such file or directory
That to me is a release blocker we need to have that in place upgrade working, we can't just pull the socket even if we may have another better mechanism. So unless there is a good reason for this due to my setup and not the update I would delay 1.3.0 and put an rc3 instead on Wednesday.
We register virtlogd with systemd for socket activation so that it should automatically start when first needed.
So it seems we merely get it enabled, but not started, unless you reboot. So we'll need to add some more logic to %post to ensure it is started if libvirtd is seen as running already
Right, I didn't rebooted, merely upgraded the rpms from rc2 and restarted the libvirtd service, i.e. my usual testing routine
NB, there hasn't been any need to restart the libvirtd service manually for a very long time now. The %post script always restarts it. Here is a patch that should fix virtlogd so that it is started upon upgrades from libvirt < 1.3.0: https://www.redhat.com/archives/libvir-list/2015-December/msg00252.html To test you'll obviously need to downgrade to some 1.2.x before then installing the new 1.3.0 build Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

On Mon, Dec 07, 2015 at 09:35:42AM +0000, Daniel P. Berrange wrote:
On Mon, Dec 07, 2015 at 11:06:52AM +0800, Daniel Veillard wrote:
So as planned I tagged rc2 in git and pushed signed tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
but in my testing I'm hitting a serious issue. After upgrading to the new set of rpms and restarting the service and virt-manager, while virt-manager can connect and list the guests it fails to start a guest with the following error message:
Error starting domain: Failed to connect socket to '/var/run/libvirt/virtlogd-sock': No such file or directory
That to me is a release blocker we need to have that in place upgrade working, we can't just pull the socket even if we may have another better mechanism. So unless there is a good reason for this due to my setup and not the update I would delay 1.3.0 and put an rc3 instead on Wednesday.
We register virtlogd with systemd for socket activation so that it should automatically start when first needed.
Obviously non-systemd distros lack this, but that's like with obsolete init systems, and I think its fine for people to start it manually.
Was an update on Fedora 23 with the rc2 rpms, Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (4)
-
Daniel P. Berrange
-
Daniel Veillard
-
Guido Günther
-
Martin Kletzander