[libvirt] [PATCH 0/4] Remove VIR_ERR_DEPRECATED & associated pieces
A deprecation is inherantly a warning, not an error, so adding an error with this name makes no conceptual sense. Features in drivers may come & go at any time and we've always use the VIR_ERR_NO_SUPPORT to indicate when a hypervisor driver does not support a particular API. Daniel P. Berrangé (4): qemu: delete methods which are no longer supported Revert "error: Add VIR_ERR_DEPRECATED error code" Revert "docs: css: Add style for <span class='deprecated'> ..." Revert "docs: hvsupport: Add support for deprecating hypervisor implementations" docs/hvsupport.pl | 44 ++++++++++++------------------------- docs/libvirt.css | 10 --------- include/libvirt/virterror.h | 1 - src/qemu/qemu_driver.c | 31 -------------------------- src/util/virerror.c | 4 ---- 5 files changed, 14 insertions(+), 76 deletions(-) -- 2.21.0
The public API entry points will report VIR_ERR_NO_SUPPORT to the caller when a driver does not provide an implementation of a particular method. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- src/qemu/qemu_driver.c | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d6ab134196..595a381734 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7316,22 +7316,6 @@ static char } -static char * -qemuConnectDomainXMLFromNative(virConnectPtr conn, - const char *format ATTRIBUTE_UNUSED, - const char *config ATTRIBUTE_UNUSED, - unsigned int flags) -{ - virCheckFlags(0, NULL); - - if (virConnectDomainXMLFromNativeEnsureACL(conn) < 0) - return NULL; - - virReportError(VIR_ERR_DEPRECATED, "%s", - _("converting arbitrary QEMU command lines to libvirt domain XML is no longer supported")); - return NULL; -} - static char *qemuConnectDomainXMLToNative(virConnectPtr conn, const char *format, const char *xmlData, @@ -16772,19 +16756,6 @@ static int qemuDomainQemuMonitorCommand(virDomainPtr domain, const char *cmd, } -static virDomainPtr -qemuDomainQemuAttach(virConnectPtr conn ATTRIBUTE_UNUSED, - unsigned int pid_value ATTRIBUTE_UNUSED, - unsigned int flags) -{ - virCheckFlags(0, NULL); - - virReportError(VIR_ERR_DEPRECATED, "%s", - _("attaching to a QEMU process started outside of libvirt is no longer supported")); - return NULL; -} - - static int qemuDomainOpenConsole(virDomainPtr dom, const char *dev_name, @@ -22271,7 +22242,6 @@ static virHypervisorDriver qemuHypervisorDriver = { .domainGetSecurityLabelList = qemuDomainGetSecurityLabelList, /* 0.10.0 */ .nodeGetSecurityModel = qemuNodeGetSecurityModel, /* 0.6.1 */ .domainGetXMLDesc = qemuDomainGetXMLDesc, /* 0.2.0 */ - .connectDomainXMLFromNative = qemuConnectDomainXMLFromNative, /* 0.6.4 (deprecated: 5.5.0) */ .connectDomainXMLToNative = qemuConnectDomainXMLToNative, /* 0.6.4 */ .connectListDefinedDomains = qemuConnectListDefinedDomains, /* 0.2.0 */ .connectNumOfDefinedDomains = qemuConnectNumOfDefinedDomains, /* 0.2.0 */ @@ -22356,7 +22326,6 @@ static virHypervisorDriver qemuHypervisorDriver = { .domainRevertToSnapshot = qemuDomainRevertToSnapshot, /* 0.8.0 */ .domainSnapshotDelete = qemuDomainSnapshotDelete, /* 0.8.0 */ .domainQemuMonitorCommand = qemuDomainQemuMonitorCommand, /* 0.8.3 */ - .domainQemuAttach = qemuDomainQemuAttach, /* 0.9.4 (deprecated: 5.5.0) */ .domainQemuAgentCommand = qemuDomainQemuAgentCommand, /* 0.10.0 */ .connectDomainQemuMonitorEventRegister = qemuConnectDomainQemuMonitorEventRegister, /* 1.2.3 */ .connectDomainQemuMonitorEventDeregister = qemuConnectDomainQemuMonitorEventDeregister, /* 1.2.3 */ -- 2.21.0
On Wed, Jun 26, 2019 at 04:54:40PM +0100, Daniel P. Berrangé wrote:
The public API entry points will report VIR_ERR_NO_SUPPORT to the caller when a driver does not provide an implementation of a particular method.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- src/qemu/qemu_driver.c | 31 ------------------------------- 1 file changed, 31 deletions(-)
This is a followup to commit 215d9393bb60615f957f456fec646cf187fec26e qemu: driver: Drop support for qemu-attach which also introduced an exception for domainQemuAttach in src/check-aclrules.pl: diff --git a/src/check-aclrules.pl b/src/check-aclrules.pl index be618f6c9f..23872cda98 100755 --- a/src/check-aclrules.pl +++ b/src/check-aclrules.pl @@ -61,7 +61,6 @@ my %whitelist = ( "interfaceClose" => 1, "connectURIProbe" => 1, "localOnly" => 1, - "domainQemuAttach" => 1, ); # XXX this vzDomainMigrateConfirm3Params looks Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
On Wed, Jun 26, 2019 at 16:54:40 +0100, Daniel Berrange wrote:
The public API entry points will report VIR_ERR_NO_SUPPORT to the caller when a driver does not provide an implementation of a particular method.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- src/qemu/qemu_driver.c | 31 ------------------------------- 1 file changed, 31 deletions(-)
[...]
@@ -22271,7 +22242,6 @@ static virHypervisorDriver qemuHypervisorDriver = { .domainGetSecurityLabelList = qemuDomainGetSecurityLabelList, /* 0.10.0 */ .nodeGetSecurityModel = qemuNodeGetSecurityModel, /* 0.6.1 */ .domainGetXMLDesc = qemuDomainGetXMLDesc, /* 0.2.0 */ - .connectDomainXMLFromNative = qemuConnectDomainXMLFromNative, /* 0.6.4 (deprecated: 5.5.0) */
This makes documentation strictly worse, where users may be lead into thinking that this never existed. I don't think we should just delete it without acknowledging we've deleted it.
On Thu, 2019-06-27 at 08:02 +0200, Peter Krempa wrote:
On Wed, Jun 26, 2019 at 16:54:40 +0100, Daniel Berrange wrote:
@@ -22271,7 +22242,6 @@ static virHypervisorDriver qemuHypervisorDriver = { .domainGetSecurityLabelList = qemuDomainGetSecurityLabelList, /* 0.10.0 */ .nodeGetSecurityModel = qemuNodeGetSecurityModel, /* 0.6.1 */ .domainGetXMLDesc = qemuDomainGetXMLDesc, /* 0.2.0 */ - .connectDomainXMLFromNative = qemuConnectDomainXMLFromNative, /* 0.6.4 (deprecated: 5.5.0) */
This makes documentation strictly worse, where users may be lead into thinking that this never existed.
I don't think we should just delete it without acknowledging we've deleted it.
FWIW, I completely agree with Peter. -- Andrea Bolognani / Red Hat / Virtualization
On Thu, Jun 27, 2019 at 08:02:54AM +0200, Peter Krempa wrote:
On Wed, Jun 26, 2019 at 16:54:40 +0100, Daniel Berrange wrote:
The public API entry points will report VIR_ERR_NO_SUPPORT to the caller when a driver does not provide an implementation of a particular method.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- src/qemu/qemu_driver.c | 31 ------------------------------- 1 file changed, 31 deletions(-)
[...]
@@ -22271,7 +22242,6 @@ static virHypervisorDriver qemuHypervisorDriver = { .domainGetSecurityLabelList = qemuDomainGetSecurityLabelList, /* 0.10.0 */ .nodeGetSecurityModel = qemuNodeGetSecurityModel, /* 0.6.1 */ .domainGetXMLDesc = qemuDomainGetXMLDesc, /* 0.2.0 */ - .connectDomainXMLFromNative = qemuConnectDomainXMLFromNative, /* 0.6.4 (deprecated: 5.5.0) */
This makes documentation strictly worse, where users may be lead into thinking that this never existed.
I don't think we should just delete it without acknowledging we've deleted it.
A documentation problem we can address pretty easily while keeping these code semantics. eg .connectDomainXMLFromNative = NULL, /* 0.6.4 - 5.5.0 */ then just adapt your docs patch which read the deprecated comment to require the version range when it sees a NULL method impl. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
This reverts commit 226094fbc483128c8888f4171c353aed738b8346. A deprecation is a warning to something that use of a feature is being discouraged. By definition it is not an error condition to continue to use a deprecated feature. A VIR_ERR_DEPRECATED constant thus makes no conceptual sense. For features which are entirely absent we already document that the VIR_ERR_NO_SUPPORT code will be used. There is no need to distinguish between a feature which never existed and a feature which previously existed and was since removed. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- include/libvirt/virterror.h | 1 - src/util/virerror.c | 4 ---- 2 files changed, 5 deletions(-) diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h index 22bc3c2d27..102a2573bf 100644 --- a/include/libvirt/virterror.h +++ b/include/libvirt/virterror.h @@ -329,7 +329,6 @@ typedef enum { VIR_ERR_INVALID_NETWORK_PORT = 105, /* invalid network port object */ VIR_ERR_NETWORK_PORT_EXIST = 106, /* the network port already exist */ VIR_ERR_NO_NETWORK_PORT = 107, /* network port not found */ - VIR_ERR_DEPRECATED = 108, /* configuration or operation is no longer supported */ # ifdef VIR_ENUM_SENTINELS VIR_ERR_NUMBER_LAST diff --git a/src/util/virerror.c b/src/util/virerror.c index 26f14ddd29..dfba8c5712 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -1235,10 +1235,6 @@ const virErrorMsgTuple virErrorMsgStrings[VIR_ERR_NUMBER_LAST] = { [VIR_ERR_NO_NETWORK_PORT] = { N_("network port not found"), N_("network port not found: %s") }, - [VIR_ERR_DEPRECATED] = { - N_("operation or configuration no longer supported"), - "%s", - }, }; -- 2.21.0
On Wed, Jun 26, 2019 at 04:54:41PM +0100, Daniel P. Berrangé wrote:
This reverts commit 226094fbc483128c8888f4171c353aed738b8346.
A deprecation is a warning to something that use of a feature is being discouraged. By definition it is not an error condition to continue to use a deprecated feature.
Makes sense that from an app's PoV it's the same
A VIR_ERR_DEPRECATED constant thus makes no conceptual sense. For features which are entirely absent we already document that the VIR_ERR_NO_SUPPORT code will be used. There is no need to distinguish between a feature which never existed and a feature which previously existed and was since removed.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- include/libvirt/virterror.h | 1 - src/util/virerror.c | 4 ---- 2 files changed, 5 deletions(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
This reverts commit 71626402f481ed47ff67dafa8521b01a42625707. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- docs/libvirt.css | 6 ------ 1 file changed, 6 deletions(-) diff --git a/docs/libvirt.css b/docs/libvirt.css index 6639b1df64..54d015db98 100644 --- a/docs/libvirt.css +++ b/docs/libvirt.css @@ -274,12 +274,6 @@ span.since { font-weight: bold; } -span.deprecated { - color: darkred; - font-style: italic; - font-weight: bold; -} - img.diagram { background: rgb(230,230,230); border: 2px dotted rgb(178,178,178); -- 2.21.0
On Wed, Jun 26, 2019 at 04:54:42PM +0100, Daniel P. Berrangé wrote:
This reverts commit 71626402f481ed47ff67dafa8521b01a42625707.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- docs/libvirt.css | 6 ------ 1 file changed, 6 deletions(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
On Wed, Jun 26, 2019 at 04:54:42PM +0100, Daniel P. Berrangé wrote:
This reverts commit 71626402f481ed47ff67dafa8521b01a42625707.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- docs/libvirt.css | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/docs/libvirt.css b/docs/libvirt.css index 6639b1df64..54d015db98 100644 --- a/docs/libvirt.css +++ b/docs/libvirt.css @@ -274,12 +274,6 @@ span.since { font-weight: bold; }
-span.deprecated { - color: darkred; - font-style: italic; - font-weight: bold; -} - img.diagram { background: rgb(230,230,230); border: 2px dotted rgb(178,178,178);
Also, this is used by docs/drvqemu.html.in, since: commit d127bc3ce6eaf4b48dd09305368ac6a727d5aecf docs: drvqemu: Add note about deprecation of domxml-from-native where we can either: a) drop the reference to the removed class b) drop the reference to the removed command b) somehow smells of rewriting history - it would be nice to keep the deprecation notice there at leastfor some time. OTOH, we have a lot of <span class="since"> elements with pre-historic libvirt versions I'm considering removing. Jano
On Wed, Jun 26, 2019 at 19:47:07 +0200, Ján Tomko wrote:
On Wed, Jun 26, 2019 at 04:54:42PM +0100, Daniel P. Berrangé wrote:
This reverts commit 71626402f481ed47ff67dafa8521b01a42625707.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- docs/libvirt.css | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/docs/libvirt.css b/docs/libvirt.css index 6639b1df64..54d015db98 100644 --- a/docs/libvirt.css +++ b/docs/libvirt.css @@ -274,12 +274,6 @@ span.since { font-weight: bold; }
-span.deprecated { - color: darkred; - font-style: italic; - font-weight: bold; -} - img.diagram { background: rgb(230,230,230); border: 2px dotted rgb(178,178,178);
Also, this is used by docs/drvqemu.html.in, since: commit d127bc3ce6eaf4b48dd09305368ac6a727d5aecf docs: drvqemu: Add note about deprecation of domxml-from-native
where we can either: a) drop the reference to the removed class b) drop the reference to the removed command
I don't think we should cover up that we deleted old functionality. I don't care that much about the error code being reverted, but I think covering up that we've deleted this is a wrong idea.
This reverts commit fd14dfec88957599ac5cffa28ddb7b513f404d9d. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- docs/hvsupport.pl | 44 ++++++++++++++------------------------------ docs/libvirt.css | 4 ---- 2 files changed, 14 insertions(+), 34 deletions(-) diff --git a/docs/hvsupport.pl b/docs/hvsupport.pl index 2ea245e83a..a2b980c502 100755 --- a/docs/hvsupport.pl +++ b/docs/hvsupport.pl @@ -234,11 +234,10 @@ foreach my $src (@srcs) { } } else { - if ($line =~ m!\s*\.(\w+)\s*=\s*(\w+)\s*,?\s*(?:/\*\s*(\d+\.\d+\.\d+)\s*(?:\(deprecated:\s*(\d+\.\d+\.\d+)\))?\s*\*/\s*)?$!) { + if ($line =~ m!\s*\.(\w+)\s*=\s*(\w+)\s*,?\s*(?:/\*\s*(\d+\.\d+\.\d+)\s*\*/\s*)?$!) { my $api = $1; my $meth = $2; my $vers = $3; - my $depre = $4; next if $api eq "no" || $api eq "name"; @@ -252,16 +251,12 @@ foreach my $src (@srcs) { die "Found unexpected method $api in $ingrp\n"; } - $groups{$ingrp}->{drivers}->{$impl}->{$api} = {}; - $groups{$ingrp}->{drivers}->{$impl}->{$api}->{vers} = $vers; - $groups{$ingrp}->{drivers}->{$impl}->{$api}->{depre} = $depre; + $groups{$ingrp}->{drivers}->{$impl}->{$api} = $vers; if ($api eq "domainMigratePrepare" || $api eq "domainMigratePrepare2" || $api eq "domainMigratePrepare3") { - if (!$groups{$ingrp}->{drivers}->{$impl}->{"domainMigrate"}) { - $groups{$ingrp}->{drivers}->{$impl}->{"domainMigrate"} = {}; - $groups{$ingrp}->{drivers}->{$impl}->{"domainMigrate"}->{vers} = $vers; - } + $groups{$ingrp}->{drivers}->{$impl}->{"domainMigrate"} = $vers + unless $groups{$ingrp}->{drivers}->{$impl}->{"domainMigrate"}; } } elsif ($line =~ /}/) { @@ -285,7 +280,7 @@ $groups{virHypervisorDriver}->{apis}->{"domainMigrate"} = "virDomainMigrate"; my $openAuthVers = (0 * 1000 * 1000) + (4 * 1000) + 0; foreach my $drv (keys %{$groups{"virHypervisorDriver"}->{drivers}}) { - my $openVersStr = $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpen"}->{vers}; + my $openVersStr = $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpen"}; my $openVers; if ($openVersStr =~ /(\d+)\.(\d+)\.(\d+)/) { $openVers = ($1 * 1000 * 1000) + ($2 * 1000) + $3; @@ -295,16 +290,14 @@ foreach my $drv (keys %{$groups{"virHypervisorDriver"}->{drivers}}) { $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpenReadOnly"} = $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpen"}; - $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpenAuth"} = {}; - # virConnectOpenAuth is always 0.4.0 if the driver existed # before this time, otherwise it matches the version of # the driver's virConnectOpen entry if ($openVersStr eq "Y" || $openVers >= $openAuthVers) { - $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpenAuth"}->{vers} = $openVersStr; + $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpenAuth"} = $openVersStr; } else { - $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpenAuth"}->{vers} = "0.4.0"; + $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpenAuth"} = "0.4.0"; } } @@ -316,23 +309,21 @@ $groups{virHypervisorDriver}->{apis}->{"domainCreateLinux"} = "virDomainCreateLi my $createAPIVers = (0 * 1000 * 1000) + (0 * 1000) + 3; foreach my $drv (keys %{$groups{"virHypervisorDriver"}->{drivers}}) { - my $createVersStr = $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"domainCreateXML"}->{vers}; + my $createVersStr = $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"domainCreateXML"}; next unless defined $createVersStr; my $createVers; if ($createVersStr =~ /(\d+)\.(\d+)\.(\d+)/) { $createVers = ($1 * 1000 * 1000) + ($2 * 1000) + $3; } - $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"domainCreateLinux"} = {}; - # virCreateLinux is always 0.0.3 if the driver existed # before this time, otherwise it matches the version of # the driver's virCreateXML entry if ($createVersStr eq "Y" || $createVers >= $createAPIVers) { - $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"domainCreateLinux"}->{vers} = $createVersStr; + $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"domainCreateLinux"} = $createVersStr; } else { - $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"domainCreateLinux"}->{vers} = "0.0.3"; + $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"domainCreateLinux"} = "0.0.3"; } } @@ -351,9 +342,7 @@ print <<EOF; <p> This page documents which <a href="html/">libvirt calls</a> work on which libvirt drivers / hypervisors, and which version the API appeared -in. If a hypervisor driver deprecated the API, the version when it -was removed is also mentioned (highlighted in -<span class="deprecatedhv">dark red</span>). +in. </p> EOF @@ -406,16 +395,11 @@ EOF EOF foreach my $drv (sort {$a cmp $b } keys %{$groups{$grp}->{drivers}}) { - print "<td>"; if (exists $groups{$grp}->{drivers}->{$drv}->{$field}) { - if ($groups{$grp}->{drivers}->{$drv}->{$field}->{vers}) { - print $groups{$grp}->{drivers}->{$drv}->{$field}->{vers}; - } - if ($groups{$grp}->{drivers}->{$drv}->{$field}->{depre}) { - print " - <span class=\"deprecatedhv\">", $groups{$grp}->{drivers}->{$drv}->{$field}->{depre}, "</span>"; - } + print "<td>", $groups{$grp}->{drivers}->{$drv}->{$field}, "</td>\n"; + } else { + print "<td></td>\n"; } - print "</td>\n"; } print <<EOF; diff --git a/docs/libvirt.css b/docs/libvirt.css index 54d015db98..3ae4ff7edc 100644 --- a/docs/libvirt.css +++ b/docs/libvirt.css @@ -582,10 +582,6 @@ td.enumvalue { display: inline; } -.deprecatedhv { - color: darkred; -} - ul.news-section-content { margin-top: 0.5em; } -- 2.21.0
On Wed, Jun 26, 2019 at 04:54:43PM +0100, Daniel P. Berrangé wrote:
This reverts commit fd14dfec88957599ac5cffa28ddb7b513f404d9d.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- docs/hvsupport.pl | 44 ++++++++++++++------------------------------ docs/libvirt.css | 4 ---- 2 files changed, 14 insertions(+), 34 deletions(-)
Nice diffstat ;) Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
On Wed, Jun 26, 2019 at 19:24:14 +0200, Ján Tomko wrote:
On Wed, Jun 26, 2019 at 04:54:43PM +0100, Daniel P. Berrangé wrote:
This reverts commit fd14dfec88957599ac5cffa28ddb7b513f404d9d.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- docs/hvsupport.pl | 44 ++++++++++++++------------------------------ docs/libvirt.css | 4 ---- 2 files changed, 14 insertions(+), 34 deletions(-)
Nice diffstat ;)
If we want to achieve a "Nice diffstat" we should rather remove the whole 'hvsupport' matrix. It's cumbersome, misplaced and hard to navigate. It'd be way better to include the information along with the API documentation so it does not need to be cross-checked across various documents.
On Wed, Jun 26, 2019 at 04:54:39PM +0100, Daniel P. Berrangé wrote:
A deprecation is inherantly a warning, not an error, so adding an error with this name makes no conceptual sense.
Features in drivers may come & go at any time and we've always use the VIR_ERR_NO_SUPPORT to indicate when a hypervisor driver does not support a particular API.
Daniel P. Berrangé (4): qemu: delete methods which are no longer supported Revert "error: Add VIR_ERR_DEPRECATED error code" Revert "docs: css: Add style for <span class='deprecated'> ..." Revert "docs: hvsupport: Add support for deprecating hypervisor implementations"
docs/hvsupport.pl | 44 ++++++++++++------------------------- docs/libvirt.css | 10 --------- include/libvirt/virterror.h | 1 - src/qemu/qemu_driver.c | 31 -------------------------- src/util/virerror.c | 4 ---- 5 files changed, 14 insertions(+), 76 deletions(-)
Missing a revert of: commit 3026f6d9d986ad63c4b4a1c57589e6d05b71bd70 news: Mention VIR_ERR_DEPRECATED in improvements I wish it would have been the first news revert in this release cycle. Jano
participants (4)
-
Andrea Bolognani -
Daniel P. Berrangé -
Ján Tomko -
Peter Krempa