[libvirt] [sandbox PATCH] maint: Drop autobuild.sh
The Test-AutoBuild project, that this script is supposed to be used with, hasn't seen any activity in ~7 years; these days, libvirt-sandbox CI builds are happening on the Jenkins-based CentOS CI environment under the libvirt umbrella[1], and in that context the script is not used at all. [1] https://ci.centos.org/view/libvirt/ Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- autobuild.sh | 71 ------------------------------------------------------------ 1 file changed, 71 deletions(-) delete mode 100755 autobuild.sh diff --git a/autobuild.sh b/autobuild.sh deleted file mode 100755 index c176fea..0000000 --- a/autobuild.sh +++ /dev/null @@ -1,71 +0,0 @@ -#!/bin/sh - -set -e -set -v - -# Make things clean. -test -n "$1" && RESULTS=$1 || RESULTS=results.log -: ${AUTOBUILD_INSTALL_ROOT=$HOME/builder} - -test -f Makefile && make -k distclean || : - -rm -rf build -mkdir build -cd build - -../autogen.sh --prefix=$AUTOBUILD_INSTALL_ROOT \ - --enable-gtk-doc - -make -make install - -# set -o pipefail is a bashism; this use of exec is the POSIX alternative -exec 3>&1 -st=$( - exec 4>&1 >&3 - { make check syntax-check 2>&1 3>&- 4>&-; echo $? >&4; } | tee "$RESULTS" -) -exec 3>&- -test "$st" = 0 - -rm -f *.tar.gz -make dist - -if [ -n "$AUTOBUILD_COUNTER" ]; then - EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER" -else - NOW=`date +"%s"` - EXTRA_RELEASE=".$USER$NOW" -fi - -if [ -f /usr/bin/rpmbuild ]; then - rpmbuild --nodeps \ - --define "extra_release $EXTRA_RELEASE" \ - --define "_sourcedir `pwd`" \ - -ba --clean libvirt-sandbox.spec -fi - -exit 0 -if [ -x /usr/bin/i686-pc-mingw32-gcc ]; then - make distclean - - PKG_CONFIG_PATH="$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig" \ - CC="i686-pc-mingw32-gcc" \ - ../configure \ - --build=$(uname -m)-pc-linux \ - --host=i686-pc-mingw32 \ - --prefix="$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw" - - make - make install - - #set -o pipefail - #make check 2>&1 | tee "$RESULTS" - - if [ -f /usr/bin/rpmbuild ]; then - rpmbuild --nodeps \ - --define "extra_release $EXTRA_RELEASE" \ - --define "_sourcedir `pwd`" \ - -ba --clean mingw32-libvirt-sandbox.spec - fi -fi -- 2.14.3
On Thu, May 03, 2018 at 05:42:50PM +0200, Andrea Bolognani wrote:
The Test-AutoBuild project, that this script is supposed to be used with, hasn't seen any activity in ~7 years; these days, libvirt-sandbox CI builds are happening on the Jenkins-based CentOS CI environment under the libvirt umbrella[1], and in that context the script is not used at all.
[1] https://ci.centos.org/view/libvirt/
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- autobuild.sh | 71 ------------------------------------------------------------ 1 file changed, 71 deletions(-) delete mode 100755 autobuild.sh
I used this script when cutting releases. Perhaps it is just something to rename to clarify its purpose Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Thu, 2018-05-03 at 16:46 +0100, Daniel P. Berrangé wrote:
On Thu, May 03, 2018 at 05:42:50PM +0200, Andrea Bolognani wrote:
The Test-AutoBuild project, that this script is supposed to be used with, hasn't seen any activity in ~7 years; these days, libvirt-sandbox CI builds are happening on the Jenkins-based CentOS CI environment under the libvirt umbrella[1], and in that context the script is not used at all.
[1] https://ci.centos.org/view/libvirt/
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- autobuild.sh | 71 ------------------------------------------------------------ 1 file changed, 71 deletions(-) delete mode 100755 autobuild.sh
I used this script when cutting releases. Perhaps it is just something to rename to clarify its purpose
I was not aware of that; sorry you had to point that out several times in response to a bunch of patches. Renaming the scripts sounds good to me. Just come up with a reasonable name and I'll go ahead with another round of patches. -- Andrea Bolognani / Red Hat / Virtualization
On Thu, May 03, 2018 at 05:58:07PM +0200, Andrea Bolognani wrote:
On Thu, 2018-05-03 at 16:46 +0100, Daniel P. Berrangé wrote:
On Thu, May 03, 2018 at 05:42:50PM +0200, Andrea Bolognani wrote:
The Test-AutoBuild project, that this script is supposed to be used with, hasn't seen any activity in ~7 years; these days, libvirt-sandbox CI builds are happening on the Jenkins-based CentOS CI environment under the libvirt umbrella[1], and in that context the script is not used at all.
[1] https://ci.centos.org/view/libvirt/
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- autobuild.sh | 71 ------------------------------------------------------------ 1 file changed, 71 deletions(-) delete mode 100755 autobuild.sh
I used this script when cutting releases. Perhaps it is just something to rename to clarify its purpose
I was not aware of that; sorry you had to point that out several times in response to a bunch of patches.
No worries - notice I didn't object to the python removal, since I'm not the person doing releases here :-)
Renaming the scripts sounds good to me. Just come up with a reasonable name and I'll go ahead with another round of patches.
Perhaps just call it 'make-release.sh' or similar ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Thu, 2018-05-03 at 16:59 +0100, Daniel P. Berrangé wrote:
On Thu, May 03, 2018 at 05:58:07PM +0200, Andrea Bolognani wrote:
Renaming the scripts sounds good to me. Just come up with a reasonable name and I'll go ahead with another round of patches.
Perhaps just call it 'make-release.sh' or similar ?
How does prepare-release.sh sound? -- Andrea Bolognani / Red Hat / Virtualization
On Thu, May 03, 2018 at 06:28:13PM +0200, Andrea Bolognani wrote:
On Thu, 2018-05-03 at 16:59 +0100, Daniel P. Berrangé wrote:
On Thu, May 03, 2018 at 05:58:07PM +0200, Andrea Bolognani wrote:
Renaming the scripts sounds good to me. Just come up with a reasonable name and I'll go ahead with another round of patches.
Perhaps just call it 'make-release.sh' or similar ?
How does prepare-release.sh sound?
Sure that, or check-release.sh, is fine with me. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (2)
-
Andrea Bolognani -
Daniel P. Berrangé