[libvirt] [python PATCH] build: provide wrapper makefile
After years of finger training, I'm so used to 'make check' just working, that I lose quite a bit of time re-learning that in this project, it is spelled 'python setup.py build check'. A shim makefile bridges the gap. * Makefile: New file. Signed-off-by: Eric Blake <eblake@redhat.com> --- I'd like to add this to the repo, but even if it gets rejected, I'll still keep it in my local tree :) Makefile | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Makefile diff --git a/Makefile b/Makefile new file mode 100644 index 0000000..6c8da0a --- /dev/null +++ b/Makefile @@ -0,0 +1,18 @@ +# Shim wrapper around setup.py to allow for familiar build targets + +PYTHON ?= python + +all: + $(PYTHON) setup.py build + +install: all + $(PYTHON) setup.py install + +clean: + $(PYTHON) setup.py clean + +check: all + $(PYTHON) setup.py test + +rpm: + $(PYTHON) setup.py rpm -- 1.9.3
On Thu, Jun 19, 2014 at 12:51 AM, Eric Blake <eblake@redhat.com> wrote:
After years of finger training, I'm so used to 'make check' just working, that I lose quite a bit of time re-learning that in this project, it is spelled 'python setup.py build check'. A shim makefile bridges the gap.
* Makefile: New file.
I see no harm in adding this. Definitely makes a developer's life easier. :)
Signed-off-by: Eric Blake <eblake@redhat.com> ---
I'd like to add this to the repo, but even if it gets rejected, I'll still keep it in my local tree :)
Makefile | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Makefile
diff --git a/Makefile b/Makefile new file mode 100644 index 0000000..6c8da0a --- /dev/null +++ b/Makefile @@ -0,0 +1,18 @@ +# Shim wrapper around setup.py to allow for familiar build targets + +PYTHON ?= python + +all: + $(PYTHON) setup.py build + +install: all + $(PYTHON) setup.py install + +clean: + $(PYTHON) setup.py clean + +check: all + $(PYTHON) setup.py test + +rpm: + $(PYTHON) setup.py rpm -- 1.9.3
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
-- Nehal J Wani
On 18.06.2014 21:21, Eric Blake wrote:
After years of finger training, I'm so used to 'make check' just working, that I lose quite a bit of time re-learning that in this project, it is spelled 'python setup.py build check'. A shim makefile bridges the gap.
Same applies here.
* Makefile: New file.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
I'd like to add this to the repo, but even if it gets rejected, I'll still keep it in my local tree :)
Makefile | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Makefile
diff --git a/Makefile b/Makefile new file mode 100644 index 0000000..6c8da0a --- /dev/null +++ b/Makefile @@ -0,0 +1,18 @@ +# Shim wrapper around setup.py to allow for familiar build targets + +PYTHON ?= python + +all: + $(PYTHON) setup.py build + +install: all + $(PYTHON) setup.py install + +clean: + $(PYTHON) setup.py clean + +check: all + $(PYTHON) setup.py test + +rpm: + $(PYTHON) setup.py rpm
ACK Michal
On 06/19/2014 03:40 AM, Michal Privoznik wrote:
On 18.06.2014 21:21, Eric Blake wrote:
After years of finger training, I'm so used to 'make check' just working, that I lose quite a bit of time re-learning that in this project, it is spelled 'python setup.py build check'. A shim makefile bridges the gap.
Same applies here.
ACK
No negative reaction, and two positive reviews, so I pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (3)
-
Eric Blake -
Michal Privoznik -
Nehal J Wani