[libvirt] [PATCH] virsh: clarify snapshot --live

From: Chen Hanxiao <chenhanxiao@gmail.com> In libvirt, snapshot means disk snapshot. snapshot --live is more like VM checkpoint. Make it clear in virsh.pod. Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com> --- tools/virsh.pod | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index fc6a680..30e6bf3 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3896,8 +3896,9 @@ this. If this flag is not specified, then some hypervisors may fail after partially performing the action, and B<dumpxml> must be used to see whether any partial changes occurred. -If I<--live> is specified, libvirt takes the snapshot while the guest is -running. This increases the size of the memory image of the external +If I<--live> is specified, libvirt takes the snapshot(checkpoint) while +the guest is running. Both disk snapshot and VM memory snapshot will be took. +This increases the size of the memory image of the external checkpoint. This is currently supported only for external checkpoints. Existence of snapshot metadata will prevent attempts to B<undefine> -- 1.8.3.1

On 05.08.2016 09:23, Chen Hanxiao wrote:
From: Chen Hanxiao <chenhanxiao@gmail.com>
In libvirt, snapshot means disk snapshot. snapshot --live is more like VM checkpoint. Make it clear in virsh.pod.
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com> --- tools/virsh.pod | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index fc6a680..30e6bf3 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3896,8 +3896,9 @@ this. If this flag is not specified, then some hypervisors may fail after partially performing the action, and B<dumpxml> must be used to see whether any partial changes occurred.
-If I<--live> is specified, libvirt takes the snapshot while the guest is -running. This increases the size of the memory image of the external +If I<--live> is specified, libvirt takes the snapshot(checkpoint) while +the guest is running. Both disk snapshot and VM memory snapshot will be took. +This increases the size of the memory image of the external checkpoint. This is currently supported only for external checkpoints.
Existence of snapshot metadata will prevent attempts to B<undefine>
Fixed grammar, ACKed and pushed. Michal

At 2016-08-05 15:23:52, "Chen Hanxiao" <chen_han_xiao@126.com> wrote:
From: Chen Hanxiao <chenhanxiao@gmail.com>
In libvirt, snapshot means disk snapshot. snapshot --live is more like VM checkpoint. Make it clear in virsh.pod.
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com> --- tools/virsh.pod | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index fc6a680..30e6bf3 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3896,8 +3896,9 @@ this. If this flag is not specified, then some hypervisors may fail after partially performing the action, and B<dumpxml> must be used to see whether any partial changes occurred.
-If I<--live> is specified, libvirt takes the snapshot while the guest is -running. This increases the size of the memory image of the external +If I<--live> is specified, libvirt takes the snapshot(checkpoint) while +the guest is running. Both disk snapshot and VM memory snapshot will be took. +This increases the size of the memory image of the external checkpoint. This is currently supported only for external checkpoints.
Existence of snapshot metadata will prevent attempts to B<undefine> --
ping Regards, - Chen
participants (2)
-
Chen Hanxiao
-
Michal Privoznik