[libvirt] libvirt-0.9.3 week freeze, RC1 version to test
So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know there is at least some cleanup issues, but I tried it locally and basic operations seems to work fine, please give it a try too and report issues, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/27/11 07:01, Daniel Veillard wrote:
So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know there is at least some cleanup issues, but I tried it locally and basic operations seems to work fine,
please give it a try too and report issues,
thanks !
Daniel
Reporting Slackware64-13.37: - --- compilation OK. ~~~ SNIP ~~~ ./configure \ --prefix=/usr/ \ --sysconfdir=/etc/ \ --libdir=/usr/lib${LIBDIRSUFFIX} \ --mandir=/usr/man/ \ --localstatedir=/var/ \ --enable-shared \ --enable-dependency-tracking \ --without-lxc \ --with-network \ --with-qemu \ --with-remote \ --with-sasl \ --with-storage-disk \ --with-storage-lvm \ --with-storage-scsi \ --with-libvirtd \ ~~~ SNIP ~~~ ~~~ SNIP ~~~ /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined CC libvirt_util_la-netlink.lo /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined CC libvirt_util_la-pci.lo CC libvirt_util_la-processinfo.lo CC libvirt_util_la-hostusb.lo CC libvirt_util_la-network.lo CC libvirt_util_la-interface.lo CC libvirt_util_la-qparams.lo /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined ~~~ SNIP ~~~ ~~~ SNIP ~~~ =================== All 52 tests passed =================== ~~~ SNIP ~~~ Regards, Z. - -- Zdenek Styblik Net/Linux admin OS TurnovFree.net email: stybla@turnovfree.net jabber: stybla@jabber.turnovfree.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk4IF8EACgkQ8MreUbSH7inLagCgoSZmzfr8qC9gTPmCR9C//GOQ 6DcAmwXaq89tIz0TmuIQ6IBMP4/bwCIg =Ltd3 -----END PGP SIGNATURE-----
2011/6/27 Zdenek Styblik <stybla@turnovfree.net>:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 06/27/11 07:01, Daniel Veillard wrote:
So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know there is at least some cleanup issues, but I tried it locally and basic operations seems to work fine,
please give it a try too and report issues,
thanks !
Daniel
Reporting Slackware64-13.37: - ---
compilation OK.
~~~ SNIP ~~~ ./configure \ --prefix=/usr/ \ --sysconfdir=/etc/ \ --libdir=/usr/lib${LIBDIRSUFFIX} \ --mandir=/usr/man/ \ --localstatedir=/var/ \ --enable-shared \ --enable-dependency-tracking \ --without-lxc \ --with-network \ --with-qemu \ --with-remote \ --with-sasl \ --with-storage-disk \ --with-storage-lvm \ --with-storage-scsi \ --with-libvirtd \ ~~~ SNIP ~~~
~~~ SNIP ~~~ /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined CC libvirt_util_la-netlink.lo /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined CC libvirt_util_la-pci.lo CC libvirt_util_la-processinfo.lo CC libvirt_util_la-hostusb.lo CC libvirt_util_la-network.lo CC libvirt_util_la-interface.lo CC libvirt_util_la-qparams.lo /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined ~~~ SNIP ~~~
This is a known problem in libnl. This can be fixed in Slackware's libnl package by removing the inline keyword from the declaration of nl_object_priv in /usr/include/netlink/object.h. -- Matthias Bolte http://photron.blogspot.com
On 06/27/2011 07:30 AM, Matthias Bolte wrote:
Reporting Slackware64-13.37: - ---
compilation OK.
~~~ SNIP ~~~ ./configure \ --prefix=/usr/ \ --sysconfdir=/etc/ \ --libdir=/usr/lib${LIBDIRSUFFIX} \ --mandir=/usr/man/ \ --localstatedir=/var/ \ --enable-shared \ --enable-dependency-tracking \ --without-lxc \ --with-network \ --with-qemu \ --with-remote \ --with-sasl \ --with-storage-disk \ --with-storage-lvm \ --with-storage-scsi \ --with-libvirtd \ ~~~ SNIP ~~~
~~~ SNIP ~~~ /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined CC libvirt_util_la-netlink.lo /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined CC libvirt_util_la-pci.lo CC libvirt_util_la-processinfo.lo CC libvirt_util_la-hostusb.lo CC libvirt_util_la-network.lo CC libvirt_util_la-interface.lo CC libvirt_util_la-qparams.lo /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined ~~~ SNIP ~~~ This is a known problem in libnl. This can be fixed in Slackware's
2011/6/27 Zdenek Styblik<stybla@turnovfree.net>: libnl package by removing the inline keyword from the declaration of nl_object_priv in /usr/include/netlink/object.
What is the version of libnl used in Slackware? It seems that libnl is getting included on more platforms now, so we probably need to get more serious about making sure our code works with different versions of libnl.
On 06/27/2011 09:11 AM, Laine Stump wrote:
On 06/27/2011 07:30 AM, Matthias Bolte wrote:
2011/6/27 Zdenek Styblik<stybla@turnovfree.net>:
Reporting Slackware64-13.37:
/usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined ~~~ SNIP ~~~ This is a known problem in libnl. This can be fixed in Slackware's libnl package by removing the inline keyword from the declaration of nl_object_priv in /usr/include/netlink/object.
What is the version of libnl used in Slackware? It seems that libnl is getting included on more platforms now, so we probably need to get more serious about making sure our code works with different versions of libnl.
If it is anything like Ubuntu, then this (hacky) patch will work around the problem in spite of the broken libnl headers. It's just that I'm reluctant to apply it because it is such a hack, but given the number of distros with broken libnl installations, maybe we should do it after all. From ec12ae6be618f77542e30017eb80cffadd95e4f2 Mon Sep 17 00:00:00 2001 From: Eric Blake <eblake@redhat.com> Date: Thu, 23 Jun 2011 16:30:15 -0600 Subject: [PATCH] work around libnl bug --- src/util/netlink.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/util/netlink.h b/src/util/netlink.h index 6e915ff..de0e98b 100644 --- a/src/util/netlink.h +++ b/src/util/netlink.h @@ -24,7 +24,9 @@ # if defined(__linux__) && defined(HAVE_LIBNL) +# define inline # include <netlink/msg.h> +# undef inline # else -- 1.7.4.4 -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 06/27/11 17:11, Laine Stump wrote:
On 06/27/2011 07:30 AM, Matthias Bolte wrote:
2011/6/27 Zdenek Styblik<stybla@turnovfree.net>: [...]
~~~ SNIP ~~~ /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined CC libvirt_util_la-netlink.lo /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined CC libvirt_util_la-pci.lo CC libvirt_util_la-processinfo.lo CC libvirt_util_la-hostusb.lo CC libvirt_util_la-network.lo CC libvirt_util_la-interface.lo CC libvirt_util_la-qparams.lo /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined /usr/include/netlink/object.h:58:23: warning: inline function 'nl_object_priv' declared but never defined ~~~ SNIP ~~~
This is a known problem in libnl. This can be fixed in Slackware's libnl package by removing the inline keyword from the declaration of nl_object_priv in /usr/include/netlink/object.
What is the version of libnl used in Slackware? It seems that libnl is getting included on more platforms now, so we probably need to get more serious about making sure our code works with different versions of libnl.
libnl-1.1-x86_64-1 Z. -- Zdenek Styblik Net/Linux admin OS TurnovFree.net email: stybla@turnovfree.net jabber: stybla@jabber.turnovfree.net
? 2011-6-27 13:01, Daniel Veillard ??:
So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know there is at least some cleanup issues, but I tried it locally and basic operations seems to work fine,
please give it a try too and report issues,
thanks !
Daniel
On fc14.x86_64 TEST: networkxml2argvtest FAIL Download libvirt-0.9.3-rc1.tar.gz ./configure&& make&& make check It report1 of 52 tests failed TEST: networkxml2argvtest !.!!!!! 7 FAIL FAIL: networkxml2argvtest 1 of 52 tests failed Please report tolibvir-list@redhat.com <mailto:libvir-list@redhat.com>
2011/6/27 simon <simonjin@linux.vnet.ibm.com>:
于 2011-6-27 13:01, Daniel Veillard 写道:
So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know there is at least some cleanup issues, but I tried it locally and basic operations seems to work fine,
please give it a try too and report issues,
thanks !
Daniel
On fc14.x86_64 TEST: networkxml2argvtest FAIL
Download libvirt-0.9.3-rc1.tar.gz
./configure && make && make check
It report 1 of 52 tests failed
TEST: networkxml2argvtest !.!!!!! 7 FAIL FAIL: networkxml2argvtest
This a known problem when you configure libvirt with localstatedir other than /var, what happens when you just run configure without arguments. We're working on a fix for this. -- Matthias Bolte http://photron.blogspot.com
On 06/27/2011 07:32 AM, Matthias Bolte wrote:
2011/6/27 simon<simonjin@linux.vnet.ibm.com>:
于 2011-6-27 13:01, Daniel Veillard 写道:
So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know there is at least some cleanup issues, but I tried it locally and basic operations seems to work fine,
please give it a try too and report issues,
thanks !
Daniel
On fc14.x86_64 TEST: networkxml2argvtest FAIL
Download libvirt-0.9.3-rc1.tar.gz
./configure&& make&& make check
It report 1 of 52 tests failed
TEST: networkxml2argvtest !.!!!!! 7 FAIL FAIL: networkxml2argvtest This a known problem when you configure libvirt with localstatedir other than /var, what happens when you just run configure without arguments.
It looks like that's what he did, so maybe this is a different problem (or possibly his configure defaults to /usr/local/var?). If the default localstatedir isn't /var, try doing "./autogen.sh --system" instead of ./configure. If that doesn't cure the problem, try running the test with debug logging turned on to see exactly what error is reported: LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 ./networkxml2argvtest
2011/6/27 Laine Stump <laine@laine.org>:
On 06/27/2011 07:32 AM, Matthias Bolte wrote:
2011/6/27 simon<simonjin@linux.vnet.ibm.com>:
于 2011-6-27 13:01, Daniel Veillard 写道:
So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know there is at least some cleanup issues, but I tried it locally and basic operations seems to work fine,
please give it a try too and report issues,
thanks !
Daniel
On fc14.x86_64 TEST: networkxml2argvtest FAIL
Download libvirt-0.9.3-rc1.tar.gz
./configure&& make&& make check
It report 1 of 52 tests failed
TEST: networkxml2argvtest !.!!!!! 7 FAIL FAIL: networkxml2argvtest
This a known problem when you configure libvirt with localstatedir other than /var, what happens when you just run configure without arguments.
It looks like that's what he did, so maybe this is a different problem (or possibly his configure defaults to /usr/local/var?).
If the default localstatedir isn't /var, try doing "./autogen.sh --system" instead of ./configure. If that doesn't cure the problem, try running the test with debug logging turned on to see exactly what error is reported:
LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 ./networkxml2argvtest
5 of 6 failing tests are fixed by this patch I just pushed: https://www.redhat.com/archives/libvir-list/2011-June/msg01358.html The last one is related to the fact that networkBuildDhcpDaemonCommandLine writes dnsmasq config files to disk relative to DNSMASQ_STATE_DIR and DNSMASQ_STATE_DIR is configure --localstatedir dependent. You also noticed this in your review: https://www.redhat.com/archives/libvir-list/2011-June/msg01284.html As Dan suggested on IRC this should be refactored and will then also fix the last test failure. <danpb> yeah this is bad code structure IMHO <danpb> the call to networkSaveDnsmasqHostsfile() should be removed from networkBuildDhcpDaemonCommandLine / networkBuildDnsmasqArgv <danpb> whatever calls networkBuildDhcpDaemonCommandLine should be made responsible for actually creating the hosts file <danpb> the networkBuildDnsmasqArgv method should solely create the CLI args, and assume someone else has taken care of actualyl creating the file on disk -- Matthias Bolte http://photron.blogspot.com
于 2011-6-27 23:17, Laine Stump 写道:
On 06/27/2011 07:32 AM, Matthias Bolte wrote:
2011/6/27 simon<simonjin@linux.vnet.ibm.com>:
于 2011-6-27 13:01, Daniel Veillard 写道:
So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know there is at least some cleanup issues, but I tried it locally and basic operations seems to work fine,
please give it a try too and report issues,
thanks !
Daniel
On fc14.x86_64 TEST: networkxml2argvtest FAIL
Download libvirt-0.9.3-rc1.tar.gz
./configure&& make&& make check
It report 1 of 52 tests failed
TEST: networkxml2argvtest !.!!!!! 7 FAIL FAIL: networkxml2argvtest This a known problem when you configure libvirt with localstatedir other than /var, what happens when you just run configure without arguments.
It looks like that's what he did, so maybe this is a different problem (or possibly his configure defaults to /usr/local/var?).
If the default localstatedir isn't /var, try doing "./autogen.sh --system" instead of ./configure. If that doesn't cure the problem, try running the test with debug logging turned on to see exactly what error is reported:
LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 ./networkxml2argvtest
I didn't use any arguments in configure, but the defaults localstatdir is /usr/local/var. I found below lines in config.status: S["prefix"]="/usr/local" S["localstatedir"]="${prefix}/var" ./autogen.sh --system will fix this issue. [libvirt-0.9.3]$ LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 tests/networkxml2argvtest TEST: tests/networkxml2argvtest 1) Network XML-2-Argv isolated-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/isolated-network.xml: failed to open: No such file or directory FAILED 2) Network XML-2-Argv routed-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/routed-network.xml: failed to open: No such file or directory FAILED 3) Network XML-2-Argv nat-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network.xml: failed to open: No such file or directory FAILED 4) Network XML-2-Argv netboot-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/netboot-network.xml: failed to open: No such file or directory FAILED 5) Network XML-2-Argv netboot-proxy-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/netboot-proxy-network.xml: failed to open: No such file or directory FAILED 6) Network XML-2-Argv nat-network-dns-txt-record ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network-dns-txt-record.xml: failed to open: No such file or directory FAILED 7) Network XML-2-Argv nat-network-dns-hosts ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network-dns-hosts.xml: failed to open: No such file or directory FAILED Those .xml files actully under test/. -Simon Jin
2011/6/28 simon jin <simonjin@linux.vnet.ibm.com>:
于 2011-6-27 23:17, Laine Stump 写道:
On 06/27/2011 07:32 AM, Matthias Bolte wrote:
2011/6/27 simon<simonjin@linux.vnet.ibm.com>:
于 2011-6-27 13:01, Daniel Veillard 写道:
So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know there is at least some cleanup issues, but I tried it locally and basic operations seems to work fine,
please give it a try too and report issues,
thanks !
Daniel
On fc14.x86_64 TEST: networkxml2argvtest FAIL
Download libvirt-0.9.3-rc1.tar.gz
./configure&& make&& make check
It report 1 of 52 tests failed
TEST: networkxml2argvtest !.!!!!! 7 FAIL FAIL: networkxml2argvtest
This a known problem when you configure libvirt with localstatedir other than /var, what happens when you just run configure without arguments.
It looks like that's what he did, so maybe this is a different problem (or possibly his configure defaults to /usr/local/var?).
If the default localstatedir isn't /var, try doing "./autogen.sh --system" instead of ./configure. If that doesn't cure the problem, try running the test with debug logging turned on to see exactly what error is reported:
LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 ./networkxml2argvtest
I didn't use any arguments in configure, but the defaults localstatdir is /usr/local/var. I found below lines in config.status: S["prefix"]="/usr/local" S["localstatedir"]="${prefix}/var"
./autogen.sh --system will fix this issue.
[libvirt-0.9.3]$ LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 tests/networkxml2argvtest TEST: tests/networkxml2argvtest 1) Network XML-2-Argv isolated-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/isolated-network.xml: failed to open: No such file or directory FAILED 2) Network XML-2-Argv routed-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/routed-network.xml: failed to open: No such file or directory FAILED 3) Network XML-2-Argv nat-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network.xml: failed to open: No such file or directory FAILED 4) Network XML-2-Argv netboot-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/netboot-network.xml: failed to open: No such file or directory FAILED 5) Network XML-2-Argv netboot-proxy-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/netboot-proxy-network.xml: failed to open: No such file or directory FAILED 6) Network XML-2-Argv nat-network-dns-txt-record ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network-dns-txt-record.xml: failed to open: No such file or directory FAILED 7) Network XML-2-Argv nat-network-dns-hosts ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network-dns-hosts.xml: failed to open: No such file or directory FAILED
Those .xml files actully under test/.
-Simon Jin
That's expected because you need to be in the tests directory to run a test manually or set the srcdir envvar to point to the test directory You ran LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 tests/networkxml2argvtest but Laine suggested LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 ./networkxml2argvtest and missed to explicitly state that you need to cd to the tests directory first. -- Matthias Bolte http://photron.blogspot.com
于 2011-6-28 16:20, Matthias Bolte 写道:
2011/6/28 simon jin<simonjin@linux.vnet.ibm.com>:
于 2011-6-27 23:17, Laine Stump 写道:
On 06/27/2011 07:32 AM, Matthias Bolte wrote:
2011/6/27 simon<simonjin@linux.vnet.ibm.com>:
于 2011-6-27 13:01, Daniel Veillard 写道:
So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know there is at least some cleanup issues, but I tried it locally and basic operations seems to work fine,
please give it a try too and report issues,
thanks !
Daniel
On fc14.x86_64 TEST: networkxml2argvtest FAIL
Download libvirt-0.9.3-rc1.tar.gz
./configure&& make&& make check
It report 1 of 52 tests failed
TEST: networkxml2argvtest !.!!!!! 7 FAIL FAIL: networkxml2argvtest
This a known problem when you configure libvirt with localstatedir other than /var, what happens when you just run configure without arguments.
It looks like that's what he did, so maybe this is a different problem (or possibly his configure defaults to /usr/local/var?).
If the default localstatedir isn't /var, try doing "./autogen.sh --system" instead of ./configure. If that doesn't cure the problem, try running the test with debug logging turned on to see exactly what error is reported:
LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 ./networkxml2argvtest
I didn't use any arguments in configure, but the defaults localstatdir is /usr/local/var. I found below lines in config.status: S["prefix"]="/usr/local" S["localstatedir"]="${prefix}/var"
./autogen.sh --system will fix this issue.
[libvirt-0.9.3]$ LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 tests/networkxml2argvtest TEST: tests/networkxml2argvtest 1) Network XML-2-Argv isolated-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/isolated-network.xml: failed to open: No such file or directory FAILED 2) Network XML-2-Argv routed-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/routed-network.xml: failed to open: No such file or directory FAILED 3) Network XML-2-Argv nat-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network.xml: failed to open: No such file or directory FAILED 4) Network XML-2-Argv netboot-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/netboot-network.xml: failed to open: No such file or directory FAILED 5) Network XML-2-Argv netboot-proxy-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/netboot-proxy-network.xml: failed to open: No such file or directory FAILED 6) Network XML-2-Argv nat-network-dns-txt-record ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network-dns-txt-record.xml: failed to open: No such file or directory FAILED 7) Network XML-2-Argv nat-network-dns-hosts ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network-dns-hosts.xml: failed to open: No such file or directory FAILED
Those .xml files actully under test/.
-Simon Jin That's expected because you need to be in the tests directory to run a test manually or set the srcdir envvar to point to the test directory
You ran
LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 tests/networkxml2argvtest
but Laine suggested
LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 ./networkxml2argvtest
and missed to explicitly state that you need to cd to the tests directory first.
cd test and run: [tests]$ sudo LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 ./networkxml2argvtest [sudo] password for simon: TEST: networkxml2argvtest 1) Network XML-2-Argv isolated-network ... Expect [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file= --except-interface lo --dhcp-option=3 --listen-address 192.168.152.1 --dhcp-range 192.168.152.2,192.168.152.254 *--dhcp-leasefile=/var/lib/libvirt/dnsmasq/private.leases*--dhcp-lease-max=253 --dhcp-no-override] Actual [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file= --except-interface lo --dhcp-option=3 --listen-address 192.168.152.1 --dhcp-range 192.168.152.2,192.168.152.254 *--dhcp-leasefile=/usr/local/var/lib/libvirt/dnsmasq/private.leases *--dhcp-lease-max=253 --dhcp-no-override] ... FAILED Yes, the root cause is --localstatdir isn't set to /var. i see you have fixed it in trunk. Thanks -Simon Jin 2) Network XML-2-Argv routed-network ... OK 3) Network XML-2-Argv nat-network ... 16:31:38.713: 5636: info : libvirt version: 0.9.3 16:31:38.713: 5636: error : hostsfileSave:446 : cannot write config file '/usr/local/var/lib/libvirt/dnsmasq/default.hostsfile': Unknown error 18446744073709551614 Expect [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file= --except-interface lo --listen-address 192.168.122.1 --listen-address 192.168.123.1 --listen-address 2001:db8:ac10:fe01::1 --listen-address 2001:db8:ac10:fd01::1 --listen-address 10.24.10.1 --dhcp-range 192.168.122.2,192.168.122.254 --dhcp-leasefile=/var/lib/libvirt/dnsmasq/default.leases --dhcp-lease-max=253 --dhcp-no-override] Actual [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file= --except-interface lo --listen-address 192.168.122.1 --listen-address 192.168.123.1 --listen-address 2001:db8:ac10:fe01::1 --listen-address 2001:db8:ac10:fd01::1 --listen-address 10.24.10.1 --dhcp-range 192.168.122.2,192.168.122.254 --dhcp-leasefile=/usr/local/var/lib/libvirt/dnsmasq/default.leases --dhcp-lease-max=253 --dhcp-no-override] ... libvir: Network Config error : cannot write config file '/usr/local/var/lib/libvirt/dnsmasq/default.hostsfile': Unknown error 18446744073709551614 FAILED 4) Network XML-2-Argv netboot-network ... Expect [/usr/sbin/dnsmasq --strict-order --bind-interfaces --domain example.com --conf-file= --except-interface lo --listen-address 192.168.122.1 --dhcp-range 192.168.122.2,192.168.122.254 --dhcp-leasefile=/var/lib/libvirt/dnsmasq/netboot.leases --dhcp-lease-max=253 --dhcp-no-override --enable-tftp --tftp-root /var/lib/tftproot --dhcp-boot pxeboot.img] Actual [/usr/sbin/dnsmasq --strict-order --bind-interfaces --domain example.com --conf-file= --except-interface lo --listen-address 192.168.122.1 --dhcp-range 192.168.122.2,192.168.122.254 --dhcp-leasefile=/usr/local/var/lib/libvirt/dnsmasq/netboot.leases --dhcp-lease-max=253 --dhcp-no-override --enable-tftp --tftp-root /var/lib/tftproot --dhcp-boot pxeboot.img] ... FAILED 5) Network XML-2-Argv netboot-proxy-network ... Expect [/usr/sbin/dnsmasq --strict-order --bind-interfaces --domain example.com --conf-file= --except-interface lo --listen-address 192.168.122.1 --dhcp-range 192.168.122.2,192.168.122.254 --dhcp-leasefile=/var/lib/libvirt/dnsmasq/netboot.leases --dhcp-lease-max=253 --dhcp-no-override --dhcp-boot pxeboot.img,,10.20.30.40] Actual [/usr/sbin/dnsmasq --strict-order --bind-interfaces --domain example.com --conf-file= --except-interface lo --listen-address 192.168.122.1 --dhcp-range 192.168.122.2,192.168.122.254 --dhcp-leasefile=/usr/local/var/lib/libvirt/dnsmasq/netboot.leases --dhcp-lease-max=253 --dhcp-no-override --dhcp-boot pxeboot.img,,10.20.30.40] ... FAILED 6) Network XML-2-Argv nat-network-dns-txt-record ... Expect [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file= --except-interface lo --txt-record=example,example value --listen-address 192.168.122.1 --listen-address 192.168.123.1 --listen-address 2001:db8:ac10:fe01::1 --listen-address 2001:db8:ac10:fd01::1 --listen-address 10.24.10.1 --dhcp-range 192.168.122.2,192.168.122.254 --dhcp-leasefile=/var/lib/libvirt/dnsmasq/default.leases --dhcp-lease-max=253 --dhcp-no-override] Actual [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file= --except-interface lo --txt-record=example,example value --listen-address 192.168.122.1 --listen-address 192.168.123.1 --listen-address 2001:db8:ac10:fe01::1 --listen-address 2001:db8:ac10:fd01::1 --listen-address 10.24.10.1 --dhcp-range 192.168.122.2,192.168.122.254 --dhcp-leasefile=/usr/local/var/lib/libvirt/dnsmasq/default.leases --dhcp-lease-max=253 --dhcp-no-override] ... FAILED 7) Network XML-2-Argv nat-network-dns-hosts ... Expect [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file= --except-interface lo --listen-address 192.168.122.1 --addn-hosts=/var/lib/libvirt/dnsmasq/default.addnhosts] Actual [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file= --except-interface lo --listen-address 192.168.122.1 --addn-hosts=/usr/local/var/lib/libvirt/dnsmasq/default.addnhosts] ... FAILED
2011/6/28 simon jin <simonjin@linux.vnet.ibm.com>:
于 2011-6-28 16:20, Matthias Bolte 写道:
2011/6/28 simon jin <simonjin@linux.vnet.ibm.com>:
于 2011-6-27 23:17, Laine Stump 写道:
On 06/27/2011 07:32 AM, Matthias Bolte wrote:
2011/6/27 simon<simonjin@linux.vnet.ibm.com>:
于 2011-6-27 13:01, Daniel Veillard 写道:
So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know there is at least some cleanup issues, but I tried it locally and basic operations seems to work fine,
please give it a try too and report issues,
thanks !
Daniel
On fc14.x86_64 TEST: networkxml2argvtest FAIL
Download libvirt-0.9.3-rc1.tar.gz
./configure&& make&& make check
It report 1 of 52 tests failed
TEST: networkxml2argvtest !.!!!!! 7 FAIL FAIL: networkxml2argvtest
This a known problem when you configure libvirt with localstatedir other than /var, what happens when you just run configure without arguments.
It looks like that's what he did, so maybe this is a different problem (or possibly his configure defaults to /usr/local/var?).
If the default localstatedir isn't /var, try doing "./autogen.sh --system" instead of ./configure. If that doesn't cure the problem, try running the test with debug logging turned on to see exactly what error is reported:
LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 ./networkxml2argvtest
I didn't use any arguments in configure, but the defaults localstatdir is /usr/local/var. I found below lines in config.status: S["prefix"]="/usr/local" S["localstatedir"]="${prefix}/var"
./autogen.sh --system will fix this issue.
[libvirt-0.9.3]$ LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 tests/networkxml2argvtest TEST: tests/networkxml2argvtest 1) Network XML-2-Argv isolated-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/isolated-network.xml: failed to open: No such file or directory FAILED 2) Network XML-2-Argv routed-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/routed-network.xml: failed to open: No such file or directory FAILED 3) Network XML-2-Argv nat-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network.xml: failed to open: No such file or directory FAILED 4) Network XML-2-Argv netboot-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/netboot-network.xml: failed to open: No such file or directory FAILED 5) Network XML-2-Argv netboot-proxy-network ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/netboot-proxy-network.xml: failed to open: No such file or directory FAILED 6) Network XML-2-Argv nat-network-dns-txt-record ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network-dns-txt-record.xml: failed to open: No such file or directory FAILED 7) Network XML-2-Argv nat-network-dns-hosts ... /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network-dns-hosts.xml: failed to open: No such file or directory FAILED
Those .xml files actully under test/.
-Simon Jin
That's expected because you need to be in the tests directory to run a test manually or set the srcdir envvar to point to the test directory
You ran
LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 tests/networkxml2argvtest
but Laine suggested
LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 ./networkxml2argvtest
and missed to explicitly state that you need to cd to the tests directory first.
cd test and run: [tests]$ sudo LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 ./networkxml2argvtest [sudo] password for simon: TEST: networkxml2argvtest 1) Network XML-2-Argv isolated-network ... Expect [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file= --except-interface lo --dhcp-option=3 --listen-address 192.168.152.1 --dhcp-range 192.168.152.2,192.168.152.254 --dhcp-leasefile=/var/lib/libvirt/dnsmasq/private.leases --dhcp-lease-max=253 --dhcp-no-override] Actual [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file= --except-interface lo --dhcp-option=3 --listen-address 192.168.152.1 --dhcp-range 192.168.152.2,192.168.152.254 --dhcp-leasefile=/usr/local/var/lib/libvirt/dnsmasq/private.leases --dhcp-lease-max=253 --dhcp-no-override] ... FAILED
Yes, the root cause is --localstatdir isn't set to /var. i see you have fixed it in trunk. Thanks -Simon Jin
Yep, that fixed 5 of 6 test failures.
2) Network XML-2-Argv routed-network ... OK 3) Network XML-2-Argv nat-network ... 16:31:38.713: 5636: info : libvirt version: 0.9.3 16:31:38.713: 5636: error : hostsfileSave:446 : cannot write config file '/usr/local/var/lib/libvirt/dnsmasq/default.hostsfile': Unknown error 18446744073709551614
Expect [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file= --except-interface lo --listen-address 192.168.122.1 --listen-address 192.168.123.1 --listen-address 2001:db8:ac10:fe01::1 --listen-address 2001:db8:ac10:fd01::1 --listen-address 10.24.10.1 --dhcp-range 192.168.122.2,192.168.122.254 --dhcp-leasefile=/var/lib/libvirt/dnsmasq/default.leases --dhcp-lease-max=253 --dhcp-no-override] Actual [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file= --except-interface lo --listen-address 192.168.122.1 --listen-address 192.168.123.1 --listen-address 2001:db8:ac10:fe01::1 --listen-address 2001:db8:ac10:fd01::1 --listen-address 10.24.10.1 --dhcp-range 192.168.122.2,192.168.122.254 --dhcp-leasefile=/usr/local/var/lib/libvirt/dnsmasq/default.leases --dhcp-lease-max=253 --dhcp-no-override] ... libvir: Network Config error : cannot write config file '/usr/local/var/lib/libvirt/dnsmasq/default.hostsfile': Unknown error 18446744073709551614 FAILED
The tested code tries to write files to disk, it shouldn't do that. Also the tests are wrong and hide a logic error introduced by the recent changes to support DNS TXT records. I posted a patch for this a moment ago https://www.redhat.com/archives/libvir-list/2011-June/msg01423.html -- Matthias Bolte http://photron.blogspot.com
On Mon, 2011-06-27 at 13:01 +0800, Daniel Veillard wrote:
So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know there is at least some cleanup issues, but I tried it locally and basic operations seems to work fine,
please give it a try too and report issues,
thanks !
Daniel
sanlock-devel seems to be in rawhide, not f15: $make rpm ... make[1]: Leaving directory `/home/stenzel/projects/libvirt-0.9.3' error: Failed build dependencies: sanlock-devel is needed by libvirt-0.9.3-0rc1.fc15.x86_64 make: *** [rpm] Error 1 $ cat /etc/redhat-release Fedora release 15 (Lovelock) libvirt.spec assumes f15 and higher: # Enable sanlock library for lock management with QEMU %if 0%{?fedora} >= 15 || 0%{?rhel} >= 6 %define with_sanlock 0%{!?_without_sanlock:%{server_drivers}} %endif -- Best regards, Gerhard Stenzel, ----------------------------------------------------------------------------------------------------------------------------------- IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
* libvirt.spec.in (with_sanlock): Only default on in rawhide. Reported by Gerhard Stenzel. --- libvirt.spec.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 0111519..a4f050d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -164,7 +164,7 @@ %endif # Enable sanlock library for lock management with QEMU -%if 0%{?fedora} >= 15 || 0%{?rhel} >= 6 +%if 0%{?fedora} >= 16 || 0%{?rhel} >= 6 %define with_sanlock 0%{!?_without_sanlock:%{server_drivers}} %endif -- 1.7.4.4
On Tue, Jun 28, 2011 at 09:52:27AM -0600, Eric Blake wrote:
* libvirt.spec.in (with_sanlock): Only default on in rawhide. Reported by Gerhard Stenzel. --- libvirt.spec.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 0111519..a4f050d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -164,7 +164,7 @@ %endif
# Enable sanlock library for lock management with QEMU -%if 0%{?fedora} >= 15 || 0%{?rhel} >= 6 +%if 0%{?fedora} >= 16 || 0%{?rhel} >= 6 %define with_sanlock 0%{!?_without_sanlock:%{server_drivers}} %endif
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 06/28/2011 11:16 AM, Daniel P. Berrange wrote:
On Tue, Jun 28, 2011 at 09:52:27AM -0600, Eric Blake wrote:
* libvirt.spec.in (with_sanlock): Only default on in rawhide. Reported by Gerhard Stenzel. --- libvirt.spec.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 0111519..a4f050d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -164,7 +164,7 @@ %endif
# Enable sanlock library for lock management with QEMU -%if 0%{?fedora} >= 15 || 0%{?rhel} >= 6 +%if 0%{?fedora} >= 16 || 0%{?rhel} >= 6 %define with_sanlock 0%{!?_without_sanlock:%{server_drivers}} %endif
ACK
Pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Following the changes done in the daemon and client code to use the new RPC implementation, and the large amount of patches and fixes since RC1 I have made a new release candidate RC2 based on current git. ftp://libvirt.org/libvirt/libvirt-0.9.3-rc2.tar.gz as well as related rpms for those interested. Please give it a try, it works for my limited use cases, but the RPC changes could introduce regressions, so your feedback is really important ! thanks in advance, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On 06/30/11 05:36, Daniel Veillard wrote:
Following the changes done in the daemon and client code to use the new RPC implementation, and the large amount of patches and fixes since RC1 I have made a new release candidate RC2 based on current git. ftp://libvirt.org/libvirt/libvirt-0.9.3-rc2.tar.gz as well as related rpms for those interested. Please give it a try, it works for my limited use cases, but the RPC changes could introduce regressions, so your feedback is really important !
thanks in advance,
Daniel
Slackware64-13.37 is still a go as far as a compilation goes. Z. -- Zdenek Styblik Net/Linux admin OS TurnovFree.net email: stybla@turnovfree.net jabber: stybla@jabber.turnovfree.net
At 06/30/2011 11:36 AM, Daniel Veillard Write:
Following the changes done in the daemon and client code to use the new RPC implementation, and the large amount of patches and fixes since RC1 I have made a new release candidate RC2 based on current git. ftp://libvirt.org/libvirt/libvirt-0.9.3-rc2.tar.gz as well as related rpms for those interested.
I try to build rpms from the tar package, and meet the following error: .... CC libvirt_lxc-cpu_conf.o make[3]: *** No rule to make target `locking/libvirt_sanlock.aug', needed by `all-am'. Stop. make[3]: *** Waiting for unfinished jobs.... CC libvirt_lxc-nwfilter_params.o .... I build rpms from git tree and it's OK. The file src/locking/libvirt_sanlock.aug is not included into the tar package.
Please give it a try, it works for my limited use cases, but the RPC changes could introduce regressions, so your feedback is really important !
thanks in advance,
Daniel
On 06/30/2011 12:04 AM, Wen Congyang wrote:
At 06/30/2011 11:36 AM, Daniel Veillard Write:
Following the changes done in the daemon and client code to use the new RPC implementation, and the large amount of patches and fixes since RC1 I have made a new release candidate RC2 based on current git. ftp://libvirt.org/libvirt/libvirt-0.9.3-rc2.tar.gz as well as related rpms for those interested.
I try to build rpms from the tar package, and meet the following error:
.... CC libvirt_lxc-cpu_conf.o make[3]: *** No rule to make target `locking/libvirt_sanlock.aug', needed by `all-am'. Stop. make[3]: *** Waiting for unfinished jobs.... CC libvirt_lxc-nwfilter_params.o ....
I build rpms from git tree and it's OK.
The file src/locking/libvirt_sanlock.aug is not included into the tar package.
This should be fixed by this (as-yet un-acked) patch: https://www.redhat.com/archives/libvir-list/2011-June/msg01537.html -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
于 2011年06月30日 11:36, Daniel Veillard 写道:
Following the changes done in the daemon and client code to use the new RPC implementation, and the large amount of patches and fixes since RC1 I have made a new release candidate RC2 based on current git. ftp://libvirt.org/libvirt/libvirt-0.9.3-rc2.tar.gz as well as related rpms for those interested. Please give it a try, it works for my limited use cases, but the RPC changes could introduce regressions, so your feedback is really important !
thanks in advance,
Daniel
tests/.valgrind.supp is removed unintentionally? # make valgrind ..... ==19673== FATAL: can't open suppressions file "./.valgrind.supp" FAIL: read-non-seekable ==19683== FATAL: can't open suppressions file "./.valgrind.sup .... Regards Osier
On 06/30/2011 01:55 AM, Osier Yang wrote:
于 2011年06月30日 11:36, Daniel Veillard 写道:
Following the changes done in the daemon and client code to use the new RPC implementation, and the large amount of patches and fixes since RC1 I have made a new release candidate RC2 based on current git. ftp://libvirt.org/libvirt/libvirt-0.9.3-rc2.tar.gz as well as related rpms for those interested. Please give it a try, it works for my limited use cases, but the RPC changes could introduce regressions, so your feedback is really important !
thanks in advance,
Daniel
tests/.valgrind.supp is removed unintentionally?
It's still in git. The problem is that it is missing from EXTRA_DIST in tests/Makefile.am, so it is unintentionally omitted from tarballs. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
--- tests/Makefile.am | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 7db9d1f..e6c5a5e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -74,7 +74,8 @@ EXTRA_DIST = \ xencapsdata \ xmconfigdata \ xml2sexprdata \ - xml2vmxdata + xml2vmxdata \ + .valgrind.supp check_PROGRAMS = virshtest conftest sockettest \ nodeinfotest qparamtest virbuftest \ -- 1.7.4
On 06/30/2011 09:31 AM, Osier Yang wrote:
--- tests/Makefile.am | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am index 7db9d1f..e6c5a5e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -74,7 +74,8 @@ EXTRA_DIST = \ xencapsdata \ xmconfigdata \ xml2sexprdata \ - xml2vmxdata + xml2vmxdata \ + .valgrind.supp
ACK, with one nit - use TAB not spaces to match the indentation of the previous lines (Makefiles are the exception to the space-only rule). -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
于 2011年06月30日 23:07, Eric Blake 写道:
On 06/30/2011 09:31 AM, Osier Yang wrote:
--- tests/Makefile.am | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am index 7db9d1f..e6c5a5e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -74,7 +74,8 @@ EXTRA_DIST = \ xencapsdata \ xmconfigdata \ xml2sexprdata \ - xml2vmxdata + xml2vmxdata \ + .valgrind.supp
ACK, with one nit - use TAB not spaces to match the indentation of the previous lines (Makefiles are the exception to the space-only rule).
Applied with that fix. Thanks Osier
participants (11)
-
Daniel P. Berrange -
Daniel Veillard -
Eric Blake -
Gerhard Stenzel -
Laine Stump -
Matthias Bolte -
Osier Yang -
simon -
simon jin
-
Wen Congyang -
Zdenek Styblik