[libvirt] [PATCH] virsh: Improve virsh manual for virsh memtune command
Commit 0a22f54 added --min-guarantee option for the memtune command. This option is supported only by the ESX hypervisor. This patch adds a statement about this fact, to prevent user confusion. This patch also adds explanation how to clear/set to unlimited the memory tunables. (documments the -1 value). --- tools/virsh.pod | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 88dee26..7f46ee4 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -959,6 +959,7 @@ Allows you to display or set the domain memory parameters. Without flags, the current settings are displayed; with a flag, the appropriate limit is adjusted if supported by the hypervisor. LXC and QEMU/KVM support I<--hard-limit>, I<--soft-limit>, and I<--swap-hard-limit>. +I<--min-guarantee> is supported only by ESX hypervisor yet. If I<--live> is specified, affect a running guest. If I<--config> is specified, affect the next boot of a persistent guest. @@ -997,6 +998,8 @@ value are kilobytes (i.e. blocks of 1024 bytes). =back +Specifying -1 as a value for these limits is interpreted as unlimited. + =item B<blkiotune> I<domain-id> [I<--weight> B<weight>] [[I<--config>] [I<--live>] | [I<--current>]] -- 1.7.3.4
On 09/22/2011 04:14 AM, Peter Krempa wrote:
Commit 0a22f54 added --min-guarantee option for the memtune command. This option is supported only by the ESX hypervisor. This patch adds a statement about this fact, to prevent user confusion.
This patch also adds explanation how to clear/set to unlimited the memory tunables. (documments the -1 value). --- tools/virsh.pod | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index 88dee26..7f46ee4 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -959,6 +959,7 @@ Allows you to display or set the domain memory parameters. Without flags, the current settings are displayed; with a flag, the appropriate limit is adjusted if supported by the hypervisor. LXC and QEMU/KVM support I<--hard-limit>, I<--soft-limit>, and I<--swap-hard-limit>. +I<--min-guarantee> is supported only by ESX hypervisor yet.
s/ yet//. (The sentence makes better sense without that word, and we can edit the docs if we later add --min-guarantee support for qemu). ACK with that nit fixed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 09/22/2011 11:01 AM, Eric Blake wrote:
On 09/22/2011 04:14 AM, Peter Krempa wrote:
Commit 0a22f54 added --min-guarantee option for the memtune command. This option is supported only by the ESX hypervisor. This patch adds a statement about this fact, to prevent user confusion.
This patch also adds explanation how to clear/set to unlimited the memory tunables. (documments the -1 value). --- tools/virsh.pod | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index 88dee26..7f46ee4 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -959,6 +959,7 @@ Allows you to display or set the domain memory parameters. Without flags, the current settings are displayed; with a flag, the appropriate limit is adjusted if supported by the hypervisor. LXC and QEMU/KVM support I<--hard-limit>, I<--soft-limit>, and I<--swap-hard-limit>. +I<--min-guarantee> is supported only by ESX hypervisor yet.
s/ yet//. (The sentence makes better sense without that word, and we can edit the docs if we later add --min-guarantee support for qemu).
ACK with that nit fixed.
and pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
Peter Krempa