Re: [Libvir] [PATCH] * src/virsh.c (vshCommandOptInt): Correct indentation

Well, mailman-2.1.5 mangled yet another of my messages. [ I know why, and have reported the bug. Maybe we'll get a fixed/newer version of mailman. ] But at least the patch got through. Here's the part that it removed: Here's a tiny patch to fix indentation, since I'm about to change the code in that area, I'm submitting this first, so we don't mix syntax-only changes with ones that change semantics. The last two times I tried to send an attachment, mailman removed them. I'll try one more time, with this one: Jim Meyering <meyering@redhat.com> wrote:
Signed-off-by: Jim Meyering <meyering@redhat.com> --- ChangeLog | 4 ++++ src/virsh.c | 10 +++++----- 2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/ChangeLog b/ChangeLog index ce68401..a6de485 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2007-11-08 Jim Meyering <meyering@redhat.com> + + * src/virsh.c (vshCommandOptInt): Correct indentation + Wed Nov 7 14:38:43 CET 2007 Daniel Veillard <veillard@redhat.com>
* docs/libvir.html docs/site.xsl: small updates with references diff --git a/src/virsh.c b/src/virsh.c index 0615a7d..852dea2 100644 --- a/src/virsh.c +++ b/src/virsh.c @@ -1,7 +1,7 @@ /* * virsh.c: a Xen shell used to exercise the libvirt API * - * Copyright (C) 2005 Red Hat, Inc. + * Copyright (C) 2005, 2007 Red Hat, Inc. * * See COPYING.LIB for the License of this software * @@ -3956,10 +3956,10 @@ vshCommandOptInt(vshCmd * cmd, const char *name, int *found)
if ((arg != NULL) && (arg->data != NULL)) { res = strtol(arg->data, &end_p, 10); - if ((arg->data == end_p) || (*end_p!= 0)) - num_found = FALSE; - else - num_found = TRUE; + if ((arg->data == end_p) || (*end_p!= 0)) + num_found = FALSE; + else + num_found = TRUE; } if (found) *found = num_found;

On Thu, Nov 08, 2007 at 04:57:36PM +0100, Jim Meyering wrote:
Well, mailman-2.1.5 mangled yet another of my messages. [ I know why, and have reported the bug. Maybe we'll get a fixed/newer version of mailman. ]
But at least the patch got through. Here's the part that it removed:
Here's a tiny patch to fix indentation, since I'm about to change the code in that area, I'm submitting this first, so we don't mix syntax-only changes with ones that change semantics.
The last two times I tried to send an attachment, mailman removed them. I'll try one more time, with this one:
Okay, I managed to extract the patch and apply it, it's commited For your attachement, get your mailer to base64 them, or compress them or something so that mailman won't look at them, maybe that will fix the problem. thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Daniel Veillard
-
Jim Meyering