6:45 a.m.
When printing test results, nwfilter2vmtest.sh, truncates
the output at 66 or 70 characters. This is very unhelpful
when debugging problems where you want to see the full
output
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
---
scripts/nwfilter/nwfilter2vmtest.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/nwfilter/nwfilter2vmtest.sh b/scripts/nwfilter/nwfilter2vmtest.sh
index f44f299..a68c771 100644
--- a/scripts/nwfilter/nwfilter2vmtest.sh
+++ b/scripts/nwfilter/nwfilter2vmtest.sh
@@ -68,7 +68,7 @@ EOF
tap_fail() {
- txt=$(echo "$2" | gawk '{print substr($0,1,66)}')
+ txt=$(echo "$2")
echo "not ok $1 - ${txt}"
TAP_FAIL_LIST="$TAP_FAIL_LIST $1 "
TAP_FAIL_CTR=$(($TAP_FAIL_CTR + 1))
@@ -76,7 +76,7 @@ tap_fail() {
}
tap_pass() {
- txt=$(echo "$2" | gawk '{print substr($0,1,70)}')
+ txt=$(echo "$2")
echo "ok $1 - ${txt}"
TAP_TOT_CTR=$(($TAP_TOT_CTR + 1))
}
--
1.8.5.3
7:07 a.m.
On 03/27/2014 05:45 AM, Daniel P. Berrange wrote:
When printing test results, nwfilter2vmtest.sh, truncates
the output at 66 or 70 characters. This is very unhelpful
when debugging problems where you want to see the full
output
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
---
scripts/nwfilter/nwfilter2vmtest.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
ACK
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
11:45 a.m.
On Thursday, March 27, 2014 11:45:06 AM Daniel P. Berrange wrote:
When printing test results, nwfilter2vmtest.sh, truncates
the output at 66 or 70 characters. This is very unhelpful
when debugging problems where you want to see the full
output
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
---
scripts/nwfilter/nwfilter2vmtest.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
I realize I'm new here, but it's easy to ACK this one. ;)
-Mike
12:10 p.m.
On 03/27/2014 10:45 AM, Mike Latimer wrote:
On Thursday, March 27, 2014 11:45:06 AM Daniel P. Berrange wrote:
> When printing test results, nwfilter2vmtest.sh, truncates
> the output at 66 or 70 characters. This is very unhelpful
> when debugging problems where you want to see the full
> output
>
> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
> ---
> scripts/nwfilter/nwfilter2vmtest.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I realize I'm new here, but it's easy to ACK this one. ;)
New or not, your reviews are helpful! We all had to start somewhere.
And right now, the fact that you are attempting to run tck gives you
better status as a reviewer, even if only to say "I applied this, and it
{still passed for me/fixed a bug I was hitting}"
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
12:27 p.m.
On Thursday, March 27, 2014 11:10:15 AM Eric Blake wrote:
New or not, your reviews are helpful! We all had to start
somewhere.
And right now, the fact that you are attempting to run tck gives you
better status as a reviewer, even if only to say "I applied this, and it
{still passed for me/fixed a bug I was hitting}"
Thank you! That's exactly the response I was hoping for. I'll continue my
testing then and should be able to at least provide an ACK/response on the
areas I'm familiar with. (So far, Daniel's recent patches all look good.)
-Mike
3871
days inactive
3871
days old
4 comments
3 participants
participants (3)
-
Daniel P. Berrange -
Eric Blake -
Mike Latimer