[libvirt] [jenkins-ci PATCH] guests: Add icoutils dependency to virt-viewer project
The icotool command is used to manipulate Windows icon files. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/vars/mappings.yml | 4 ++++ guests/vars/projects/virt-viewer.yml | 1 + 2 files changed, 5 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index e074648..6af5065 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -173,6 +173,10 @@ mappings: hal: FreeBSD: hal + icoutils: + default: icoutils + CentOS6: + intltool: default: intltool diff --git a/guests/vars/projects/virt-viewer.yml b/guests/vars/projects/virt-viewer.yml index 6f3dbf9..54c96fe 100644 --- a/guests/vars/projects/virt-viewer.yml +++ b/guests/vars/projects/virt-viewer.yml @@ -3,6 +3,7 @@ packages: - glib2 - gtk-vnc - gtk3 + - icoutils - intltool - libgovirt - libxml2 -- 2.14.3
On Fri, Apr 13, 2018 at 02:10:08PM +0200, Andrea Bolognani wrote:
The icotool command is used to manipulate Windows icon files.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/vars/mappings.yml | 4 ++++ guests/vars/projects/virt-viewer.yml | 1 + 2 files changed, 5 insertions(+)
Isn't this required only for mingw build? If so, we might want to introduce virt-viewer+mingw project. Pavel
On Mon, 2018-04-16 at 10:31 +0200, Pavel Hrdina wrote:
On Fri, Apr 13, 2018 at 02:10:08PM +0200, Andrea Bolognani wrote:
The icotool command is used to manipulate Windows icon files.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/vars/mappings.yml | 4 ++++ guests/vars/projects/virt-viewer.yml | 1 + 2 files changed, 5 insertions(+)
Isn't this required only for mingw build?
Yeah, you're right.
If so, we might want to introduce virt-viewer+mingw project.
That was the plan all along :) I'll wait for Dan to push his patches and then post a series that splits off the +mingw part and also adds the icotool dependency. -- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani -
Pavel Hrdina