[Libvir] [PATCH] 0/2 Factor out query parsing from remote
We need to do query string assembly and parsing for the Amazon EC2 backend. These two patches factor out this code from inside remote_internal.c into a separate utility file. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
-- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
Looks good to me, although you seem to have left out the part of the patch with the unit tests in ;-P Seriously though, now it is untangled from the remote driver code this ought to be a nice module to test. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
Daniel P. Berrange wrote:
Looks good to me, although you seem to have left out the part of the patch with the unit tests in ;-P
Did I? ooops ... Unit testing coming up later then.
On Fri, Dec 14, 2007 at 04:19:52PM +0000, Richard Jones wrote:
Daniel P. Berrange wrote:
Looks good to me, although you seem to have left out the part of the patch with the unit tests in ;-P
Did I? ooops ... Unit testing coming up later then.
BTW, I've no issue with the refactoring code being committed to CVS in the meanwhile... Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
This pulls the query parsing code from remote_internal.c and makes it use the functions in qparams.c instead. Also I've changed DEBUG to use the global ENABLE_DEBUG symbol, and replaced calls to strcasecmp with STRCASEEQ macro. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
On Thu, Dec 13, 2007 at 06:24:07PM +0000, Richard W.M. Jones wrote:
This pulls the query parsing code from remote_internal.c and makes it use the functions in qparams.c instead.
Also I've changed DEBUG to use the global ENABLE_DEBUG symbol, and replaced calls to strcasecmp with STRCASEEQ macro.
Looks good - any code which modularizing / simplifies the remote driver is good - we've got rather a large amount of code in that one file. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
participants (3)
-
Daniel P. Berrange -
Richard Jones -
Richard W.M. Jones