[Libvir] [PATCH] Fix libvirtd --config / -f option

As well as fixing the --config/-f option for libvirtd, this also changes an abort() into a meaningful error message. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

On Tue, Aug 07, 2007 at 01:05:43PM +0100, Richard W.M. Jones wrote:
As well as fixing the --config/-f option for libvirtd, this also changes an abort() into a meaningful error message.
Not sure I fully understand, are we changing the options or merely changing the documentation ? Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

Daniel Veillard wrote:
On Tue, Aug 07, 2007 at 01:05:43PM +0100, Richard W.M. Jones wrote:
As well as fixing the --config/-f option for libvirtd, this also changes an abort() into a meaningful error message.
Not sure I fully understand, are we changing the options or merely changing the documentation ?
We're fixing the option. It doesn't work at the moment :-) Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

On Tue, Aug 07, 2007 at 01:49:38PM +0100, Richard W.M. Jones wrote:
Daniel Veillard wrote:
On Tue, Aug 07, 2007 at 01:05:43PM +0100, Richard W.M. Jones wrote:
As well as fixing the --config/-f option for libvirtd, this also changes an abort() into a meaningful error message.
Not sure I fully understand, are we changing the options or merely changing the documentation ?
We're fixing the option. It doesn't work at the moment :-)
hum, okay :-) I just want to make sure we don't remove an option people may be using already, but if it doesn't work ... fine Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

On Tue, Aug 07, 2007 at 01:05:43PM +0100, Richard W.M. Jones wrote:
As well as fixing the --config/-f option for libvirtd, this also changes an abort() into a meaningful error message.
ACK, looks fine. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
participants (3)
-
Daniel P. Berrange
-
Daniel Veillard
-
Richard W.M. Jones