11:51 a.m.
From: intrigeri <intrigeri+libvirt(a)boum.org>
Fixes: https://bugs.debian.org/914940
---
src/security/apparmor/libvirt-qemu | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/security/apparmor/libvirt-qemu b/src/security/apparmor/libvirt-qemu
index 474aaefdf8..165558fe83 100644
--- a/src/security/apparmor/libvirt-qemu
+++ b/src/security/apparmor/libvirt-qemu
@@ -103,6 +103,7 @@
/usr/bin/qemu-system-alpha rmix,
/usr/bin/qemu-system-arm rmix,
/usr/bin/qemu-system-cris rmix,
+ /usr/bin/qemu-system-hppa rmix,
/usr/bin/qemu-system-i386 rmix,
/usr/bin/qemu-system-lm32 rmix,
/usr/bin/qemu-system-m68k rmix,
@@ -113,10 +114,14 @@
/usr/bin/qemu-system-mips64el rmix,
/usr/bin/qemu-system-mipsel rmix,
/usr/bin/qemu-system-moxie rmix,
+ /usr/bin/qemu-system-nios2 rmix,
+ /usr/bin/qemu-system-or1k rmix,
/usr/bin/qemu-system-or32 rmix,
/usr/bin/qemu-system-ppc rmix,
/usr/bin/qemu-system-ppc64 rmix,
/usr/bin/qemu-system-ppcemb rmix,
+ /usr/bin/qemu-system-riscv32 rmix,
+ /usr/bin/qemu-system-riscv64 rmix,
/usr/bin/qemu-system-s390x rmix,
/usr/bin/qemu-system-sh4 rmix,
/usr/bin/qemu-system-sh4eb rmix,
--
2.20.1
2:14 a.m.
On Sat, 2019-03-30 at 16:51 +0000, intrigeri+libvirt(a)boum.org wrote:
From: intrigeri <intrigeri+libvirt(a)boum.org>
Fixes: https://bugs.debian.org/914940
---
src/security/apparmor/libvirt-qemu | 5 +++++
1 file changed, 5 insertions(+)
This is missing the Signed-off-by tag, and there's a server-side
hook that will prevent you from pushing if it's absent.
I would also tweak the commit message along the lines of
apparmor: Support more QEMU architectures
Add hppa, nios2, or1k, riscv32 and riscv64 to the profile.
With at least the S-o-b added,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization
2:41 a.m.
New subject: [libvirt] [PATCH v2] apparmor: support more QEMU architectures
v2 following up to Andrea Bolognani's review (thanks!)
- Adds missing Signed-off-by tag
- Improves commit message
- Adds Reviewed-by Andrea Bolognani
2:41 a.m.
New subject: [libvirt] [PATCH] apparmor: support more QEMU architectures
From: intrigeri <intrigeri+libvirt(a)boum.org>
Add hppa, nios2, or1k, riscv32 and riscv64 to the profile.
Fixes: https://bugs.debian.org/914940
Signed-off-by: intrigeri <intrigeri(a)boum.org>
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
---
src/security/apparmor/libvirt-qemu | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/security/apparmor/libvirt-qemu b/src/security/apparmor/libvirt-qemu
index 474aaefdf8..165558fe83 100644
--- a/src/security/apparmor/libvirt-qemu
+++ b/src/security/apparmor/libvirt-qemu
@@ -103,6 +103,7 @@
/usr/bin/qemu-system-alpha rmix,
/usr/bin/qemu-system-arm rmix,
/usr/bin/qemu-system-cris rmix,
+ /usr/bin/qemu-system-hppa rmix,
/usr/bin/qemu-system-i386 rmix,
/usr/bin/qemu-system-lm32 rmix,
/usr/bin/qemu-system-m68k rmix,
@@ -113,10 +114,14 @@
/usr/bin/qemu-system-mips64el rmix,
/usr/bin/qemu-system-mipsel rmix,
/usr/bin/qemu-system-moxie rmix,
+ /usr/bin/qemu-system-nios2 rmix,
+ /usr/bin/qemu-system-or1k rmix,
/usr/bin/qemu-system-or32 rmix,
/usr/bin/qemu-system-ppc rmix,
/usr/bin/qemu-system-ppc64 rmix,
/usr/bin/qemu-system-ppcemb rmix,
+ /usr/bin/qemu-system-riscv32 rmix,
+ /usr/bin/qemu-system-riscv64 rmix,
/usr/bin/qemu-system-s390x rmix,
/usr/bin/qemu-system-sh4 rmix,
/usr/bin/qemu-system-sh4eb rmix,
--
2.20.1
3:31 a.m.
New subject: [libvirt] [PATCH] apparmor: support more QEMU architectures
On Mon, 2019-04-01 at 07:41 +0000, intrigeri+libvirt(a)boum.org wrote:
From: intrigeri <intrigeri+libvirt(a)boum.org>
Add hppa, nios2, or1k, riscv32 and riscv64 to the profile.
Fixes: https://bugs.debian.org/914940
Signed-off-by: intrigeri <intrigeri(a)boum.org>
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
The fact that git authorship and S-o-b don't match is kinda weird,
so it would be cool if you picked either email address and used it
for both. Sorry if I failed to mention this the first time around.
Anyway, my R-b stands and the patch is safe for freeze.
--
Andrea Bolognani / Red Hat / Virtualization
4:45 a.m.
New subject: [libvirt] [PATCH] apparmor: support more QEMU architectures
On Mon, 2019-04-01 at 10:31 +0200, Andrea Bolognani wrote:
On Mon, 2019-04-01 at 07:41 +0000, intrigeri+libvirt(a)boum.org wrote:
> From: intrigeri <intrigeri+libvirt(a)boum.org>
>
> Add hppa, nios2, or1k, riscv32 and riscv64 to the profile.
>
> Fixes: https://bugs.debian.org/914940
> Signed-off-by: intrigeri <intrigeri(a)boum.org>
> Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
The fact that git authorship and S-o-b don't match is kinda weird,
so it would be cool if you picked either email address and used it
for both. Sorry if I failed to mention this the first time around.
Anyway, my R-b stands and the patch is safe for freeze.
Wait, I assumed you had commit privileges but that doesn't seem to
be the case... Are you okay with changing the authorship email
address so that it matches the S-o-b and pushing the patch?
--
Andrea Bolognani / Red Hat / Virtualization
5:40 a.m.
New subject: [libvirt] [PATCH] apparmor: support more QEMU architectures
On Mon, 2019-04-01 at 12:27 +0200, intrigeri wrote:
Andrea Bolognani:
> Are you okay with changing the authorship email
> address so that it matches the S-o-b and pushing the patch?
If you don't mind doing it yourself, sure, go ahead :)
Done.
I've actually left the authorship information intact because as it
turns out you already have 6 commits with that email address, the
most recent of which (1fff379ff6) also has a S-o-b matching the one
from the current patch...
Going forward, I would still recommend making sure the two email
addresses match.
--
Andrea Bolognani / Red Hat / Virtualization
2091
days inactive
2093
days old
7 comments
3 participants
participants (3)
-
Andrea Bolognani -
intrigeri -
intrigeri+libvirt＠boum.org