Laine mentioned that there were two syntax-check failures. I've just pushed this fix: From: Jim Meyering <meyering(a)redhat.com&gt; Date: Tue, 16 Mar 2010 19:32:05 +0100 Subject: [PATCH] fix two "make syntax check" failures * src/xenapi/xenapi_driver.c (xenapiOpen): Remove useless-if-before-free. * po/POTFILES.in: Add src/xenapi/xenapi_utils.c. --- po/POTFILES.in | 1 + src/xenapi/xenapi_driver.c | 2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/po/POTFILES.in b/po/POTFILES.in index ac169be..1845572 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -78,5 +78,6 @@ src/xen/xen_hypervisor.c src/xen/xen_inotify.c src/xen/xm_internal.c src/xen/xs_internal.c +src/xenapi/xenapi_utils.c tools/console.c tools/virsh.c diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index 153582d..ad77068 100644 --- a/src/xenapi/xenapi_driver.c +++ b/src/xenapi/xenapi_driver.c @@ -102,7 +102,7 @@ xenapiOpen (virConnectPtr conn, virConnectAuthPtr auth, int flags ATTRIBUTE_UNUS } if (!passwd || !conn->uri->user) { xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, "Username/Password not valid"); - if (passwd) VIR_FREE(passwd); + VIR_FREE(passwd); return VIR_DRV_OPEN_ERROR; } if (VIR_ALLOC(privP) < 0) { -- 1.7.0.2.445.g0ae494