[libvirt] [libvirt-java] [PATCH] Set Java source level in pom
Hi Simple patch to set the Java source level within the pom, this makes it easier to import the project into Eclipse. I've also added an ignore for a local pom file. I've added plugins to publish the sources and javadocs into Maven. This allows Maven (and IDE integration) to automatically use the javadocs and source. This should make life easier for users of libvirt-java. Regards, Chris Chris Ellis (1): Update pom to include Java source level .gitignore | 1 + pom.xml.in | 41 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+) -- 1.8.4.5
Update the pom to set the Java source level. This enables Eclipse to correctly configure itself. Also include plugins to publish the source and javadocs vai Maven. Update .gitignore to exclude a local pom. --- .gitignore | 1 + pom.xml.in | 41 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/.gitignore b/.gitignore index 28ddc6e..cbc1cf6 100644 --- a/.gitignore +++ b/.gitignore @@ -5,4 +5,5 @@ .settings target README +pom.xml diff --git a/pom.xml.in b/pom.xml.in index 4f49a3a..fd743ad 100644 --- a/pom.xml.in +++ b/pom.xml.in @@ -30,6 +30,47 @@ <version>[3.4.1,4.0.0]</version> </dependency> </dependencies> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-compiler-plugin</artifactId> + <configuration> + <source>1.6</source> + <target>1.5</target> + </configuration> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-source-plugin</artifactId> + <executions> + <execution> + <id>package-source</id> + <phase>package</phase> + <goals> + <goal>jar</goal> + </goals> + <configuration> + </configuration> + </execution> + </executions> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-javadoc-plugin</artifactId> + <executions> + <execution> + <id>package-javadocs</id> + <phase>package</phase> + <goals> + <goal>jar</goal> + </goals> + </execution> + </executions> + </plugin> + </plugins> + </build> </project> -- 1.8.4.5
At Wed, 26 Mar 2014 03:29:34 +0000, Chris Ellis wrote:
Update the pom to set the Java source level. This enables Eclipse to correctly configure itself.
So, you let ant generate the pom.xml and use that with Eclipse, right?
Also include plugins to publish the source and javadocs vai Maven.
s/vai/via
Update .gitignore to exclude a local pom. --- .gitignore | 1 + pom.xml.in | 41 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)
diff --git a/pom.xml.in b/pom.xml.in index 4f49a3a..fd743ad 100644 --- a/pom.xml.in +++ b/pom.xml.in @@ -30,6 +30,47 @@ <version>[3.4.1,4.0.0]</version> </dependency> </dependencies> + ^^^^^ trailing whitespaces (git warns about this)
ACK, but I did not yet push it since your patch is not against libvirt-java master.
On Wed, Mar 26, 2014 at 7:52 AM, Claudio Bley <cbley@av-test.de> wrote:
At Wed, 26 Mar 2014 03:29:34 +0000, Chris Ellis wrote:
Update the pom to set the Java source level. This enables Eclipse to correctly configure itself.
So, you let ant generate the pom.xml and use that with Eclipse, right?
Yes, once there is a valid pom you can just import the project into Eclipse via the Eclipse / Maven integration. Is there any reason we are building via Ant, rather than using Maven for the build?
Also include plugins to publish the source and javadocs vai Maven.
s/vai/via
Update .gitignore to exclude a local pom. --- .gitignore | 1 + pom.xml.in | 41 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)
diff --git a/pom.xml.in b/pom.xml.in index 4f49a3a..fd743ad 100644 --- a/pom.xml.in +++ b/pom.xml.in @@ -30,6 +30,47 @@ <version>[3.4.1,4.0.0]</version> </dependency> </dependencies> + ^^^^^ trailing whitespaces (git warns about this)
ACK, but I did not yet push it since your patch is not against libvirt-java master.
On 03/25/2014 09:29 PM, Chris Ellis wrote:
Hi
Simple patch to set the Java source level within the pom, this makes it easier to import the project into Eclipse. I've also added an ignore for a local pom file.
I've added plugins to publish the sources and javadocs into Maven. This allows Maven (and IDE integration) to automatically use the javadocs and source. This should make life easier for users of libvirt-java.
Regards, Chris
Chris Ellis (1): Update pom to include Java source level
.gitignore | 1 + pom.xml.in | 41 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)
There was no patch accompanying this diffstat. See what the archives saw: https://www.redhat.com/archives/libvir-list/2014-March/msg01591.html You might want to try sending again :) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 03/25/2014 10:19 PM, Eric Blake wrote:
On 03/25/2014 09:29 PM, Chris Ellis wrote:
Hi
Simple patch to set the Java source level within the pom, this makes it easier to import the project into Eclipse. I've also added an ignore for a local pom file.
I've added plugins to publish the sources and javadocs into Maven. This allows Maven (and IDE integration) to automatically use the javadocs and source. This should make life easier for users of libvirt-java.
Regards, Chris
Chris Ellis (1): Update pom to include Java source level
.gitignore | 1 + pom.xml.in | 41 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)
There was no patch accompanying this diffstat. See what the archives saw: https://www.redhat.com/archives/libvir-list/2014-March/msg01591.html
You might want to try sending again :)
Ah, I see it now: https://www.redhat.com/archives/libvir-list/2014-March/msg01593.html Usually git numbers a cover letter as 0/N to make it obvious it is a cover; also, a cover letter isn't necessary when sending a single patch. At any rate, I'll leave the actual patch review up to someone more familiar with Maven. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Wed, Mar 26, 2014 at 4:32 AM, Eric Blake <eblake@redhat.com> wrote:
On 03/25/2014 10:19 PM, Eric Blake wrote:
On 03/25/2014 09:29 PM, Chris Ellis wrote:
Hi
Simple patch to set the Java source level within the pom, this makes it easier to import the project into Eclipse. I've also added an ignore for a local pom file.
I've added plugins to publish the sources and javadocs into Maven. This allows Maven (and IDE integration) to automatically use the javadocs and source. This should make life easier for users of libvirt-java.
Regards, Chris
Chris Ellis (1): Update pom to include Java source level
.gitignore | 1 + pom.xml.in | 41 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)
There was no patch accompanying this diffstat. See what the archives saw: https://www.redhat.com/archives/libvir-list/2014-March/msg01591.html
You might want to try sending again :)
Ah, I see it now: https://www.redhat.com/archives/libvir-list/2014-March/msg01593.html
Usually git numbers a cover letter as 0/N to make it obvious it is a cover; also, a cover letter isn't necessary when sending a single patch. At any rate, I'll leave the actual patch review up to someone more familiar with Maven.
Sorry for the confusion, once I saw the emails arrive I realized it looked stupid, I shouldn't have used --cover-letter for the single patch. Chris
participants (3)
-
Chris Ellis -
Claudio Bley -
Eric Blake