[libvirt] [PATCH] qemu: Fix memory leak in qemuConnectGetAllDomainStats error path

If we return -1 on VIR_ALLOC_N failure, we leaked @vms, so goto cleanup instead. Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9e715e7a0..e13544f83 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20348,7 +20348,7 @@ qemuConnectGetAllDomainStats(virConnectPtr conn, } if (VIR_ALLOC_N(tmpstats, nvms + 1) < 0) - return -1; + goto cleanup; if (qemuDomainGetStatsNeedMonitor(stats)) privflags |= QEMU_DOMAIN_STATS_HAVE_JOB; -- 2.13.6

On Wed, Mar 07, 2018 at 09:46:53 -0500, John Ferlan wrote:
If we return -1 on VIR_ALLOC_N failure, we leaked @vms, so goto cleanup instead.
Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK
participants (2)
-
John Ferlan
-
Peter Krempa