[libvirt] [PATCH] schema: support 'default' cache mode
The docs claims the cache attribute of the disk <driver> element supports 'default' as one of its permissible values, but such configuration fails virt-xml-validate. Add 'default' as one of the cache attribute choices in domaincommon.rng. Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- docs/schemas/domaincommon.rng | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 67af93a..d4e375f 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -1596,6 +1596,7 @@ <define name="driverCache"> <attribute name="cache"> <choice> + <value>default</value> <value>none</value> <value>writeback</value> <value>writethrough</value> -- 2.1.4
Hi All, Any comments about this small patch? Regards, Jim On 02/29/2016 04:26 PM, Jim Fehlig wrote:
The docs claims the cache attribute of the disk <driver> element supports 'default' as one of its permissible values, but such configuration fails virt-xml-validate. Add 'default' as one of the cache attribute choices in domaincommon.rng.
Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- docs/schemas/domaincommon.rng | 1 + 1 file changed, 1 insertion(+)
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 67af93a..d4e375f 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -1596,6 +1596,7 @@ <define name="driverCache"> <attribute name="cache"> <choice> + <value>default</value> <value>none</value> <value>writeback</value> <value>writethrough</value>
On Mon, Feb 29, 2016 at 04:26:25PM -0700, Jim Fehlig wrote:
The docs claims the cache attribute of the disk <driver> element supports 'default' as one of its permissible values, but such configuration fails virt-xml-validate. Add 'default' as one of the cache attribute choices in domaincommon.rng.
Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- docs/schemas/domaincommon.rng | 1 + 1 file changed, 1 insertion(+)
ACK Does this need a test case in any of the directories 'domainschematest' uses? Jan
On 03/14/2016 06:40 AM, Ján Tomko wrote:
On Mon, Feb 29, 2016 at 04:26:25PM -0700, Jim Fehlig wrote:
The docs claims the cache attribute of the disk <driver> element supports 'default' as one of its permissible values, but such configuration fails virt-xml-validate. Add 'default' as one of the cache attribute choices in domaincommon.rng.
Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- docs/schemas/domaincommon.rng | 1 + 1 file changed, 1 insertion(+)
ACK
Thanks. I'll push this patch in a bit.
Does this need a test case in any of the directories 'domainschematest' uses?
I just noticed xlconfigdata is not included in the domainschematest directories. I'll send a follow-up to fix that, but none of the configs have cache='default' since it would simply be omitted in the corresponding xl config. Should I add a simple XML config containing cache='default' directly to doaminschemadata? Regards, Jim
participants (2)
-
Jim Fehlig -
Ján Tomko