5:50 a.m.
Since we haven't quite frozen yet, it's time to pick up some
fixes. I know at least cygwin benefits from this update.
* .gnulib: Update to latest, in part for cygwin compilation.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
---
Pushing under the gnulib rule.
* .gnulib 4a5ee89...8f74258 (33):
Revert "error: make the module depend on vfprintf-posix"
maint.mk: fix "release" target to build _version
maint.mk: get current gnulib revision correctly.
install-reloc: Support multi-binary installation.
selinux-h: really build without selinux when library is missing
regex: also remove dependency on HAVE_WCSCOLL
xfreopen: fix typo: s/frepoen/freopen/
regex: don't depend on wcscoll
error: add the printf attribute to a static function
error: make the module depend on vfprintf-posix
fpending, obstack, strerror-override: use pure+const function attrs
extern-inline: make safe for -Wundef usage
mkfifo-tests, etc.: allow HP-UX 11.11 bug
acl: allow cross-compilation to Gentoo
mgetgroups: remove dependency on realloc-gnu
regex-tests: port to HP-UX 11.11
verify: document some 'assume' pitfalls
strtoumax: fix another typo in previous commit
strtoumax: fix typo in previous commit.
strtoumax: port to Solaris 8
autoupdate
strtoimax, strtoumax: port to HP-UX 11.11
strtoimax: port to HP-UX 11.11
New module 'count-trailing-zeros'.
count-leading-zeros: port to MSC; support types wider than 64 bits
count-one-bits: port to MSC; support types wider than 64 bits
mountlist: fix resource leak with MOUNTED_INTERIX_STATVFS
tests: improve diagnostic when an assertion fails
verify: new macro 'assume'
autoupdate
dup2, dup3: work around another cygwin crasher
getdtablesize: work around cygwin issue
pmccabe2html: escaping of special characters
.gnulib | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gnulib b/.gnulib
index 4a5ee89..8f74258 160000
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 4a5ee89c8a8be7350a8fd8ca1bacb196a190e492
+Subproject commit 8f7425866463f994538584d1dd7211603b8b0550
--
1.8.3.1
1:15 a.m.
On Mon, Oct 28, 2013 at 03:50:20PM -0600, Eric Blake wrote:
Since we haven't quite frozen yet, it's time to pick up some
fixes. I know at least cygwin benefits from this update.
* .gnulib: Update to latest, in part for cygwin compilation.
Even though that's not your fault, this might interest you:
root@freebsd9:/home/jenkins/workspace/libvirt/platform/freebsd-9/gnulib/tests
# ./test-poll
Unconnected socket test... passed
Connected sockets test... failed (expecting POLLHUP after shutdown)
General socket test with fork... failed (expecting POLLHUP after shutdown)
Pipe test... passed
And two other tests fail as well. I, however, couldn't find a time to
look at that, so I'm just sending this to you in case you'd like to go
deeper with it.
Martin
4:12 a.m.
[adding bug-gnulib]
On 10/29/2013 11:15 AM, Martin Kletzander wrote:
On Mon, Oct 28, 2013 at 03:50:20PM -0600, Eric Blake wrote:
> Since we haven't quite frozen yet, it's time to pick up some
> fixes. I know at least cygwin benefits from this update.
>
> * .gnulib: Update to latest, in part for cygwin compilation.
>
Even though that's not your fault, this might interest you:
root@freebsd9:/home/jenkins/workspace/libvirt/platform/freebsd-9/gnulib/tests
# ./test-poll
Unconnected socket test... passed
Connected sockets test... failed (expecting POLLHUP after shutdown)
General socket test with fork... failed (expecting POLLHUP after shutdown)
Pipe test... passed
Has that test been failing prior to my submodule update for libvirt?
This is likely a latent bug in gnulib that has been manifesting itself
on FreeBSD for a much longer time period than just the month's worth of
patches I pulled in by updating; but you are right that it would be nice
to fix it upstream.
And two other tests fail as well. I, however, couldn't find a time to
look at that, so I'm just sending this to you in case you'd like to go
deeper with it.
Martin
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
9:26 p.m.
On Tue, Oct 29, 2013 at 02:12:00PM -0600, Eric Blake wrote:
[adding bug-gnulib]
On 10/29/2013 11:15 AM, Martin Kletzander wrote:
> On Mon, Oct 28, 2013 at 03:50:20PM -0600, Eric Blake wrote:
>> Since we haven't quite frozen yet, it's time to pick up some
>> fixes. I know at least cygwin benefits from this update.
>>
>> * .gnulib: Update to latest, in part for cygwin compilation.
>>
>
> Even though that's not your fault, this might interest you:
>
> root@freebsd9:/home/jenkins/workspace/libvirt/platform/freebsd-9/gnulib/tests
> # ./test-poll
> Unconnected socket test... passed
> Connected sockets test... failed (expecting POLLHUP after shutdown)
> General socket test with fork... failed (expecting POLLHUP after shutdown)
> Pipe test... passed
Has that test been failing prior to my submodule update for libvirt?
This is likely a latent bug in gnulib that has been manifesting itself
on FreeBSD for a much longer time period than just the month's worth of
patches I pulled in by updating; but you are right that it would be nice
to fix it upstream.
I thought it did fail earlier, but now I see it didn't. There was an
IP addresses misconfiguration, but trying that now, I can only find a
commit on which there were 2 errors instead of 3, but none which would
successfully survive 'make check'.
So sorry for the noise I made about that.
Martin
>
> And two other tests fail as well. I, however, couldn't find a time to
> look at that, so I'm just sending this to you in case you'd like to go
> deeper with it.
>
> Martin
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
10:36 p.m.
On 10/31/2013 07:26 AM, Martin Kletzander wrote:
>>
root@freebsd9:/home/jenkins/workspace/libvirt/platform/freebsd-9/gnulib/tests
>> # ./test-poll
>> Unconnected socket test... passed
>> Connected sockets test... failed (expecting POLLHUP after shutdown)
>> General socket test with fork... failed (expecting POLLHUP after shutdown)
>> Pipe test... passed
>
> Has that test been failing prior to my submodule update for libvirt?
> This is likely a latent bug in gnulib that has been manifesting itself
> on FreeBSD for a much longer time period than just the month's worth of
> patches I pulled in by updating; but you are right that it would be nice
> to fix it upstream.
>
I thought it did fail earlier, but now I see it didn't. There was an
IP addresses misconfiguration, but trying that now, I can only find a
commit on which there were 2 errors instead of 3, but none which would
successfully survive 'make check'.
So sorry for the noise I made about that.
Don't apologize - it's something that upstream gnulib needs to fix
someday, even if the downstream libvirt patch wasn't actually pointing
out a gnulib regression. But I don't know how many active FreeBSD users
are on the gnulib list to help with the analysis effort, so it may be a
while before fixes appear (at any rate, a failed gnulib test is not
necessarily a reason to hold up a downstream release).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
4018
days inactive
4021
days old
4 comments
2 participants
participants (2)
-
Eric Blake -
Martin Kletzander