[libvirt] [PATCH] rm daemon/remote_dispatch_table.h

1. this file is automatically generated at compile-time, so rm it to avoid further commit to this file. 2. any update should made to file src/remote/remote_protocol.x. --- daemon/remote_dispatch_table.h | 1054 ---------------------------------------- 1 files changed, 0 insertions(+), 1054 deletions(-) delete mode 100644 daemon/remote_dispatch_table.h diff --git a/daemon/remote_dispatch_table.h b/daemon/remote_dispatch_table.h deleted file mode 100644 index b39f7c2..0000000 --- a/daemon/remote_dispatch_table.h +++ /dev/null @@ -1,1054 +0,0 @@ -/* Automatically generated by remote_generate_stubs.pl. - * Do not edit this file. Any changes you make will be lost. - */ - -{ /* (unused) => 0 */ - .fn = NULL, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* Open => 1 */ - .fn = (dispatch_fn) remoteDispatchOpen, - .args_filter = (xdrproc_t) xdr_remote_open_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* Close => 2 */ - .fn = (dispatch_fn) remoteDispatchClose, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* GetType => 3 */ - .fn = (dispatch_fn) remoteDispatchGetType, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_get_type_ret, -}, -{ /* GetVersion => 4 */ - .fn = (dispatch_fn) remoteDispatchGetVersion, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_get_version_ret, -}, -{ /* GetMaxVcpus => 5 */ - .fn = (dispatch_fn) remoteDispatchGetMaxVcpus, - .args_filter = (xdrproc_t) xdr_remote_get_max_vcpus_args, - .ret_filter = (xdrproc_t) xdr_remote_get_max_vcpus_ret, -}, -{ /* NodeGetInfo => 6 */ - .fn = (dispatch_fn) remoteDispatchNodeGetInfo, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_node_get_info_ret, -}, -{ /* GetCapabilities => 7 */ - .fn = (dispatch_fn) remoteDispatchGetCapabilities, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_get_capabilities_ret, -}, -{ /* DomainAttachDevice => 8 */ - .fn = (dispatch_fn) remoteDispatchDomainAttachDevice, - .args_filter = (xdrproc_t) xdr_remote_domain_attach_device_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainCreate => 9 */ - .fn = (dispatch_fn) remoteDispatchDomainCreate, - .args_filter = (xdrproc_t) xdr_remote_domain_create_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainCreateXml => 10 */ - .fn = (dispatch_fn) remoteDispatchDomainCreateXml, - .args_filter = (xdrproc_t) xdr_remote_domain_create_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_create_xml_ret, -}, -{ /* DomainDefineXml => 11 */ - .fn = (dispatch_fn) remoteDispatchDomainDefineXml, - .args_filter = (xdrproc_t) xdr_remote_domain_define_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_define_xml_ret, -}, -{ /* DomainDestroy => 12 */ - .fn = (dispatch_fn) remoteDispatchDomainDestroy, - .args_filter = (xdrproc_t) xdr_remote_domain_destroy_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainDetachDevice => 13 */ - .fn = (dispatch_fn) remoteDispatchDomainDetachDevice, - .args_filter = (xdrproc_t) xdr_remote_domain_detach_device_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainDumpXml => 14 */ - .fn = (dispatch_fn) remoteDispatchDomainDumpXml, - .args_filter = (xdrproc_t) xdr_remote_domain_dump_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_dump_xml_ret, -}, -{ /* DomainGetAutostart => 15 */ - .fn = (dispatch_fn) remoteDispatchDomainGetAutostart, - .args_filter = (xdrproc_t) xdr_remote_domain_get_autostart_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_autostart_ret, -}, -{ /* DomainGetInfo => 16 */ - .fn = (dispatch_fn) remoteDispatchDomainGetInfo, - .args_filter = (xdrproc_t) xdr_remote_domain_get_info_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_info_ret, -}, -{ /* DomainGetMaxMemory => 17 */ - .fn = (dispatch_fn) remoteDispatchDomainGetMaxMemory, - .args_filter = (xdrproc_t) xdr_remote_domain_get_max_memory_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_max_memory_ret, -}, -{ /* DomainGetMaxVcpus => 18 */ - .fn = (dispatch_fn) remoteDispatchDomainGetMaxVcpus, - .args_filter = (xdrproc_t) xdr_remote_domain_get_max_vcpus_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_max_vcpus_ret, -}, -{ /* DomainGetOsType => 19 */ - .fn = (dispatch_fn) remoteDispatchDomainGetOsType, - .args_filter = (xdrproc_t) xdr_remote_domain_get_os_type_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_os_type_ret, -}, -{ /* DomainGetVcpus => 20 */ - .fn = (dispatch_fn) remoteDispatchDomainGetVcpus, - .args_filter = (xdrproc_t) xdr_remote_domain_get_vcpus_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_vcpus_ret, -}, -{ /* ListDefinedDomains => 21 */ - .fn = (dispatch_fn) remoteDispatchListDefinedDomains, - .args_filter = (xdrproc_t) xdr_remote_list_defined_domains_args, - .ret_filter = (xdrproc_t) xdr_remote_list_defined_domains_ret, -}, -{ /* DomainLookupById => 22 */ - .fn = (dispatch_fn) remoteDispatchDomainLookupById, - .args_filter = (xdrproc_t) xdr_remote_domain_lookup_by_id_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_lookup_by_id_ret, -}, -{ /* DomainLookupByName => 23 */ - .fn = (dispatch_fn) remoteDispatchDomainLookupByName, - .args_filter = (xdrproc_t) xdr_remote_domain_lookup_by_name_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_lookup_by_name_ret, -}, -{ /* DomainLookupByUuid => 24 */ - .fn = (dispatch_fn) remoteDispatchDomainLookupByUuid, - .args_filter = (xdrproc_t) xdr_remote_domain_lookup_by_uuid_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_lookup_by_uuid_ret, -}, -{ /* NumOfDefinedDomains => 25 */ - .fn = (dispatch_fn) remoteDispatchNumOfDefinedDomains, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_num_of_defined_domains_ret, -}, -{ /* DomainPinVcpu => 26 */ - .fn = (dispatch_fn) remoteDispatchDomainPinVcpu, - .args_filter = (xdrproc_t) xdr_remote_domain_pin_vcpu_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainReboot => 27 */ - .fn = (dispatch_fn) remoteDispatchDomainReboot, - .args_filter = (xdrproc_t) xdr_remote_domain_reboot_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainResume => 28 */ - .fn = (dispatch_fn) remoteDispatchDomainResume, - .args_filter = (xdrproc_t) xdr_remote_domain_resume_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainSetAutostart => 29 */ - .fn = (dispatch_fn) remoteDispatchDomainSetAutostart, - .args_filter = (xdrproc_t) xdr_remote_domain_set_autostart_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainSetMaxMemory => 30 */ - .fn = (dispatch_fn) remoteDispatchDomainSetMaxMemory, - .args_filter = (xdrproc_t) xdr_remote_domain_set_max_memory_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainSetMemory => 31 */ - .fn = (dispatch_fn) remoteDispatchDomainSetMemory, - .args_filter = (xdrproc_t) xdr_remote_domain_set_memory_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainSetVcpus => 32 */ - .fn = (dispatch_fn) remoteDispatchDomainSetVcpus, - .args_filter = (xdrproc_t) xdr_remote_domain_set_vcpus_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainShutdown => 33 */ - .fn = (dispatch_fn) remoteDispatchDomainShutdown, - .args_filter = (xdrproc_t) xdr_remote_domain_shutdown_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainSuspend => 34 */ - .fn = (dispatch_fn) remoteDispatchDomainSuspend, - .args_filter = (xdrproc_t) xdr_remote_domain_suspend_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainUndefine => 35 */ - .fn = (dispatch_fn) remoteDispatchDomainUndefine, - .args_filter = (xdrproc_t) xdr_remote_domain_undefine_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* ListDefinedNetworks => 36 */ - .fn = (dispatch_fn) remoteDispatchListDefinedNetworks, - .args_filter = (xdrproc_t) xdr_remote_list_defined_networks_args, - .ret_filter = (xdrproc_t) xdr_remote_list_defined_networks_ret, -}, -{ /* ListDomains => 37 */ - .fn = (dispatch_fn) remoteDispatchListDomains, - .args_filter = (xdrproc_t) xdr_remote_list_domains_args, - .ret_filter = (xdrproc_t) xdr_remote_list_domains_ret, -}, -{ /* ListNetworks => 38 */ - .fn = (dispatch_fn) remoteDispatchListNetworks, - .args_filter = (xdrproc_t) xdr_remote_list_networks_args, - .ret_filter = (xdrproc_t) xdr_remote_list_networks_ret, -}, -{ /* NetworkCreate => 39 */ - .fn = (dispatch_fn) remoteDispatchNetworkCreate, - .args_filter = (xdrproc_t) xdr_remote_network_create_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* NetworkCreateXml => 40 */ - .fn = (dispatch_fn) remoteDispatchNetworkCreateXml, - .args_filter = (xdrproc_t) xdr_remote_network_create_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_network_create_xml_ret, -}, -{ /* NetworkDefineXml => 41 */ - .fn = (dispatch_fn) remoteDispatchNetworkDefineXml, - .args_filter = (xdrproc_t) xdr_remote_network_define_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_network_define_xml_ret, -}, -{ /* NetworkDestroy => 42 */ - .fn = (dispatch_fn) remoteDispatchNetworkDestroy, - .args_filter = (xdrproc_t) xdr_remote_network_destroy_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* NetworkDumpXml => 43 */ - .fn = (dispatch_fn) remoteDispatchNetworkDumpXml, - .args_filter = (xdrproc_t) xdr_remote_network_dump_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_network_dump_xml_ret, -}, -{ /* NetworkGetAutostart => 44 */ - .fn = (dispatch_fn) remoteDispatchNetworkGetAutostart, - .args_filter = (xdrproc_t) xdr_remote_network_get_autostart_args, - .ret_filter = (xdrproc_t) xdr_remote_network_get_autostart_ret, -}, -{ /* NetworkGetBridgeName => 45 */ - .fn = (dispatch_fn) remoteDispatchNetworkGetBridgeName, - .args_filter = (xdrproc_t) xdr_remote_network_get_bridge_name_args, - .ret_filter = (xdrproc_t) xdr_remote_network_get_bridge_name_ret, -}, -{ /* NetworkLookupByName => 46 */ - .fn = (dispatch_fn) remoteDispatchNetworkLookupByName, - .args_filter = (xdrproc_t) xdr_remote_network_lookup_by_name_args, - .ret_filter = (xdrproc_t) xdr_remote_network_lookup_by_name_ret, -}, -{ /* NetworkLookupByUuid => 47 */ - .fn = (dispatch_fn) remoteDispatchNetworkLookupByUuid, - .args_filter = (xdrproc_t) xdr_remote_network_lookup_by_uuid_args, - .ret_filter = (xdrproc_t) xdr_remote_network_lookup_by_uuid_ret, -}, -{ /* NetworkSetAutostart => 48 */ - .fn = (dispatch_fn) remoteDispatchNetworkSetAutostart, - .args_filter = (xdrproc_t) xdr_remote_network_set_autostart_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* NetworkUndefine => 49 */ - .fn = (dispatch_fn) remoteDispatchNetworkUndefine, - .args_filter = (xdrproc_t) xdr_remote_network_undefine_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* NumOfDefinedNetworks => 50 */ - .fn = (dispatch_fn) remoteDispatchNumOfDefinedNetworks, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_num_of_defined_networks_ret, -}, -{ /* NumOfDomains => 51 */ - .fn = (dispatch_fn) remoteDispatchNumOfDomains, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_num_of_domains_ret, -}, -{ /* NumOfNetworks => 52 */ - .fn = (dispatch_fn) remoteDispatchNumOfNetworks, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_num_of_networks_ret, -}, -{ /* DomainCoreDump => 53 */ - .fn = (dispatch_fn) remoteDispatchDomainCoreDump, - .args_filter = (xdrproc_t) xdr_remote_domain_core_dump_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainRestore => 54 */ - .fn = (dispatch_fn) remoteDispatchDomainRestore, - .args_filter = (xdrproc_t) xdr_remote_domain_restore_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainSave => 55 */ - .fn = (dispatch_fn) remoteDispatchDomainSave, - .args_filter = (xdrproc_t) xdr_remote_domain_save_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainGetSchedulerType => 56 */ - .fn = (dispatch_fn) remoteDispatchDomainGetSchedulerType, - .args_filter = (xdrproc_t) xdr_remote_domain_get_scheduler_type_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_scheduler_type_ret, -}, -{ /* DomainGetSchedulerParameters => 57 */ - .fn = (dispatch_fn) remoteDispatchDomainGetSchedulerParameters, - .args_filter = (xdrproc_t) xdr_remote_domain_get_scheduler_parameters_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_scheduler_parameters_ret, -}, -{ /* DomainSetSchedulerParameters => 58 */ - .fn = (dispatch_fn) remoteDispatchDomainSetSchedulerParameters, - .args_filter = (xdrproc_t) xdr_remote_domain_set_scheduler_parameters_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* GetHostname => 59 */ - .fn = (dispatch_fn) remoteDispatchGetHostname, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_get_hostname_ret, -}, -{ /* SupportsFeature => 60 */ - .fn = (dispatch_fn) remoteDispatchSupportsFeature, - .args_filter = (xdrproc_t) xdr_remote_supports_feature_args, - .ret_filter = (xdrproc_t) xdr_remote_supports_feature_ret, -}, -{ /* DomainMigratePrepare => 61 */ - .fn = (dispatch_fn) remoteDispatchDomainMigratePrepare, - .args_filter = (xdrproc_t) xdr_remote_domain_migrate_prepare_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_migrate_prepare_ret, -}, -{ /* DomainMigratePerform => 62 */ - .fn = (dispatch_fn) remoteDispatchDomainMigratePerform, - .args_filter = (xdrproc_t) xdr_remote_domain_migrate_perform_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainMigrateFinish => 63 */ - .fn = (dispatch_fn) remoteDispatchDomainMigrateFinish, - .args_filter = (xdrproc_t) xdr_remote_domain_migrate_finish_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_migrate_finish_ret, -}, -{ /* DomainBlockStats => 64 */ - .fn = (dispatch_fn) remoteDispatchDomainBlockStats, - .args_filter = (xdrproc_t) xdr_remote_domain_block_stats_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_block_stats_ret, -}, -{ /* DomainInterfaceStats => 65 */ - .fn = (dispatch_fn) remoteDispatchDomainInterfaceStats, - .args_filter = (xdrproc_t) xdr_remote_domain_interface_stats_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_interface_stats_ret, -}, -{ /* AuthList => 66 */ - .fn = (dispatch_fn) remoteDispatchAuthList, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_auth_list_ret, -}, -{ /* AuthSaslInit => 67 */ - .fn = (dispatch_fn) remoteDispatchAuthSaslInit, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_auth_sasl_init_ret, -}, -{ /* AuthSaslStart => 68 */ - .fn = (dispatch_fn) remoteDispatchAuthSaslStart, - .args_filter = (xdrproc_t) xdr_remote_auth_sasl_start_args, - .ret_filter = (xdrproc_t) xdr_remote_auth_sasl_start_ret, -}, -{ /* AuthSaslStep => 69 */ - .fn = (dispatch_fn) remoteDispatchAuthSaslStep, - .args_filter = (xdrproc_t) xdr_remote_auth_sasl_step_args, - .ret_filter = (xdrproc_t) xdr_remote_auth_sasl_step_ret, -}, -{ /* AuthPolkit => 70 */ - .fn = (dispatch_fn) remoteDispatchAuthPolkit, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_auth_polkit_ret, -}, -{ /* NumOfStoragePools => 71 */ - .fn = (dispatch_fn) remoteDispatchNumOfStoragePools, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_num_of_storage_pools_ret, -}, -{ /* ListStoragePools => 72 */ - .fn = (dispatch_fn) remoteDispatchListStoragePools, - .args_filter = (xdrproc_t) xdr_remote_list_storage_pools_args, - .ret_filter = (xdrproc_t) xdr_remote_list_storage_pools_ret, -}, -{ /* NumOfDefinedStoragePools => 73 */ - .fn = (dispatch_fn) remoteDispatchNumOfDefinedStoragePools, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_num_of_defined_storage_pools_ret, -}, -{ /* ListDefinedStoragePools => 74 */ - .fn = (dispatch_fn) remoteDispatchListDefinedStoragePools, - .args_filter = (xdrproc_t) xdr_remote_list_defined_storage_pools_args, - .ret_filter = (xdrproc_t) xdr_remote_list_defined_storage_pools_ret, -}, -{ /* FindStoragePoolSources => 75 */ - .fn = (dispatch_fn) remoteDispatchFindStoragePoolSources, - .args_filter = (xdrproc_t) xdr_remote_find_storage_pool_sources_args, - .ret_filter = (xdrproc_t) xdr_remote_find_storage_pool_sources_ret, -}, -{ /* StoragePoolCreateXml => 76 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolCreateXml, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_create_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_pool_create_xml_ret, -}, -{ /* StoragePoolDefineXml => 77 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolDefineXml, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_define_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_pool_define_xml_ret, -}, -{ /* StoragePoolCreate => 78 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolCreate, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_create_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* StoragePoolBuild => 79 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolBuild, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_build_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* StoragePoolDestroy => 80 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolDestroy, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_destroy_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* StoragePoolDelete => 81 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolDelete, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_delete_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* StoragePoolUndefine => 82 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolUndefine, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_undefine_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* StoragePoolRefresh => 83 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolRefresh, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_refresh_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* StoragePoolLookupByName => 84 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolLookupByName, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_lookup_by_name_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_pool_lookup_by_name_ret, -}, -{ /* StoragePoolLookupByUuid => 85 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolLookupByUuid, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_lookup_by_uuid_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_pool_lookup_by_uuid_ret, -}, -{ /* StoragePoolLookupByVolume => 86 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolLookupByVolume, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_lookup_by_volume_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_pool_lookup_by_volume_ret, -}, -{ /* StoragePoolGetInfo => 87 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolGetInfo, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_get_info_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_pool_get_info_ret, -}, -{ /* StoragePoolDumpXml => 88 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolDumpXml, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_dump_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_pool_dump_xml_ret, -}, -{ /* StoragePoolGetAutostart => 89 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolGetAutostart, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_get_autostart_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_pool_get_autostart_ret, -}, -{ /* StoragePoolSetAutostart => 90 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolSetAutostart, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_set_autostart_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* StoragePoolNumOfVolumes => 91 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolNumOfVolumes, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_num_of_volumes_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_pool_num_of_volumes_ret, -}, -{ /* StoragePoolListVolumes => 92 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolListVolumes, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_list_volumes_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_pool_list_volumes_ret, -}, -{ /* StorageVolCreateXml => 93 */ - .fn = (dispatch_fn) remoteDispatchStorageVolCreateXml, - .args_filter = (xdrproc_t) xdr_remote_storage_vol_create_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_vol_create_xml_ret, -}, -{ /* StorageVolDelete => 94 */ - .fn = (dispatch_fn) remoteDispatchStorageVolDelete, - .args_filter = (xdrproc_t) xdr_remote_storage_vol_delete_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* StorageVolLookupByName => 95 */ - .fn = (dispatch_fn) remoteDispatchStorageVolLookupByName, - .args_filter = (xdrproc_t) xdr_remote_storage_vol_lookup_by_name_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_vol_lookup_by_name_ret, -}, -{ /* StorageVolLookupByKey => 96 */ - .fn = (dispatch_fn) remoteDispatchStorageVolLookupByKey, - .args_filter = (xdrproc_t) xdr_remote_storage_vol_lookup_by_key_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_vol_lookup_by_key_ret, -}, -{ /* StorageVolLookupByPath => 97 */ - .fn = (dispatch_fn) remoteDispatchStorageVolLookupByPath, - .args_filter = (xdrproc_t) xdr_remote_storage_vol_lookup_by_path_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_vol_lookup_by_path_ret, -}, -{ /* StorageVolGetInfo => 98 */ - .fn = (dispatch_fn) remoteDispatchStorageVolGetInfo, - .args_filter = (xdrproc_t) xdr_remote_storage_vol_get_info_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_vol_get_info_ret, -}, -{ /* StorageVolDumpXml => 99 */ - .fn = (dispatch_fn) remoteDispatchStorageVolDumpXml, - .args_filter = (xdrproc_t) xdr_remote_storage_vol_dump_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_vol_dump_xml_ret, -}, -{ /* StorageVolGetPath => 100 */ - .fn = (dispatch_fn) remoteDispatchStorageVolGetPath, - .args_filter = (xdrproc_t) xdr_remote_storage_vol_get_path_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_vol_get_path_ret, -}, -{ /* NodeGetCellsFreeMemory => 101 */ - .fn = (dispatch_fn) remoteDispatchNodeGetCellsFreeMemory, - .args_filter = (xdrproc_t) xdr_remote_node_get_cells_free_memory_args, - .ret_filter = (xdrproc_t) xdr_remote_node_get_cells_free_memory_ret, -}, -{ /* NodeGetFreeMemory => 102 */ - .fn = (dispatch_fn) remoteDispatchNodeGetFreeMemory, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_node_get_free_memory_ret, -}, -{ /* DomainBlockPeek => 103 */ - .fn = (dispatch_fn) remoteDispatchDomainBlockPeek, - .args_filter = (xdrproc_t) xdr_remote_domain_block_peek_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_block_peek_ret, -}, -{ /* DomainMemoryPeek => 104 */ - .fn = (dispatch_fn) remoteDispatchDomainMemoryPeek, - .args_filter = (xdrproc_t) xdr_remote_domain_memory_peek_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_memory_peek_ret, -}, -{ /* DomainEventsRegister => 105 */ - .fn = (dispatch_fn) remoteDispatchDomainEventsRegister, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_domain_events_register_ret, -}, -{ /* DomainEventsDeregister => 106 */ - .fn = (dispatch_fn) remoteDispatchDomainEventsDeregister, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_domain_events_deregister_ret, -}, -{ /* Async event DomainEventLifecycle => 107 */ - .fn = NULL, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainMigratePrepare2 => 108 */ - .fn = (dispatch_fn) remoteDispatchDomainMigratePrepare2, - .args_filter = (xdrproc_t) xdr_remote_domain_migrate_prepare2_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_migrate_prepare2_ret, -}, -{ /* DomainMigrateFinish2 => 109 */ - .fn = (dispatch_fn) remoteDispatchDomainMigrateFinish2, - .args_filter = (xdrproc_t) xdr_remote_domain_migrate_finish2_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_migrate_finish2_ret, -}, -{ /* GetUri => 110 */ - .fn = (dispatch_fn) remoteDispatchGetUri, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_get_uri_ret, -}, -{ /* NodeNumOfDevices => 111 */ - .fn = (dispatch_fn) remoteDispatchNodeNumOfDevices, - .args_filter = (xdrproc_t) xdr_remote_node_num_of_devices_args, - .ret_filter = (xdrproc_t) xdr_remote_node_num_of_devices_ret, -}, -{ /* NodeListDevices => 112 */ - .fn = (dispatch_fn) remoteDispatchNodeListDevices, - .args_filter = (xdrproc_t) xdr_remote_node_list_devices_args, - .ret_filter = (xdrproc_t) xdr_remote_node_list_devices_ret, -}, -{ /* NodeDeviceLookupByName => 113 */ - .fn = (dispatch_fn) remoteDispatchNodeDeviceLookupByName, - .args_filter = (xdrproc_t) xdr_remote_node_device_lookup_by_name_args, - .ret_filter = (xdrproc_t) xdr_remote_node_device_lookup_by_name_ret, -}, -{ /* NodeDeviceDumpXml => 114 */ - .fn = (dispatch_fn) remoteDispatchNodeDeviceDumpXml, - .args_filter = (xdrproc_t) xdr_remote_node_device_dump_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_node_device_dump_xml_ret, -}, -{ /* NodeDeviceGetParent => 115 */ - .fn = (dispatch_fn) remoteDispatchNodeDeviceGetParent, - .args_filter = (xdrproc_t) xdr_remote_node_device_get_parent_args, - .ret_filter = (xdrproc_t) xdr_remote_node_device_get_parent_ret, -}, -{ /* NodeDeviceNumOfCaps => 116 */ - .fn = (dispatch_fn) remoteDispatchNodeDeviceNumOfCaps, - .args_filter = (xdrproc_t) xdr_remote_node_device_num_of_caps_args, - .ret_filter = (xdrproc_t) xdr_remote_node_device_num_of_caps_ret, -}, -{ /* NodeDeviceListCaps => 117 */ - .fn = (dispatch_fn) remoteDispatchNodeDeviceListCaps, - .args_filter = (xdrproc_t) xdr_remote_node_device_list_caps_args, - .ret_filter = (xdrproc_t) xdr_remote_node_device_list_caps_ret, -}, -{ /* NodeDeviceDettach => 118 */ - .fn = (dispatch_fn) remoteDispatchNodeDeviceDettach, - .args_filter = (xdrproc_t) xdr_remote_node_device_dettach_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* NodeDeviceReAttach => 119 */ - .fn = (dispatch_fn) remoteDispatchNodeDeviceReAttach, - .args_filter = (xdrproc_t) xdr_remote_node_device_re_attach_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* NodeDeviceReset => 120 */ - .fn = (dispatch_fn) remoteDispatchNodeDeviceReset, - .args_filter = (xdrproc_t) xdr_remote_node_device_reset_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainGetSecurityLabel => 121 */ - .fn = (dispatch_fn) remoteDispatchDomainGetSecurityLabel, - .args_filter = (xdrproc_t) xdr_remote_domain_get_security_label_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_security_label_ret, -}, -{ /* NodeGetSecurityModel => 122 */ - .fn = (dispatch_fn) remoteDispatchNodeGetSecurityModel, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_node_get_security_model_ret, -}, -{ /* NodeDeviceCreateXml => 123 */ - .fn = (dispatch_fn) remoteDispatchNodeDeviceCreateXml, - .args_filter = (xdrproc_t) xdr_remote_node_device_create_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_node_device_create_xml_ret, -}, -{ /* NodeDeviceDestroy => 124 */ - .fn = (dispatch_fn) remoteDispatchNodeDeviceDestroy, - .args_filter = (xdrproc_t) xdr_remote_node_device_destroy_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* StorageVolCreateXmlFrom => 125 */ - .fn = (dispatch_fn) remoteDispatchStorageVolCreateXmlFrom, - .args_filter = (xdrproc_t) xdr_remote_storage_vol_create_xml_from_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_vol_create_xml_from_ret, -}, -{ /* NumOfInterfaces => 126 */ - .fn = (dispatch_fn) remoteDispatchNumOfInterfaces, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_num_of_interfaces_ret, -}, -{ /* ListInterfaces => 127 */ - .fn = (dispatch_fn) remoteDispatchListInterfaces, - .args_filter = (xdrproc_t) xdr_remote_list_interfaces_args, - .ret_filter = (xdrproc_t) xdr_remote_list_interfaces_ret, -}, -{ /* InterfaceLookupByName => 128 */ - .fn = (dispatch_fn) remoteDispatchInterfaceLookupByName, - .args_filter = (xdrproc_t) xdr_remote_interface_lookup_by_name_args, - .ret_filter = (xdrproc_t) xdr_remote_interface_lookup_by_name_ret, -}, -{ /* InterfaceLookupByMacString => 129 */ - .fn = (dispatch_fn) remoteDispatchInterfaceLookupByMacString, - .args_filter = (xdrproc_t) xdr_remote_interface_lookup_by_mac_string_args, - .ret_filter = (xdrproc_t) xdr_remote_interface_lookup_by_mac_string_ret, -}, -{ /* InterfaceGetXmlDesc => 130 */ - .fn = (dispatch_fn) remoteDispatchInterfaceGetXmlDesc, - .args_filter = (xdrproc_t) xdr_remote_interface_get_xml_desc_args, - .ret_filter = (xdrproc_t) xdr_remote_interface_get_xml_desc_ret, -}, -{ /* InterfaceDefineXml => 131 */ - .fn = (dispatch_fn) remoteDispatchInterfaceDefineXml, - .args_filter = (xdrproc_t) xdr_remote_interface_define_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_interface_define_xml_ret, -}, -{ /* InterfaceUndefine => 132 */ - .fn = (dispatch_fn) remoteDispatchInterfaceUndefine, - .args_filter = (xdrproc_t) xdr_remote_interface_undefine_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* InterfaceCreate => 133 */ - .fn = (dispatch_fn) remoteDispatchInterfaceCreate, - .args_filter = (xdrproc_t) xdr_remote_interface_create_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* InterfaceDestroy => 134 */ - .fn = (dispatch_fn) remoteDispatchInterfaceDestroy, - .args_filter = (xdrproc_t) xdr_remote_interface_destroy_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainXmlFromNative => 135 */ - .fn = (dispatch_fn) remoteDispatchDomainXmlFromNative, - .args_filter = (xdrproc_t) xdr_remote_domain_xml_from_native_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_xml_from_native_ret, -}, -{ /* DomainXmlToNative => 136 */ - .fn = (dispatch_fn) remoteDispatchDomainXmlToNative, - .args_filter = (xdrproc_t) xdr_remote_domain_xml_to_native_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_xml_to_native_ret, -}, -{ /* NumOfDefinedInterfaces => 137 */ - .fn = (dispatch_fn) remoteDispatchNumOfDefinedInterfaces, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_num_of_defined_interfaces_ret, -}, -{ /* ListDefinedInterfaces => 138 */ - .fn = (dispatch_fn) remoteDispatchListDefinedInterfaces, - .args_filter = (xdrproc_t) xdr_remote_list_defined_interfaces_args, - .ret_filter = (xdrproc_t) xdr_remote_list_defined_interfaces_ret, -}, -{ /* NumOfSecrets => 139 */ - .fn = (dispatch_fn) remoteDispatchNumOfSecrets, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_num_of_secrets_ret, -}, -{ /* ListSecrets => 140 */ - .fn = (dispatch_fn) remoteDispatchListSecrets, - .args_filter = (xdrproc_t) xdr_remote_list_secrets_args, - .ret_filter = (xdrproc_t) xdr_remote_list_secrets_ret, -}, -{ /* SecretLookupByUuid => 141 */ - .fn = (dispatch_fn) remoteDispatchSecretLookupByUuid, - .args_filter = (xdrproc_t) xdr_remote_secret_lookup_by_uuid_args, - .ret_filter = (xdrproc_t) xdr_remote_secret_lookup_by_uuid_ret, -}, -{ /* SecretDefineXml => 142 */ - .fn = (dispatch_fn) remoteDispatchSecretDefineXml, - .args_filter = (xdrproc_t) xdr_remote_secret_define_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_secret_define_xml_ret, -}, -{ /* SecretGetXmlDesc => 143 */ - .fn = (dispatch_fn) remoteDispatchSecretGetXmlDesc, - .args_filter = (xdrproc_t) xdr_remote_secret_get_xml_desc_args, - .ret_filter = (xdrproc_t) xdr_remote_secret_get_xml_desc_ret, -}, -{ /* SecretSetValue => 144 */ - .fn = (dispatch_fn) remoteDispatchSecretSetValue, - .args_filter = (xdrproc_t) xdr_remote_secret_set_value_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* SecretGetValue => 145 */ - .fn = (dispatch_fn) remoteDispatchSecretGetValue, - .args_filter = (xdrproc_t) xdr_remote_secret_get_value_args, - .ret_filter = (xdrproc_t) xdr_remote_secret_get_value_ret, -}, -{ /* SecretUndefine => 146 */ - .fn = (dispatch_fn) remoteDispatchSecretUndefine, - .args_filter = (xdrproc_t) xdr_remote_secret_undefine_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* SecretLookupByUsage => 147 */ - .fn = (dispatch_fn) remoteDispatchSecretLookupByUsage, - .args_filter = (xdrproc_t) xdr_remote_secret_lookup_by_usage_args, - .ret_filter = (xdrproc_t) xdr_remote_secret_lookup_by_usage_ret, -}, -{ /* DomainMigratePrepareTunnel => 148 */ - .fn = (dispatch_fn) remoteDispatchDomainMigratePrepareTunnel, - .args_filter = (xdrproc_t) xdr_remote_domain_migrate_prepare_tunnel_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* IsSecure => 149 */ - .fn = (dispatch_fn) remoteDispatchIsSecure, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_is_secure_ret, -}, -{ /* DomainIsActive => 150 */ - .fn = (dispatch_fn) remoteDispatchDomainIsActive, - .args_filter = (xdrproc_t) xdr_remote_domain_is_active_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_is_active_ret, -}, -{ /* DomainIsPersistent => 151 */ - .fn = (dispatch_fn) remoteDispatchDomainIsPersistent, - .args_filter = (xdrproc_t) xdr_remote_domain_is_persistent_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_is_persistent_ret, -}, -{ /* NetworkIsActive => 152 */ - .fn = (dispatch_fn) remoteDispatchNetworkIsActive, - .args_filter = (xdrproc_t) xdr_remote_network_is_active_args, - .ret_filter = (xdrproc_t) xdr_remote_network_is_active_ret, -}, -{ /* NetworkIsPersistent => 153 */ - .fn = (dispatch_fn) remoteDispatchNetworkIsPersistent, - .args_filter = (xdrproc_t) xdr_remote_network_is_persistent_args, - .ret_filter = (xdrproc_t) xdr_remote_network_is_persistent_ret, -}, -{ /* StoragePoolIsActive => 154 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolIsActive, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_is_active_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_pool_is_active_ret, -}, -{ /* StoragePoolIsPersistent => 155 */ - .fn = (dispatch_fn) remoteDispatchStoragePoolIsPersistent, - .args_filter = (xdrproc_t) xdr_remote_storage_pool_is_persistent_args, - .ret_filter = (xdrproc_t) xdr_remote_storage_pool_is_persistent_ret, -}, -{ /* InterfaceIsActive => 156 */ - .fn = (dispatch_fn) remoteDispatchInterfaceIsActive, - .args_filter = (xdrproc_t) xdr_remote_interface_is_active_args, - .ret_filter = (xdrproc_t) xdr_remote_interface_is_active_ret, -}, -{ /* GetLibVersion => 157 */ - .fn = (dispatch_fn) remoteDispatchGetLibVersion, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_get_lib_version_ret, -}, -{ /* CpuCompare => 158 */ - .fn = (dispatch_fn) remoteDispatchCpuCompare, - .args_filter = (xdrproc_t) xdr_remote_cpu_compare_args, - .ret_filter = (xdrproc_t) xdr_remote_cpu_compare_ret, -}, -{ /* DomainMemoryStats => 159 */ - .fn = (dispatch_fn) remoteDispatchDomainMemoryStats, - .args_filter = (xdrproc_t) xdr_remote_domain_memory_stats_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_memory_stats_ret, -}, -{ /* DomainAttachDeviceFlags => 160 */ - .fn = (dispatch_fn) remoteDispatchDomainAttachDeviceFlags, - .args_filter = (xdrproc_t) xdr_remote_domain_attach_device_flags_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainDetachDeviceFlags => 161 */ - .fn = (dispatch_fn) remoteDispatchDomainDetachDeviceFlags, - .args_filter = (xdrproc_t) xdr_remote_domain_detach_device_flags_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* CpuBaseline => 162 */ - .fn = (dispatch_fn) remoteDispatchCpuBaseline, - .args_filter = (xdrproc_t) xdr_remote_cpu_baseline_args, - .ret_filter = (xdrproc_t) xdr_remote_cpu_baseline_ret, -}, -{ /* DomainGetJobInfo => 163 */ - .fn = (dispatch_fn) remoteDispatchDomainGetJobInfo, - .args_filter = (xdrproc_t) xdr_remote_domain_get_job_info_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_job_info_ret, -}, -{ /* DomainAbortJob => 164 */ - .fn = (dispatch_fn) remoteDispatchDomainAbortJob, - .args_filter = (xdrproc_t) xdr_remote_domain_abort_job_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* StorageVolWipe => 165 */ - .fn = (dispatch_fn) remoteDispatchStorageVolWipe, - .args_filter = (xdrproc_t) xdr_remote_storage_vol_wipe_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainMigrateSetMaxDowntime => 166 */ - .fn = (dispatch_fn) remoteDispatchDomainMigrateSetMaxDowntime, - .args_filter = (xdrproc_t) xdr_remote_domain_migrate_set_max_downtime_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainEventsRegisterAny => 167 */ - .fn = (dispatch_fn) remoteDispatchDomainEventsRegisterAny, - .args_filter = (xdrproc_t) xdr_remote_domain_events_register_any_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainEventsDeregisterAny => 168 */ - .fn = (dispatch_fn) remoteDispatchDomainEventsDeregisterAny, - .args_filter = (xdrproc_t) xdr_remote_domain_events_deregister_any_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* Async event DomainEventReboot => 169 */ - .fn = NULL, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* Async event DomainEventRtcChange => 170 */ - .fn = NULL, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* Async event DomainEventWatchdog => 171 */ - .fn = NULL, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* Async event DomainEventIoError => 172 */ - .fn = NULL, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* Async event DomainEventGraphics => 173 */ - .fn = NULL, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainUpdateDeviceFlags => 174 */ - .fn = (dispatch_fn) remoteDispatchDomainUpdateDeviceFlags, - .args_filter = (xdrproc_t) xdr_remote_domain_update_device_flags_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* NwfilterLookupByName => 175 */ - .fn = (dispatch_fn) remoteDispatchNwfilterLookupByName, - .args_filter = (xdrproc_t) xdr_remote_nwfilter_lookup_by_name_args, - .ret_filter = (xdrproc_t) xdr_remote_nwfilter_lookup_by_name_ret, -}, -{ /* NwfilterLookupByUuid => 176 */ - .fn = (dispatch_fn) remoteDispatchNwfilterLookupByUuid, - .args_filter = (xdrproc_t) xdr_remote_nwfilter_lookup_by_uuid_args, - .ret_filter = (xdrproc_t) xdr_remote_nwfilter_lookup_by_uuid_ret, -}, -{ /* NwfilterGetXmlDesc => 177 */ - .fn = (dispatch_fn) remoteDispatchNwfilterGetXmlDesc, - .args_filter = (xdrproc_t) xdr_remote_nwfilter_get_xml_desc_args, - .ret_filter = (xdrproc_t) xdr_remote_nwfilter_get_xml_desc_ret, -}, -{ /* NumOfNwfilters => 178 */ - .fn = (dispatch_fn) remoteDispatchNumOfNwfilters, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_remote_num_of_nwfilters_ret, -}, -{ /* ListNwfilters => 179 */ - .fn = (dispatch_fn) remoteDispatchListNwfilters, - .args_filter = (xdrproc_t) xdr_remote_list_nwfilters_args, - .ret_filter = (xdrproc_t) xdr_remote_list_nwfilters_ret, -}, -{ /* NwfilterDefineXml => 180 */ - .fn = (dispatch_fn) remoteDispatchNwfilterDefineXml, - .args_filter = (xdrproc_t) xdr_remote_nwfilter_define_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_nwfilter_define_xml_ret, -}, -{ /* NwfilterUndefine => 181 */ - .fn = (dispatch_fn) remoteDispatchNwfilterUndefine, - .args_filter = (xdrproc_t) xdr_remote_nwfilter_undefine_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainManagedSave => 182 */ - .fn = (dispatch_fn) remoteDispatchDomainManagedSave, - .args_filter = (xdrproc_t) xdr_remote_domain_managed_save_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainHasManagedSaveImage => 183 */ - .fn = (dispatch_fn) remoteDispatchDomainHasManagedSaveImage, - .args_filter = (xdrproc_t) xdr_remote_domain_has_managed_save_image_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_has_managed_save_image_ret, -}, -{ /* DomainManagedSaveRemove => 184 */ - .fn = (dispatch_fn) remoteDispatchDomainManagedSaveRemove, - .args_filter = (xdrproc_t) xdr_remote_domain_managed_save_remove_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainSnapshotCreateXml => 185 */ - .fn = (dispatch_fn) remoteDispatchDomainSnapshotCreateXml, - .args_filter = (xdrproc_t) xdr_remote_domain_snapshot_create_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_snapshot_create_xml_ret, -}, -{ /* DomainSnapshotDumpXml => 186 */ - .fn = (dispatch_fn) remoteDispatchDomainSnapshotDumpXml, - .args_filter = (xdrproc_t) xdr_remote_domain_snapshot_dump_xml_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_snapshot_dump_xml_ret, -}, -{ /* DomainSnapshotNum => 187 */ - .fn = (dispatch_fn) remoteDispatchDomainSnapshotNum, - .args_filter = (xdrproc_t) xdr_remote_domain_snapshot_num_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_snapshot_num_ret, -}, -{ /* DomainSnapshotListNames => 188 */ - .fn = (dispatch_fn) remoteDispatchDomainSnapshotListNames, - .args_filter = (xdrproc_t) xdr_remote_domain_snapshot_list_names_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_snapshot_list_names_ret, -}, -{ /* DomainSnapshotLookupByName => 189 */ - .fn = (dispatch_fn) remoteDispatchDomainSnapshotLookupByName, - .args_filter = (xdrproc_t) xdr_remote_domain_snapshot_lookup_by_name_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_snapshot_lookup_by_name_ret, -}, -{ /* DomainHasCurrentSnapshot => 190 */ - .fn = (dispatch_fn) remoteDispatchDomainHasCurrentSnapshot, - .args_filter = (xdrproc_t) xdr_remote_domain_has_current_snapshot_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_has_current_snapshot_ret, -}, -{ /* DomainSnapshotCurrent => 191 */ - .fn = (dispatch_fn) remoteDispatchDomainSnapshotCurrent, - .args_filter = (xdrproc_t) xdr_remote_domain_snapshot_current_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_snapshot_current_ret, -}, -{ /* DomainRevertToSnapshot => 192 */ - .fn = (dispatch_fn) remoteDispatchDomainRevertToSnapshot, - .args_filter = (xdrproc_t) xdr_remote_domain_revert_to_snapshot_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainSnapshotDelete => 193 */ - .fn = (dispatch_fn) remoteDispatchDomainSnapshotDelete, - .args_filter = (xdrproc_t) xdr_remote_domain_snapshot_delete_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainGetBlockInfo => 194 */ - .fn = (dispatch_fn) remoteDispatchDomainGetBlockInfo, - .args_filter = (xdrproc_t) xdr_remote_domain_get_block_info_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_block_info_ret, -}, -{ /* Async event DomainEventIoErrorReason => 195 */ - .fn = NULL, - .args_filter = (xdrproc_t) xdr_void, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainCreateWithFlags => 196 */ - .fn = (dispatch_fn) remoteDispatchDomainCreateWithFlags, - .args_filter = (xdrproc_t) xdr_remote_domain_create_with_flags_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_create_with_flags_ret, -}, -{ /* DomainSetMemoryParameters => 197 */ - .fn = (dispatch_fn) remoteDispatchDomainSetMemoryParameters, - .args_filter = (xdrproc_t) xdr_remote_domain_set_memory_parameters_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainGetMemoryParameters => 198 */ - .fn = (dispatch_fn) remoteDispatchDomainGetMemoryParameters, - .args_filter = (xdrproc_t) xdr_remote_domain_get_memory_parameters_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_memory_parameters_ret, -}, -{ /* DomainSetVcpusFlags => 199 */ - .fn = (dispatch_fn) remoteDispatchDomainSetVcpusFlags, - .args_filter = (xdrproc_t) xdr_remote_domain_set_vcpus_flags_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainGetVcpusFlags => 200 */ - .fn = (dispatch_fn) remoteDispatchDomainGetVcpusFlags, - .args_filter = (xdrproc_t) xdr_remote_domain_get_vcpus_flags_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_vcpus_flags_ret, -}, -{ /* DomainOpenConsole => 201 */ - .fn = (dispatch_fn) remoteDispatchDomainOpenConsole, - .args_filter = (xdrproc_t) xdr_remote_domain_open_console_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainIsUpdated => 202 */ - .fn = (dispatch_fn) remoteDispatchDomainIsUpdated, - .args_filter = (xdrproc_t) xdr_remote_domain_is_updated_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_is_updated_ret, -}, -{ /* GetSysinfo => 203 */ - .fn = (dispatch_fn) remoteDispatchGetSysinfo, - .args_filter = (xdrproc_t) xdr_remote_get_sysinfo_args, - .ret_filter = (xdrproc_t) xdr_remote_get_sysinfo_ret, -}, -{ /* DomainSetMemoryFlags => 204 */ - .fn = (dispatch_fn) remoteDispatchDomainSetMemoryFlags, - .args_filter = (xdrproc_t) xdr_remote_domain_set_memory_flags_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainSetBlkioParameters => 205 */ - .fn = (dispatch_fn) remoteDispatchDomainSetBlkioParameters, - .args_filter = (xdrproc_t) xdr_remote_domain_set_blkio_parameters_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* DomainGetBlkioParameters => 206 */ - .fn = (dispatch_fn) remoteDispatchDomainGetBlkioParameters, - .args_filter = (xdrproc_t) xdr_remote_domain_get_blkio_parameters_args, - .ret_filter = (xdrproc_t) xdr_remote_domain_get_blkio_parameters_ret, -}, -{ /* DomainMigrateSetMaxSpeed => 207 */ - .fn = (dispatch_fn) remoteDispatchDomainMigrateSetMaxSpeed, - .args_filter = (xdrproc_t) xdr_remote_domain_migrate_set_max_speed_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* StorageVolUpload => 208 */ - .fn = (dispatch_fn) remoteDispatchStorageVolUpload, - .args_filter = (xdrproc_t) xdr_remote_storage_vol_upload_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -{ /* StorageVolDownload => 209 */ - .fn = (dispatch_fn) remoteDispatchStorageVolDownload, - .args_filter = (xdrproc_t) xdr_remote_storage_vol_download_args, - .ret_filter = (xdrproc_t) xdr_void, -}, -- 1.7.3.1 -- Thanks, Hu Tao

2011/5/5 Hu Tao <hutao@cn.fujitsu.com>:
1. this file is automatically generated at compile-time, so rm it to avoid further commit to this file. 2. any update should made to file src/remote/remote_protocol.x. --- daemon/remote_dispatch_table.h | 1054 ---------------------------------------- 1 files changed, 0 insertions(+), 1054 deletions(-) delete mode 100644 daemon/remote_dispatch_table.h
There is probably a reason why this generated file is under version control, maybe Dan knows. If we decide to remove the generated protocol dispatch header files then we should remove all of them (daemon/remote_dispatch_*.h and daemon/qemu_dispatch_*.h) and not just this single one. Matthias

At 05/05/2011 02:07 PM, Matthias Bolte Write:
2011/5/5 Hu Tao <hutao@cn.fujitsu.com>:
1. this file is automatically generated at compile-time, so rm it to avoid further commit to this file. 2. any update should made to file src/remote/remote_protocol.x. --- daemon/remote_dispatch_table.h | 1054 ---------------------------------------- 1 files changed, 0 insertions(+), 1054 deletions(-) delete mode 100644 daemon/remote_dispatch_table.h
There is probably a reason why this generated file is under version control, maybe Dan knows.
If we decide to remove the generated protocol dispatch header files then we should remove all of them (daemon/remote_dispatch_*.h and daemon/qemu_dispatch_*.h) and not just this single one.
We generate these files only when building with libvirtd now. If we remove them and build without libvirtd, we also need to generate them, otherwise 'make dist' will fail.
Matthias
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

On Thu, May 05, 2011 at 08:07:49AM +0200, Matthias Bolte wrote:
2011/5/5 Hu Tao <hutao@cn.fujitsu.com>:
1. this file is automatically generated at compile-time, so rm it to avoid further commit to this file. 2. any update should made to file src/remote/remote_protocol.x. --- daemon/remote_dispatch_table.h | 1054 ---------------------------------------- 1 files changed, 0 insertions(+), 1054 deletions(-) delete mode 100644 daemon/remote_dispatch_table.h
There is probably a reason why this generated file is under version control, maybe Dan knows.
If we decide to remove the generated protocol dispatch header files then we should remove all of them (daemon/remote_dispatch_*.h and daemon/qemu_dispatch_*.h) and not just this single one.
:( doesn't noticed other daemon/remote_dispatch_*.h are also generated ones. Thanks for pointing it out. Dan, what's your opinion?

On Thu, May 05, 2011 at 02:31:57PM +0800, Hu Tao wrote:
On Thu, May 05, 2011 at 08:07:49AM +0200, Matthias Bolte wrote:
2011/5/5 Hu Tao <hutao@cn.fujitsu.com>:
1. this file is automatically generated at compile-time, so rm it to avoid further commit to this file. 2. any update should made to file src/remote/remote_protocol.x. --- daemon/remote_dispatch_table.h | 1054 ---------------------------------------- 1 files changed, 0 insertions(+), 1054 deletions(-) delete mode 100644 daemon/remote_dispatch_table.h
There is probably a reason why this generated file is under version control, maybe Dan knows.
If we decide to remove the generated protocol dispatch header files then we should remove all of them (daemon/remote_dispatch_*.h and daemon/qemu_dispatch_*.h) and not just this single one.
:( doesn't noticed other daemon/remote_dispatch_*.h are also generated ones. Thanks for pointing it out.
Dan, what's your opinion?
my recollection is that they are kept because when compiling on windows we don't have ways to generate them. So while generated, they are kept in git and in the dist tarballs. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

On Thu, May 05, 2011 at 02:59:39PM +0800, Daniel Veillard wrote:
On Thu, May 05, 2011 at 02:31:57PM +0800, Hu Tao wrote:
On Thu, May 05, 2011 at 08:07:49AM +0200, Matthias Bolte wrote:
2011/5/5 Hu Tao <hutao@cn.fujitsu.com>:
1. this file is automatically generated at compile-time, so rm it to avoid further commit to this file. 2. any update should made to file src/remote/remote_protocol.x. --- daemon/remote_dispatch_table.h | 1054 ---------------------------------------- 1 files changed, 0 insertions(+), 1054 deletions(-) delete mode 100644 daemon/remote_dispatch_table.h
There is probably a reason why this generated file is under version control, maybe Dan knows.
If we decide to remove the generated protocol dispatch header files then we should remove all of them (daemon/remote_dispatch_*.h and daemon/qemu_dispatch_*.h) and not just this single one.
:( doesn't noticed other daemon/remote_dispatch_*.h are also generated ones. Thanks for pointing it out.
Dan, what's your opinion?
my recollection is that they are kept because when compiling on windows we don't have ways to generate them. So while generated, they are kept in git and in the dist tarballs.
We kept them because the rpcgen binary was kind of flakey on some platforms. This may no longer be required, but will need to check Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

On Thu, May 05, 2011 at 09:24:39AM +0100, Daniel P. Berrange wrote:
On Thu, May 05, 2011 at 02:59:39PM +0800, Daniel Veillard wrote:
On Thu, May 05, 2011 at 02:31:57PM +0800, Hu Tao wrote:
On Thu, May 05, 2011 at 08:07:49AM +0200, Matthias Bolte wrote:
2011/5/5 Hu Tao <hutao@cn.fujitsu.com>:
1. this file is automatically generated at compile-time, so rm it to avoid further commit to this file. 2. any update should made to file src/remote/remote_protocol.x. --- daemon/remote_dispatch_table.h | 1054 ---------------------------------------- 1 files changed, 0 insertions(+), 1054 deletions(-) delete mode 100644 daemon/remote_dispatch_table.h
There is probably a reason why this generated file is under version control, maybe Dan knows.
If we decide to remove the generated protocol dispatch header files then we should remove all of them (daemon/remote_dispatch_*.h and daemon/qemu_dispatch_*.h) and not just this single one.
:( doesn't noticed other daemon/remote_dispatch_*.h are also generated ones. Thanks for pointing it out.
Dan, what's your opinion?
my recollection is that they are kept because when compiling on windows we don't have ways to generate them. So while generated, they are kept in git and in the dist tarballs.
We kept them because the rpcgen binary was kind of flakey on some platforms. This may no longer be required, but will need to check
But daemon/remote_dispatch_*.h are generated by daemon/remote_generate_stubs.pl which doesn't depend on rpcgen. I deleted the *.h files and /usr/bin/rpcgen, and `make' still generated the *.h files. Maybe you mean src/remote/rpcgen_fix.pl but it is not related to the daemon/remote_dispatch_*.h files.

2011/5/5 Daniel P. Berrange <berrange@redhat.com>:
On Thu, May 05, 2011 at 02:59:39PM +0800, Daniel Veillard wrote:
On Thu, May 05, 2011 at 02:31:57PM +0800, Hu Tao wrote:
On Thu, May 05, 2011 at 08:07:49AM +0200, Matthias Bolte wrote:
2011/5/5 Hu Tao <hutao@cn.fujitsu.com>:
1. this file is automatically generated at compile-time, so rm it to avoid further commit to this file. 2. any update should made to file src/remote/remote_protocol.x. --- daemon/remote_dispatch_table.h | 1054 ---------------------------------------- 1 files changed, 0 insertions(+), 1054 deletions(-) delete mode 100644 daemon/remote_dispatch_table.h
There is probably a reason why this generated file is under version control, maybe Dan knows.
If we decide to remove the generated protocol dispatch header files then we should remove all of them (daemon/remote_dispatch_*.h and daemon/qemu_dispatch_*.h) and not just this single one.
:( doesn't noticed other daemon/remote_dispatch_*.h are also generated ones. Thanks for pointing it out.
Dan, what's your opinion?
my recollection is that they are kept because when compiling on windows we don't have ways to generate them. So while generated, they are kept in git and in the dist tarballs.
There are two generators involved rpcgen + rpcgen_fix.pl (client and daemon side) and remote_generate_stubs.pl (daemon side only). I'm not sure if the rpcgen that comes with portablexdr (used in my mingw build) comes with a capable rpcgen. Also I'm not sure about cygwin and rpcgen.
We kept them because the rpcgen binary was kind of flakey on some platforms. This may no longer be required, but will need to check
Daniel
I think we're talking about different things here. Thee are several related/generated files: The manually written XDR protocol definition files: src/remote/(remote|qemu)_protocol.x The rpcgen generated code for XDR argument and return value struct handling: src/remote/(remote|qemu)_protocol.[ch] The remote_generate_stubs.pl generated headers with prototypes and dispatch tables for the RPC exposed functions: daemon/(remote|qemu)_dispatch_(args|table|prototypes|ret).h The manually written code corresponding to the generated prototypes for the RPC exposed functions: daemon/remote.c Actually a major part of daemon/remote.c can be moved to generated code, see my pending patch series [1]. [1] https://www.redhat.com/archives/libvir-list/2011-April/msg01075.html Matthias

On Thu, May 05, 2011 at 10:58:38AM +0200, Matthias Bolte wrote:
2011/5/5 Daniel P. Berrange <berrange@redhat.com>:
On Thu, May 05, 2011 at 02:59:39PM +0800, Daniel Veillard wrote:
On Thu, May 05, 2011 at 02:31:57PM +0800, Hu Tao wrote:
On Thu, May 05, 2011 at 08:07:49AM +0200, Matthias Bolte wrote:
2011/5/5 Hu Tao <hutao@cn.fujitsu.com>:
1. this file is automatically generated at compile-time, so rm it to avoid further commit to this file. 2. any update should made to file src/remote/remote_protocol.x. --- daemon/remote_dispatch_table.h | 1054 ---------------------------------------- 1 files changed, 0 insertions(+), 1054 deletions(-) delete mode 100644 daemon/remote_dispatch_table.h
There is probably a reason why this generated file is under version control, maybe Dan knows.
If we decide to remove the generated protocol dispatch header files then we should remove all of them (daemon/remote_dispatch_*.h and daemon/qemu_dispatch_*.h) and not just this single one.
:( doesn't noticed other daemon/remote_dispatch_*.h are also generated ones. Thanks for pointing it out.
Dan, what's your opinion?
my recollection is that they are kept because when compiling on windows we don't have ways to generate them. So while generated, they are kept in git and in the dist tarballs.
There are two generators involved rpcgen + rpcgen_fix.pl (client and daemon side) and remote_generate_stubs.pl (daemon side only).
I'm not sure if the rpcgen that comes with portablexdr (used in my mingw build) comes with a capable rpcgen. Also I'm not sure about cygwin and rpcgen.
We kept them because the rpcgen binary was kind of flakey on some platforms. This may no longer be required, but will need to check
Daniel
I think we're talking about different things here. Thee are several related/generated files:
The manually written XDR protocol definition files: src/remote/(remote|qemu)_protocol.x
The rpcgen generated code for XDR argument and return value struct handling: src/remote/(remote|qemu)_protocol.[ch]
The remote_generate_stubs.pl generated headers with prototypes and dispatch tables for the RPC exposed functions: daemon/(remote|qemu)_dispatch_(args|table|prototypes|ret).h
Opps, yeah, I got the two mixed up. The reason was IIRC, that it was decided that the end user build process shouldn't depend on Perl. IMHO, it is probably about time we just delete all this auto generated code from GIT and depend on Perl + RPCGEN. We can add the files to EXTRA_DIST, so that they are still included in the tar.gz that end users receive.
Actually a major part of daemon/remote.c can be moved to generated code, see my pending patch series [1].
[1] https://www.redhat.com/archives/libvir-list/2011-April/msg01075.html
Could you publish a GIT branch on gitorious[1] I can just pull from. It is easier than saving 30 patches & trying to rebase them to current GIT state Regards, Daniel [1] As a reminder, anyone can publish GIT branches for free on gitorious. We mirror libvirt there every 15 mins, so it can be trivially cloned to create personal staging trees for large patch series: http://gitorious.org/libvirt/libvirt -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

2011/5/5 Daniel P. Berrange <berrange@redhat.com>:
On Thu, May 05, 2011 at 10:58:38AM +0200, Matthias Bolte wrote:
2011/5/5 Daniel P. Berrange <berrange@redhat.com>:
On Thu, May 05, 2011 at 02:59:39PM +0800, Daniel Veillard wrote:
On Thu, May 05, 2011 at 02:31:57PM +0800, Hu Tao wrote:
On Thu, May 05, 2011 at 08:07:49AM +0200, Matthias Bolte wrote:
2011/5/5 Hu Tao <hutao@cn.fujitsu.com>: > 1. this file is automatically generated at compile-time, so rm it > to avoid further commit to this file. > 2. any update should made to file src/remote/remote_protocol.x. > --- > daemon/remote_dispatch_table.h | 1054 ---------------------------------------- > 1 files changed, 0 insertions(+), 1054 deletions(-) > delete mode 100644 daemon/remote_dispatch_table.h >
There is probably a reason why this generated file is under version control, maybe Dan knows.
If we decide to remove the generated protocol dispatch header files then we should remove all of them (daemon/remote_dispatch_*.h and daemon/qemu_dispatch_*.h) and not just this single one.
:( doesn't noticed other daemon/remote_dispatch_*.h are also generated ones. Thanks for pointing it out.
Dan, what's your opinion?
my recollection is that they are kept because when compiling on windows we don't have ways to generate them. So while generated, they are kept in git and in the dist tarballs.
There are two generators involved rpcgen + rpcgen_fix.pl (client and daemon side) and remote_generate_stubs.pl (daemon side only).
I'm not sure if the rpcgen that comes with portablexdr (used in my mingw build) comes with a capable rpcgen. Also I'm not sure about cygwin and rpcgen.
We kept them because the rpcgen binary was kind of flakey on some platforms. This may no longer be required, but will need to check
Daniel
I think we're talking about different things here. Thee are several related/generated files:
The manually written XDR protocol definition files: src/remote/(remote|qemu)_protocol.x
The rpcgen generated code for XDR argument and return value struct handling: src/remote/(remote|qemu)_protocol.[ch]
The remote_generate_stubs.pl generated headers with prototypes and dispatch tables for the RPC exposed functions: daemon/(remote|qemu)_dispatch_(args|table|prototypes|ret).h
Opps, yeah, I got the two mixed up. The reason was IIRC, that it was decided that the end user build process shouldn't depend on Perl.
IMHO, it is probably about time we just delete all this auto generated code from GIT and depend on Perl + RPCGEN. We can add the files to EXTRA_DIST, so that they are still included in the tar.gz that end users receive.
Actually a major part of daemon/remote.c can be moved to generated code, see my pending patch series [1].
[1] https://www.redhat.com/archives/libvir-list/2011-April/msg01075.html
Could you publish a GIT branch on gitorious[1] I can just pull from. It is easier than saving 30 patches & trying to rebase them to current GIT state
Regards, Daniel
Sure, I will do that, probably later today. Matthias

On 05/05/2011 05:02 AM, Daniel P. Berrange wrote:
I think we're talking about different things here. Thee are several related/generated files:
The manually written XDR protocol definition files: src/remote/(remote|qemu)_protocol.x
The rpcgen generated code for XDR argument and return value struct handling: src/remote/(remote|qemu)_protocol.[ch]
Here, there are two questions: 1. do we want a configure-time dependency on rpcgen? If not, then the files must be generated at 'make dist' time. But if so, then question 2 is moot, because the user will always be able to recreate them 2. if the files are generated at 'make dist' time, then are all rpcgen created equal? If so, then we don't need to store the generated files in git (and don't want to, as users with different rpcgen programs will probably cause spurious churn in the generated file). If not, then we absolutely need to store the canonical generated version in git. Off-hand, I think the answer to question 1 is that we do NOT want a configure-time dependency on rpcgen, and therefore the files must be generated prior to 'make dist'. However, for question 2, I'm not yet sure.
The remote_generate_stubs.pl generated headers with prototypes and dispatch tables for the RPC exposed functions: daemon/(remote|qemu)_dispatch_(args|table|prototypes|ret).h
Here, there's only one question: 1. do we want a configure-time dependency on perl? If so, then we should quit generating them. But if not, we already have a 'make dist' dependency on perl (what, you ask? Why, autoconf and automake), so we already require developers to have perl present. Which means we really should change the makefile to ensure the files are generated at 'make dist' time, but quit storing the generated files in git. And my off-hand answer is that we already made configure-time optional for python (modulo my comments [1] that we may have introduced a regression in 0.9.1), so why not keep it optional for perl? [1] https://www.redhat.com/archives/libvir-list/2011-April/msg01273.html
Could you publish a GIT branch on gitorious[1] I can just pull from. It is easier than saving 30 patches & trying to rebase them to current GIT state
Or repo.or.cz also has free access for creating public personal clones: http://repo.or.cz/w/libvirt.git -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org

On Thu, May 05, 2011 at 01:05:43PM -0600, Eric Blake wrote:
On 05/05/2011 05:02 AM, Daniel P. Berrange wrote:
I think we're talking about different things here. Thee are several related/generated files:
The manually written XDR protocol definition files: src/remote/(remote|qemu)_protocol.x
The rpcgen generated code for XDR argument and return value struct handling: src/remote/(remote|qemu)_protocol.[ch]
Here, there are two questions: 1. do we want a configure-time dependency on rpcgen? If not, then the files must be generated at 'make dist' time. But if so, then question 2 is moot, because the user will always be able to recreate them
2. if the files are generated at 'make dist' time, then are all rpcgen created equal? If so, then we don't need to store the generated files in git (and don't want to, as users with different rpcgen programs will probably cause spurious churn in the generated file). If not, then we absolutely need to store the canonical generated version in git.
Off-hand, I think the answer to question 1 is that we do NOT want a configure-time dependency on rpcgen, and therefore the files must be generated prior to 'make dist'. However, for question 2, I'm not yet sure.
The only requirement wrt rpcgen, is that it must be the Linux GLibC rpcgen binary. This is because our post-processing script to fix various compiler warnings only works with the code generated from that. Hence we do not want a configure time use of rpcgen, and should include the generated files in 'make dist'. Since our release tar.gz archives are always generated on a RHEL box, we don't need them in GIT.
The remote_generate_stubs.pl generated headers with prototypes and dispatch tables for the RPC exposed functions: daemon/(remote|qemu)_dispatch_(args|table|prototypes|ret).h
Here, there's only one question: 1. do we want a configure-time dependency on perl? If so, then we should quit generating them. But if not, we already have a 'make dist' dependency on perl (what, you ask? Why, autoconf and automake), so we already require developers to have perl present. Which means we really should change the makefile to ensure the files are generated at 'make dist' time, but quit storing the generated files in git.
Yes, include in make dist, but not in git. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

2011/5/5 Daniel P. Berrange <berrange@redhat.com>:
On Thu, May 05, 2011 at 10:58:38AM +0200, Matthias Bolte wrote:
2011/5/5 Daniel P. Berrange <berrange@redhat.com>:
On Thu, May 05, 2011 at 02:59:39PM +0800, Daniel Veillard wrote:
On Thu, May 05, 2011 at 02:31:57PM +0800, Hu Tao wrote:
On Thu, May 05, 2011 at 08:07:49AM +0200, Matthias Bolte wrote:
2011/5/5 Hu Tao <hutao@cn.fujitsu.com>: > 1. this file is automatically generated at compile-time, so rm it > to avoid further commit to this file. > 2. any update should made to file src/remote/remote_protocol.x. > --- > daemon/remote_dispatch_table.h | 1054 ---------------------------------------- > 1 files changed, 0 insertions(+), 1054 deletions(-) > delete mode 100644 daemon/remote_dispatch_table.h >
There is probably a reason why this generated file is under version control, maybe Dan knows.
If we decide to remove the generated protocol dispatch header files then we should remove all of them (daemon/remote_dispatch_*.h and daemon/qemu_dispatch_*.h) and not just this single one.
:( doesn't noticed other daemon/remote_dispatch_*.h are also generated ones. Thanks for pointing it out.
Dan, what's your opinion?
my recollection is that they are kept because when compiling on windows we don't have ways to generate them. So while generated, they are kept in git and in the dist tarballs.
There are two generators involved rpcgen + rpcgen_fix.pl (client and daemon side) and remote_generate_stubs.pl (daemon side only).
I'm not sure if the rpcgen that comes with portablexdr (used in my mingw build) comes with a capable rpcgen. Also I'm not sure about cygwin and rpcgen.
We kept them because the rpcgen binary was kind of flakey on some platforms. This may no longer be required, but will need to check
Daniel
I think we're talking about different things here. Thee are several related/generated files:
The manually written XDR protocol definition files: src/remote/(remote|qemu)_protocol.x
The rpcgen generated code for XDR argument and return value struct handling: src/remote/(remote|qemu)_protocol.[ch]
The remote_generate_stubs.pl generated headers with prototypes and dispatch tables for the RPC exposed functions: daemon/(remote|qemu)_dispatch_(args|table|prototypes|ret).h
Opps, yeah, I got the two mixed up. The reason was IIRC, that it was decided that the end user build process shouldn't depend on Perl.
IMHO, it is probably about time we just delete all this auto generated code from GIT and depend on Perl + RPCGEN. We can add the files to EXTRA_DIST, so that they are still included in the tar.gz that end users receive.
Actually a major part of daemon/remote.c can be moved to generated code, see my pending patch series [1].
[1] https://www.redhat.com/archives/libvir-list/2011-April/msg01075.html
Could you publish a GIT branch on gitorious[1] I can just pull from. It is easier than saving 30 patches & trying to rebase them to current GIT state
Regards, Daniel
Actually is only 22 patches :) Here you go: https://gitorious.org/~photron/libvirt/photron-libvirt/commits/remotegen The series applied cleanly. Matthias
participants (6)
-
Daniel P. Berrange
-
Daniel Veillard
-
Eric Blake
-
Hu Tao
-
Matthias Bolte
-
Wen Congyang