On 03/28/2016 07:36 PM, Chun Yan Liu wrote:

Reviewed-by: Chunyan Liu <cyliu@suse.com>

Thanks for taking a look! I'm going to push this series since it just splits your previous patch, which I'm happy to ACK after the split :-). It is a nice cleanup and plugs potential resource leaks, so good stuff for the 1.3.3 release. Regards, Jim

...

...

...

On 3/29/2016 at 08:54 AM, in message <1459212889-5490-4-git-send-email-jfehlig@suse.com>, Jim Fehlig <jfehlig@suse.com> wrote: Remove disabling domain death events from libxlDomainStart error path. The domain death event is already disabled in libxlDomainCleanup.

Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- src/libxl/libxl_domain.c | 4 ---- 1 file changed, 4 deletions(-)

diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 068bfb6..04962a0 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -1144,10 +1144,6 @@ libxlDomainStart(libxlDriverPrivatePtr driver, virDomainObjPtr vm,

destroy_dom: ret = -1; - if (priv->deathW) { - libxl_evdisable_domain_death(cfg->ctx, priv->deathW); - priv->deathW = NULL; - } libxlDomainDestroyInternal(driver, vm); vm->def->id = -1; virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, VIR_DOMAIN_SHUTOFF_FAILED);