On Thu, Apr 18, 2019 at 02:22:46PM +0200, Michal Privoznik wrote:

Now that libvirt has firmware auto selection feature the nvram config knob is more or less obsolete. It still makes sense in cases where distro users are using does not provide FW descriptor files, therefore I'm not removing it.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/qemu/qemu.conf | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 334b4cd4ee..ecde8f0181 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -740,6 +740,8 @@

# Location of master nvram file # +# This is now obsoleted by firmware auto selection feature. +# Prefer that before this.

I think we could be a bit more verbose "This configuration option is obsolete. Libvirt will follow the QEMU firmware metadata specification to automatically locate firmware images: https://git.qemu.org/gitweb.cgi?p=qemu.git;a=blob_plain;f=docs/interop/firmw... These metadata files are distributed alongside any firmware images intended for use with QEMU."

# When a domain is configured to use UEFI instead of standard # BIOS it may use a separate storage for UEFI variables. If # that's the case libvirt creates the variable store per domain

Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|