[libvirt] VirtualBox error message displayed on windows
Hi Matthias, Just came across an interesting (non fatal) bug with the new VirtualBox code on windows. When starting virsh on a windows system that *doesn't* have VirtualBox installed, virsh prints an error to the users terminal about missing VirtualBox registry keys, then continues on with it's intended operation. (screenshot attached) It's not a killer, but the error makes no sense in context when I'm (for example) trying to connect to a remote qemu box. Heh. Feel inclined to write a patch for it? Regards and best wishes, Justin Clift
2011/1/8 Justin Clift <jclift@redhat.com>:
Hi Matthias,
Just came across an interesting (non fatal) bug with the new VirtualBox code on windows.
When starting virsh on a windows system that *doesn't* have VirtualBox installed, virsh prints an error to the users terminal about missing VirtualBox registry keys, then continues on with it's intended operation. (screenshot attached)
It's not a killer, but the error makes no sense in context when I'm (for example) trying to connect to a remote qemu box. Heh.
Feel inclined to write a patch for it?
Shows that I didn't test this on a Windows system without VirtualBox :( That log message should be relaxed to info or debug level or even be removed entirely as this is not error at all, as it just means that VirtualBox is not installed. I'll remove this line entirely. This will result in the same behavior for the XPCOM and MSCOM glue when VirtualBox is not installed. VBoxCGlueInit fails silently making vboxRegister registering the dummy driver. Matthias
On 11/01/2011, at 1:05 AM, Matthias Bolte wrote:
Shows that I didn't test this on a Windows system without VirtualBox :(
That log message should be relaxed to info or debug level or even be removed entirely as this is not error at all, as it just means that VirtualBox is not installed.
I'll remove this line entirely. This will result in the same behavior for the XPCOM and MSCOM glue when VirtualBox is not installed. VBoxCGlueInit fails silently making vboxRegister registering the dummy driver.
No worries. I'll try out adding the patch to the libvirt 0.8.7 patch files in your msys build scripts. Thinking it should work, and if it does then it's suitable for direct inclusion in the 0.8.7 win32 installer. :)
participants (2)
-
Justin Clift -
Matthias Bolte