On Thu, Mar 12, 2020 at 15:17:32 +0800, Zhenyu Ye wrote: Hi, this unfortunately is far from complete. You'll need to provide: - XML schema additions (docs/schemas/domaincommon.rng) - documentation (docs/formatdomain.html.in) - a qemu capability flag to check whether it's supported: (src/qemu/qemu_capabilities.c/h), you can use the QAPI capability query string to check it: blockdev-add/arg-type/+file/aio/^io_uring - a validation entry to reject config if the above capability is not present (qemuDomainValidateStorageSource src/qemu/qemu_domain.c) - a test case for at least qemuxml2argv and qemuxml2xmltest, enhancing existing test files is okay (tests/qemuxml2argvdata), the test case must show that the appropriate qemu command line is generated Please split the above additions to patches at least: - src/conf/ and docs/ additions - src/qemu/qemu_capabilities additions - validation additions - tests and please follow the contributor guidelines. Specifically the part tha the whole tree must compile cleanly after every patch so the changes must be split properly.