On Wed, Dec 23, 2009 at 04:29:06AM +0100, Matthias Bolte wrote:

MinGW's ld gives an error when trying to export undefined symbols. --- src/libvirt_private.syms | 4 ---- src/util/network.h | 4 ---- 2 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 31c944c..10940eb 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -362,7 +362,6 @@ virFree;

# network.h -virSocketAddrInNetwork; virSocketAddrIsNetmask; virSocketCheckNetmask; virSocketFormatAddr; @@ -435,8 +434,6 @@ pciDeviceListDel; pciDeviceFileIterate; pciDeviceListCount; pciDeviceListGet; -pciDeviceListLock; -pciDeviceListUnlock; pciDeviceListSteal;

@@ -503,7 +500,6 @@ virStoragePoolObjUnlock;

# storage_encryption_conf.h virStorageEncryptionFree; -virStorageEncryptionDropSecrets; virStorageEncryptionParseNode; virStorageEncryptionFormat; virStorageGenerateQcowPassphrase; diff --git a/src/util/network.h b/src/util/network.h index 3762ef2..d5c2c9b 100644 --- a/src/util/network.h +++ b/src/util/network.h @@ -40,10 +40,6 @@ int virSocketSetPort(virSocketAddrPtr addr, int port);

int virSocketGetPort(virSocketAddrPtr addr);

-int virSocketAddrInNetwork(virSocketAddrPtr addr1, - virSocketAddrPtr addr2, - virSocketAddrPtr netmask); - int virSocketGetRange (virSocketAddrPtr start, virSocketAddrPtr end);

ACK, I wonder how we could automate the check that all private entry points are actually exported internally, maybe a check rule based on nm | grep " T " outpur for the libs... Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/