5:08 a.m.
When libvirt is compiled without yajl-devel, virnetdaemontest fails.
This causes 'make check' to fail with nondescript errors, such as following:
[snip]...............................
PASS: read-bufsiz
PASS: read-non-seekable
PASS: start
TEST: virsh-uriprecedence
.... 4 OK
PASS: virsh-uriprecedence
PASS: vcpupin
/home/prerna/trees/libvirt/tests/virsh-all: skipping test:
This test is very expensive, so it is disabled by default.
To run it anyway, rerun: make check VIR_TEST_EXPENSIVE=1
SKIP: virsh-all
PASS: virsh-optparse
PASS: virsh-schedinfo
PASS: virsh-synopsis
PASS: virsh-undefine
=======================================
1 of 108 tests failed
(7 tests were not run)
Please report to libvir-list(a)redhat.com
=======================================
make[2]: *** [check-TESTS] Error 1
make[2]: Leaving directory `/home/prerna/build/libvirt/tests'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/home/prerna/build/libvirt/tests'
make: *** [check-recursive] Error 1
.....................................
This patch skips virnetdaemontest in absence of yajl-devel, so that
make check gracefully runs to completion.
Signed-off-by: Prerna Saxena <saxenap.ltc(a)gmail.com>
---
tests/virnetdaemontest.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/tests/virnetdaemontest.c b/tests/virnetdaemontest.c
index 24cbd54..17d1f7f 100644
--- a/tests/virnetdaemontest.c
+++ b/tests/virnetdaemontest.c
@@ -290,6 +290,11 @@ mymain(void)
{
int ret = 0;
+#if !WITH_YAJL
+ fputs("libvirt not compiled with yajl, skipping this test\n", stderr);
+ return EXIT_AM_SKIP;
+#endif
+
if (virInitialize() < 0 ||
virEventRegisterDefaultImpl() < 0) {
virDispatchError(NULL);
--
1.7.1
7:24 a.m.
On Fri, Oct 23, 2015 at 15:38:25 +0530, Prerna wrote:
When libvirt is compiled without yajl-devel, virnetdaemontest fails.
This causes 'make check' to fail with nondescript errors, such as following:
[snip]...............................
PASS: read-bufsiz
PASS: read-non-seekable
PASS: start
TEST: virsh-uriprecedence
.... 4 OK
PASS: virsh-uriprecedence
PASS: vcpupin
/home/prerna/trees/libvirt/tests/virsh-all: skipping test:
This test is very expensive, so it is disabled by default.
To run it anyway, rerun: make check VIR_TEST_EXPENSIVE=1
SKIP: virsh-all
PASS: virsh-optparse
PASS: virsh-schedinfo
PASS: virsh-synopsis
PASS: virsh-undefine
=======================================
1 of 108 tests failed
(7 tests were not run)
Please report to libvir-list(a)redhat.com
=======================================
make[2]: *** [check-TESTS] Error 1
make[2]: Leaving directory `/home/prerna/build/libvirt/tests'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/home/prerna/build/libvirt/tests'
make: *** [check-recursive] Error 1
The above output does not contain the actual failure. Please post the
relevant part.
Peter
11:19 a.m.
Here is the more verbose failure snippet :
..[snip]
TEST: virnetdaemontest
1) ExecRestart initial-nomdns ...
libvirt: error : internal error: No JSON parser implementation is available
libvirt: error : internal error: No JSON parser implementation is available
FAILED
2) ExecRestart anon-clients ...
libvirt: error : internal error: No JSON parser implementation is available
libvirt: error : internal error: No JSON parser implementation is available
FAILED
3) ExecRestart anon-clients ...
libvirt: error : internal error: No JSON parser implementation is available
FAILED
4) ExecRestart admin-nomdns ...
libvirt: error : internal error: No JSON parser implementation is available
libvirt: error : internal error: No JSON parser implementation is available
FAILED
FAIL: virnetdaemontest
...
On Fri, Oct 23, 2015 at 5:54 PM, Peter Krempa <pkrempa(a)redhat.com> wrote:
On Fri, Oct 23, 2015 at 15:38:25 +0530, Prerna wrote:
> When libvirt is compiled without yajl-devel, virnetdaemontest fails.
> This causes 'make check' to fail with nondescript errors, such as
following:
> [snip]...............................
> PASS: read-bufsiz
> PASS: read-non-seekable
> PASS: start
> TEST: virsh-uriprecedence
> .... 4 OK
> PASS: virsh-uriprecedence
> PASS: vcpupin
> /home/prerna/trees/libvirt/tests/virsh-all: skipping test:
> This test is very expensive, so it is disabled by default.
> To run it anyway, rerun: make check VIR_TEST_EXPENSIVE=1
>
> SKIP: virsh-all
> PASS: virsh-optparse
> PASS: virsh-schedinfo
> PASS: virsh-synopsis
> PASS: virsh-undefine
> =======================================
> 1 of 108 tests failed
> (7 tests were not run)
> Please report to libvir-list(a)redhat.com
> =======================================
> make[2]: *** [check-TESTS] Error 1
> make[2]: Leaving directory `/home/prerna/build/libvirt/tests'
> make[1]: *** [check-am] Error 2
> make[1]: Leaving directory `/home/prerna/build/libvirt/tests'
> make: *** [check-recursive] Error 1
The above output does not contain the actual failure. Please post the
relevant part.
Peter
12:44 a.m.
Ping !
Do you want me to resend the patch including this error in the commit msg ?
Regards,
Prerna
On Fri, Oct 23, 2015 at 9:49 PM, Prerna <saxenap.ltc(a)gmail.com> wrote:
Here is the more verbose failure snippet :
..[snip]
TEST: virnetdaemontest
1) ExecRestart initial-nomdns ...
libvirt: error : internal error: No JSON parser implementation is available
libvirt: error : internal error: No JSON parser implementation is
available
FAILED
2) ExecRestart anon-clients ...
libvirt: error : internal error: No JSON parser implementation is available
libvirt: error : internal error: No JSON parser implementation is
available
FAILED
3) ExecRestart anon-clients ...
libvirt: error : internal error: No JSON parser implementation is available
FAILED
4) ExecRestart admin-nomdns ...
libvirt: error : internal error: No JSON parser implementation is available
libvirt: error : internal error: No JSON parser implementation is
available
FAILED
FAIL: virnetdaemontest
...
On Fri, Oct 23, 2015 at 5:54 PM, Peter Krempa <pkrempa(a)redhat.com> wrote:
> On Fri, Oct 23, 2015 at 15:38:25 +0530, Prerna wrote:
> > When libvirt is compiled without yajl-devel, virnetdaemontest fails.
> > This causes 'make check' to fail with nondescript errors, such as
> following:
> > [snip]...............................
> > PASS: read-bufsiz
> > PASS: read-non-seekable
> > PASS: start
> > TEST: virsh-uriprecedence
> > .... 4 OK
> > PASS: virsh-uriprecedence
> > PASS: vcpupin
> > /home/prerna/trees/libvirt/tests/virsh-all: skipping test:
> > This test is very expensive, so it is disabled by default.
> > To run it anyway, rerun: make check VIR_TEST_EXPENSIVE=1
> >
> > SKIP: virsh-all
> > PASS: virsh-optparse
> > PASS: virsh-schedinfo
> > PASS: virsh-synopsis
> > PASS: virsh-undefine
> > =======================================
> > 1 of 108 tests failed
> > (7 tests were not run)
> > Please report to libvir-list(a)redhat.com
> > =======================================
> > make[2]: *** [check-TESTS] Error 1
> > make[2]: Leaving directory `/home/prerna/build/libvirt/tests'
> > make[1]: *** [check-am] Error 2
> > make[1]: Leaving directory `/home/prerna/build/libvirt/tests'
> > make: *** [check-recursive] Error 1
>
> The above output does not contain the actual failure. Please post the
> relevant part.
>
> Peter
>
3314
days inactive
3318
days old
3 comments
2 participants
participants (2)
-
Peter Krempa -
Prerna