[libvirt] [PATCH] docs: remove duplicate example usegae of nvdimm

original: <devices> <memory model='nvdimm'> ... </memory> <memory model='nvdimm'> ... </memory> </devices> merge two examples above into one: <devices> <memory model='nvdimm'> ... </memory> </devices> Signed-off-by: Luyao Zhong <luyao.zhong@intel.com> --- docs/formatdomain.html.in | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 7f07bb7..3641e3b 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -8323,19 +8323,6 @@ qemu-kvm -net nic,model=? /dev/null <source> <path>/tmp/nvdimm</path> <alignsize unit='KiB'>2048</alignsize> - </source> - <target> - <size unit='KiB'>524288</size> - <node>1</node> - <label> - <size unit='KiB'>128</size> - </label> - <readonly/> - </target> - </memory> - <memory model='nvdimm'> - <source> - <path>/dev/dax0.0</path> <pmem/> </source> <target> @@ -8344,6 +8331,7 @@ qemu-kvm -net nic,model=? /dev/null <label> <size unit='KiB'>128</size> </label> + <readonly/> </target> </memory> </devices> -- 2.7.4

On Wed, Jan 16, 2019 at 14:58:21 +0800, Luyao Zhong wrote:
original: <devices> <memory model='nvdimm'> ... </memory> <memory model='nvdimm'> ... </memory> </devices>
merge two examples above into one: <devices> <memory model='nvdimm'> ... </memory> </devices>
Signed-off-by: Luyao Zhong <luyao.zhong@intel.com>
What's the benefit of the above change? We have multiple instances where we show different configurations so I don't see a need to squash every option together.

On 2019/1/16 下午4:16, Peter Krempa wrote:
On Wed, Jan 16, 2019 at 14:58:21 +0800, Luyao Zhong wrote:
original: <devices> <memory model='nvdimm'> ... </memory> <memory model='nvdimm'> ... </memory> </devices>
merge two examples above into one: <devices> <memory model='nvdimm'> ... </memory> </devices>
Signed-off-by: Luyao Zhong <luyao.zhong@intel.com>
What's the benefit of the above change? We have multiple instances where we show different configurations so I don't see a need to squash every option together.
Thank you for your reply. I modify this because the two different instances may mislead people to think these are two mutually exclusive way to configure NVDIMM. Besides, one example is enough to show all configurations and the description bellow give the details. Actually I thought it is a bug, because there was only one instance. I added several options for the NVDIMM before but don't know why the one instance was divided into two. :) Thanks, Luyao
participants (2)
-
Luyao Zhong
-
Peter Krempa