[libvirt] [PATCH] Add a couple of debug statements to LXC driver

From: "Daniel P. Berrange" <berrange@redhat.com> When failing to start a container due to inaccessible root filesystem path, we did not log any meaningful error. Add a few debug statements to assist diagnosis Pushed under trivial rule Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/lxc/lxc_container.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index fcd9b74..940233b 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -1762,6 +1762,8 @@ static int lxcContainerSetupPivotRoot(virDomainDefPtr vmDef, char *sec_mount_options; char *stateDir = NULL; + VIR_DEBUG("Setup pivot root"); + if (!(sec_mount_options = virSecurityManagerGetMountOptions(securityDriver, vmDef))) return -1; @@ -1864,12 +1866,16 @@ static int lxcContainerResolveSymlinks(virDomainDefPtr vmDef) char *newroot; size_t i; + VIR_DEBUG("Resolving symlinks"); + for (i = 0; i < vmDef->nfss; i++) { virDomainFSDefPtr fs = vmDef->fss[i]; if (!fs->src) continue; - if (virFileResolveAllLinks(fs->src, &newroot) < 0) + if (virFileResolveAllLinks(fs->src, &newroot) < 0) { + VIR_DEBUG("Fail to resolve link %s", fs->src); return -1; + } VIR_DEBUG("Resolved '%s' to %s", fs->src, newroot); -- 1.8.3.1

On 07/12/2013 06:06 PM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
When failing to start a container due to inaccessible root filesystem path, we did not log any meaningful error. Add a few debug statements to assist diagnosis
Pushed under trivial rule
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> ---
ACK Thanks.
participants (2)
-
Daniel P. Berrange
-
Gao feng