[libvirt] [PATCH] [docs] Fix sample TPM XML
Fix an error in the sample TPM XML. Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: libvirt-acl/docs/formatdomain.html.in =================================================================== --- libvirt-acl.orig/docs/formatdomain.html.in +++ libvirt-acl/docs/formatdomain.html.in @@ -4735,7 +4735,7 @@ qemu-kvm -net nic,model=? /dev/null <devices> <tpm model='tpm-tis'> <backend type='passthrough'> - <backend path='/dev/tpm0'/> + <device path='/dev/tpm0'/> </backend> </tpm> </devices>
On 06/26/2013 12:53 PM, Stefan Berger wrote:
Fix an error in the sample TPM XML.
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
--- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: libvirt-acl/docs/formatdomain.html.in =================================================================== --- libvirt-acl.orig/docs/formatdomain.html.in +++ libvirt-acl/docs/formatdomain.html.in @@ -4735,7 +4735,7 @@ qemu-kvm -net nic,model=? /dev/null <devices> <tpm model='tpm-tis'> <backend type='passthrough'> - <backend path='/dev/tpm0'/> + <device path='/dev/tpm0'/> </backend> </tpm> </devices>
ACK A few lines below the source element is mentioned instead of device, you might want to fix that too: backend type='passthrough' This backend type requires exclusive access to a TPM device on the host. An example for such a device is /dev/tpm0. The filename is specified as path attribute of the source element. If no file name is specified then /dev/tpm0 is automatically used. Jan
On 06/26/2013 07:02 AM, Ján Tomko wrote:
On 06/26/2013 12:53 PM, Stefan Berger wrote:
Fix an error in the sample TPM XML.
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
--- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: libvirt-acl/docs/formatdomain.html.in =================================================================== --- libvirt-acl.orig/docs/formatdomain.html.in +++ libvirt-acl/docs/formatdomain.html.in @@ -4735,7 +4735,7 @@ qemu-kvm -net nic,model=? /dev/null <devices> <tpm model='tpm-tis'> <backend type='passthrough'> - <backend path='/dev/tpm0'/> + <device path='/dev/tpm0'/> </backend> </tpm> </devices>
ACK
A few lines below the source element is mentioned instead of device, you might want to fix that too:
backend type='passthrough'
This is still correct. It's the <backend path= /> that was wrong. Stefan
This backend type requires exclusive access to a TPM device on the host. An example for such a device is /dev/tpm0. The filename is specified as path attribute of the source element. If no file name is specified then /dev/tpm0 is automatically used.
Jan
On 06/26/2013 02:12 PM, Stefan Berger wrote:
On 06/26/2013 07:02 AM, Ján Tomko wrote:
On 06/26/2013 12:53 PM, Stefan Berger wrote:
Fix an error in the sample TPM XML.
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
--- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
A few lines below the source element is mentioned instead of device, you might want to fix that too:
backend type='passthrough'
This is still correct. It's the <backend path= /> that was wrong.
Stefan
This backend type requires exclusive access to a TPM device on the host. An example for such a device is /dev/tpm0. The filename is specified as path attribute of the source element. If no file name is specified then /dev/tpm0
I meant here ^^^^^^
is automatically used.
Jan
participants (2)
-
Ján Tomko -
Stefan Berger