[libvirt] Entering freeze for libvirt-0.9.13
I just tagged the git tree and I pushed the tarball for rc1: ftp://libvirt.org/libvirt/libvirt-0.9.13-rc1.tar.gz the rpms I build are coming along soon. Please give it a try, the basic seems okay to me (kvm driver seems to need the qemu one now but otherwise, no surprize so far) Give it a try too, and let's find if there are portability issues too ! I think i would make an rc2 release on wed or thursday, and then if everything is fine the release next week-end or on Monday. thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
I just tagged the git tree and I pushed the tarball for rc2: ftp://libvirt.org/libvirt/libvirt-0.9.13-rc2.tar.gz the rpms are being built and will be pushed soon too I didn't get any feedback on other platforms or OSes for rc1, hopefully this will get a bit of testing before the actual release, probably on Monday early next week. thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
Daniel Veillard wrote:
I just tagged the git tree and I pushed the tarball for rc2: ftp://libvirt.org/libvirt/libvirt-0.9.13-rc2.tar.gz
the rpms are being built and will be pushed soon too I didn't get any feedback on other platforms or OSes for rc1, hopefully this will get a bit of testing before the actual release, probably on Monday early next week.
No problems noted with standard builds in the openSUSE build service https://build.opensuse.org/package/show?package=libvirt&project=home%3Ajfehlig Same for SLES builds on the internal build service, which includes more architectures. Regards, Jim
On Thu, Jun 28, 2012 at 5:36 AM, Daniel Veillard <veillard@redhat.com> wrote:
I just tagged the git tree and I pushed the tarball for rc2: ftp://libvirt.org/libvirt/libvirt-0.9.13-rc2.tar.gz
Builds fine on OSX Lion. Regards, Ruben
On Fri, Jun 29, 2012 at 10:27:22PM +0200, Ruben Kerkhof thus spake:
On Thu, Jun 28, 2012 at 5:36 AM, Daniel Veillard <veillard@redhat.com> wrote:
I just tagged the git tree and I pushed the tarball for rc2: ftp://libvirt.org/libvirt/libvirt-0.9.13-rc2.tar.gz
Builds fine on OSX Lion.
Regards,
Ruben
FreeBSD fails on this here: include-dirs -Wunused -Wunknown-pragmas -Wstrict-aliasing -Wshadow -Wpointer-arith -Wbad-function-cast -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Wnested-externs -Winline -Winvalid-pch -Wvolatile-register-var -Wdisabled-optimization -Wattributes -Wdeprecated-declarations -Wdiv-by-zero -Wendif-labels -Wextra -Wformat-extra-args -Wformat-zero-length -Wformat=2 -Wmultichar -Wnormalized=nfc -Woverflow -Wpointer-to-int-cast -Wpragmas -Wtrampolines -Wno-missing-field-initializers -Wno-sign-compare -Wno-format-nonliteral -fexceptions -fasynchronous-unwind-tables -fdiagnostics-show-option -funit-at-a-time -fipa-pure-const -O2 -pipe -fno-strict-aliasing -MT libvirt_conf_la-domain_conf.lo -MD -MP -MF .deps/libvirt_conf_la-domain_conf.Tpo -c conf/domain_conf.c -fPIC -DPIC -o .libs/libvirt_conf_la-domain_conf.o conf/domain_conf.c: In function 'virDomainDiskDefParseXML': conf/domain_conf.c:3662: warning: null format string [-Wformat] conf/domain_conf.c:3679: warning: null format string [-Wformat] conf/domain_conf.c: In function 'virDomainFSDefParseXML': conf/domain_conf.c:4252: error: 'ULONG_LONG_MAX' undeclared (first use in this function) conf/domain_conf.c:4252: error: (Each undeclared identifier is reported only once conf/domain_conf.c:4252: error: for each function it appears in.) conf/domain_conf.c:4314: warning: null format string [-Wformat] conf/domain_conf.c:4320: warning: null format string [-Wformat] conf/domain_conf.c: In function 'virDomainDefParseXML': conf/domain_conf.c:7982: warning: null format string [-Wformat] gmake[3]: *** [libvirt_conf_la-domain_conf.lo] Error 1 gmake[3]: Leaving directory `/usr/local/workspace/ports/devel/libvirt/work/libvirt-0.9.13/src' gmake[2]: *** [all] Error 2 gmake[2]: Leaving directory `/usr/local/workspace/ports/devel/libvirt/work/libvirt-0.9.13/src' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/usr/local/workspace/ports/devel/libvirt/work/libvirt-0.9.13' gmake: *** [all] Error 2 *** Error code 1 -jgh -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5
On 06/29/2012 02:47 PM, Jason Helfman wrote:
FreeBSD fails on this here:
conf/domain_conf.c: In function 'virDomainFSDefParseXML': conf/domain_conf.c:4252: error: 'ULONG_LONG_MAX' undeclared (first use in this function)
POSIX requires <limits.h> to spell it ULLONG_MAX, not ULONG_LONG_MAX. We've got a bug in our code for using the non-standard name; I'll propose a patch soon. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On Fri, Jun 29, 2012 at 03:07:52PM -0600, Eric Blake thus spake:
On 06/29/2012 02:47 PM, Jason Helfman wrote:
FreeBSD fails on this here:
conf/domain_conf.c: In function 'virDomainFSDefParseXML': conf/domain_conf.c:4252: error: 'ULONG_LONG_MAX' undeclared (first use in this function)
POSIX requires <limits.h> to spell it ULLONG_MAX, not ULONG_LONG_MAX. We've got a bug in our code for using the non-standard name; I'll propose a patch soon.
Here is a link to the build logs with the patch: https://redports.org/buildarchive/20120630004335-48297/ - -jgh - -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iF4EAREIAAYFAk/uTW0ACgkQXpKtZoyM+6X4swD+Ib387L0WgF0VumhmWRxBHb6Y xXr3aYw6bheKGv0BopcA/jJjNhnBgXzeLUvbNmthcOt5n+uTTnXDKYQpd3eEDMvQ =sIXU -----END PGP SIGNATURE-----
Reported by Jason Helfman as a build-breaker on FreeBSD. * src/conf/domain_conf.c (virDomainFSDefParseXML): Use POSIX spelling. * src/openvz/openvz_conf.c (openvzReadFSConf): Likewise. --- Pushing under the build-breaker rule. src/conf/domain_conf.c | 8 +++----- src/openvz/openvz_conf.c | 4 ++-- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4086dac..3fb90db 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4248,14 +4248,12 @@ virDomainFSDefParseXML(xmlNodePtr node, if (virDomainParseScaledValue("./space_hard_limit[1]", ctxt, &def->space_hard_limit, 1, - ULONG_LONG_MAX, - false) < 0) + ULLONG_MAX, false) < 0) goto error; if (virDomainParseScaledValue("./space_soft_limit[1]", ctxt, &def->space_soft_limit, 1, - ULONG_LONG_MAX, - false) < 0) + ULLONG_MAX, false) < 0) goto error; cur = node->children; @@ -4335,7 +4333,7 @@ virDomainFSDefParseXML(xmlNodePtr node, } if (unit && virScaleInteger(&def->usage, unit, - 1024, ULONG_LONG_MAX) < 0) + 1024, ULLONG_MAX) < 0) goto error; } diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index bb61b13..ad27d37 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -455,8 +455,8 @@ openvzReadFSConf(virDomainDefPtr def, goto error; } else { /* Ensure that we can multiply by 1024 without overflowing. */ - if (barrier > ULONG_LONG_MAX / 1024 || - limit > ULONG_LONG_MAX / 1024 ) { + if (barrier > ULLONG_MAX / 1024 || + limit > ULLONG_MAX / 1024 ) { virReportSystemError(VIR_ERR_OVERFLOW, _("%s"), "Unable to parse quota"); -- 1.7.10.4
On Fri, Jun 29, 2012 at 03:11:41PM -0600, Eric Blake thus spake:
Reported by Jason Helfman as a build-breaker on FreeBSD.
Patch is good. It builds, now. Thanks! -jgh -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5
On Fri, Jun 29, 2012 at 03:11:41PM -0600, Eric Blake wrote:
Reported by Jason Helfman as a build-breaker on FreeBSD.
* src/conf/domain_conf.c (virDomainFSDefParseXML): Use POSIX spelling. * src/openvz/openvz_conf.c (openvzReadFSConf): Likewise. ---
Pushing under the build-breaker rule.
src/conf/domain_conf.c | 8 +++----- src/openvz/openvz_conf.c | 4 ++-- 2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4086dac..3fb90db 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4248,14 +4248,12 @@ virDomainFSDefParseXML(xmlNodePtr node,
if (virDomainParseScaledValue("./space_hard_limit[1]", ctxt, &def->space_hard_limit, 1, - ULONG_LONG_MAX, - false) < 0) + ULLONG_MAX, false) < 0) goto error;
if (virDomainParseScaledValue("./space_soft_limit[1]", ctxt, &def->space_soft_limit, 1, - ULONG_LONG_MAX, - false) < 0) + ULLONG_MAX, false) < 0) goto error;
cur = node->children; @@ -4335,7 +4333,7 @@ virDomainFSDefParseXML(xmlNodePtr node, } if (unit && virScaleInteger(&def->usage, unit, - 1024, ULONG_LONG_MAX) < 0) + 1024, ULLONG_MAX) < 0) goto error; }
diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index bb61b13..ad27d37 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -455,8 +455,8 @@ openvzReadFSConf(virDomainDefPtr def, goto error; } else { /* Ensure that we can multiply by 1024 without overflowing. */ - if (barrier > ULONG_LONG_MAX / 1024 || - limit > ULONG_LONG_MAX / 1024 ) { + if (barrier > ULLONG_MAX / 1024 || + limit > ULLONG_MAX / 1024 ) { virReportSystemError(VIR_ERR_OVERFLOW, _("%s"), "Unable to parse quota"); Ack. -- Guido
On Fri, Jun 29, 2012 at 03:11:41PM -0600, Eric Blake wrote:
Reported by Jason Helfman as a build-breaker on FreeBSD.
* src/conf/domain_conf.c (virDomainFSDefParseXML): Use POSIX spelling. * src/openvz/openvz_conf.c (openvzReadFSConf): Likewise. ---
Pushing under the build-breaker rule.
src/conf/domain_conf.c | 8 +++----- src/openvz/openvz_conf.c | 4 ++-- 2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4086dac..3fb90db 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4248,14 +4248,12 @@ virDomainFSDefParseXML(xmlNodePtr node,
if (virDomainParseScaledValue("./space_hard_limit[1]", ctxt, &def->space_hard_limit, 1, - ULONG_LONG_MAX, - false) < 0) + ULLONG_MAX, false) < 0) goto error;
if (virDomainParseScaledValue("./space_soft_limit[1]", ctxt, &def->space_soft_limit, 1, - ULONG_LONG_MAX, - false) < 0) + ULLONG_MAX, false) < 0) goto error;
cur = node->children; @@ -4335,7 +4333,7 @@ virDomainFSDefParseXML(xmlNodePtr node, } if (unit && virScaleInteger(&def->usage, unit, - 1024, ULONG_LONG_MAX) < 0) + 1024, ULLONG_MAX) < 0) goto error; }
diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index bb61b13..ad27d37 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -455,8 +455,8 @@ openvzReadFSConf(virDomainDefPtr def, goto error; } else { /* Ensure that we can multiply by 1024 without overflowing. */ - if (barrier > ULONG_LONG_MAX / 1024 || - limit > ULONG_LONG_MAX / 1024 ) { + if (barrier > ULLONG_MAX / 1024 || + limit > ULLONG_MAX / 1024 ) { virReportSystemError(VIR_ERR_OVERFLOW, _("%s"), "Unable to parse quota");
Probably worth blacklisting the non-portable spelling with syntax-check Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Wed, Jun 27, 2012 at 10:36 PM, Daniel Veillard <veillard@redhat.com> wrote:
I just tagged the git tree and I pushed the tarball for rc2: ftp://libvirt.org/libvirt/libvirt-0.9.13-rc2.tar.gz
the rpms are being built and will be pushed soon too I didn't get any feedback on other platforms or OSes for rc1, hopefully this will get a bit of testing before the actual release, probably on Monday early next week.
thanks !
Daniel
Build fine on Gentoo, however it fails a test. Here's the stdout from the overall run, I'll dig in deeper over the weekend. TEST: virdrivermoduletest ....!!. 7 FAIL -- Doug Goldstein
On Mon, Jun 25, 2012 at 07:20:59PM +0800, Daniel Veillard wrote:
I just tagged the git tree and I pushed the tarball for rc1: ftp://libvirt.org/libvirt/libvirt-0.9.13-rc1.tar.gz
the rpms I build are coming along soon. Please give it a try, the basic seems okay to me (kvm driver seems to need the qemu one now but otherwise, no surprize so far) Give it a try too, and let's find if there are portability issues too ! I think i would make an rc2 release on wed or thursday, and then if everything is fine the release next week-end or on Monday.
Build looks good so far on the Debian Buildds: https://buildd.debian.org/status/package.php?p=libvirt&suite=experimental Cheers, -- Guido
On Fri, Jun 29, 2012 at 11:15:02AM +0200, Guido Günther wrote:
On Mon, Jun 25, 2012 at 07:20:59PM +0800, Daniel Veillard wrote:
I just tagged the git tree and I pushed the tarball for rc1: ftp://libvirt.org/libvirt/libvirt-0.9.13-rc1.tar.gz
the rpms I build are coming along soon. Please give it a try, the basic seems okay to me (kvm driver seems to need the qemu one now but otherwise, no surprize so far) Give it a try too, and let's find if there are portability issues too ! I think i would make an rc2 release on wed or thursday, and then if everything is fine the release next week-end or on Monday.
Build looks good so far on the Debian Buildds:
https://buildd.debian.org/status/package.php?p=libvirt&suite=experimental
Thanks Guido ! at least the s390 patches didn't break code portability :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (8)
-
Daniel P. Berrange -
Daniel Veillard -
Doug Goldstein -
Eric Blake -
Guido Günther -
Jason Helfman -
Jim Fehlig -
Ruben Kerkhof