[libvirt] [PATCH] Fix typo in configure.ac causing $LIBS to gain a copy of $CFLAGS
From: "Daniel P. Berrange" <berrange@redhat.com> The virt-dbus.m4 check for DBus was preserving $LIBS before modifying it. Except it wasn't. It was preserving another copy of $CFLAGS. The result was that after the check completed, $LIBS got polluted with $CFLAGS Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- m4/virt-dbus.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-dbus.m4 b/m4/virt-dbus.m4 index 16cb864..4ef0c82 100644 --- a/m4/virt-dbus.m4 +++ b/m4/virt-dbus.m4 @@ -22,7 +22,7 @@ AC_DEFUN([LIBVIRT_CHECK_DBUS],[ if test "$with_dbus" = "yes" ; then old_CFLAGS="$CFLAGS" - old_LIBS="$CFLAGS" + old_LIBS="$LIBS" CFLAGS="$CFLAGS $DBUS_CFLAGS" LIBS="$LIBS $DBUS_LIBS" AC_CHECK_FUNCS([dbus_watch_get_unix_fd]) -- 1.7.11.7
On 02/05/2013 09:46 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
The virt-dbus.m4 check for DBus was preserving $LIBS before modifying it. Except it wasn't. It was preserving another copy of $CFLAGS. The result was that after the check completed, $LIBS got polluted with $CFLAGS
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- m4/virt-dbus.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Tue, Feb 05, 2013 at 16:46:20 +0000, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
The virt-dbus.m4 check for DBus was preserving $LIBS before modifying it. Except it wasn't. It was preserving another copy of $CFLAGS. The result was that after the check completed, $LIBS got polluted with $CFLAGS
ACK Jirka
participants (3)
-
Daniel P. Berrange -
Eric Blake -
Jiri Denemark