I mistakenly dropped keycodemapdb commit 6b3d716e from our libvirt 4.1.0 builds only to stumble across the failures in py3 environments that are fixed by that commit. Should the submodule be updated for the 4.1.0 release?

On Thu, Mar 01, 2018 at 04:52:09PM +0000, Daniel P. Berrangé wrote: > You show that we we missing CI coverage for python3 though, so we > should address that. We could make our Fedora Jenkins CI builds use py3, > along with one of our Travis scenarios, so we get a mix of py2&py3 > coverage in both Jenkins & Travis. Do we? I think the builds were switched so that we can run unit tests on virt-manager so now we have CI coverage for py2 as well as py3.

On Fri, Mar 02, 2018 at 11:24:03AM +0100, Andrea Bolognani wrote: > On Fri, 2018-03-02 at 08:08 +0100, Martin Kletzander wrote: > > On Thu, Mar 01, 2018 at 04:52:09PM +0000, Daniel P. Berrangé wrote: > > > You show that we we missing CI coverage for python3 though, so we > > > should address that. We could make our Fedora Jenkins CI builds use py3, > > > along with one of our Travis scenarios, so we get a mix of py2&py3 > > > coverage in both Jenkins & Travis. > > > > Do we? I think the builds were switched so that we can run unit tests on > > virt-manager so now we have CI coverage for py2 as well as py3. > > We use both Python 2 and 3, but only for project that are themselves > implemented in Python (libvirt-python and virt-manager); what I > think Dan is referring to is that we only ever use Python 2 to call > keycodemapdb's own tools, so there's no Python 3 coverage for that. Yeah exactly - some bits of libvirt build process use python scripts and so we should test that under both.

Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

BTW, we just hit a problem with macOS homebrew changing python to point to a py3 binary and that showed other libvirt failures. In particular the ESX code generator is broken under py2. I wouldn't be surprised if more of our python scripts are also broken. So I think we need a general work item to fix py3 compat for libvirt - if someone wants to work on it for the 4.2.0 release....