[libvirt] [PATCH] virconf: fix the inconsistent name

Fix the name inconsistency between func comments and parameter of virConfGetValue/virConfSetValue Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> --- src/util/virconf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virconf.c b/src/util/virconf.c index 86d76b5..ab98c5c 100644 --- a/src/util/virconf.c +++ b/src/util/virconf.c @@ -840,7 +840,7 @@ virConfFree(virConfPtr conf) /** * virConfGetValue: * @conf: a configuration file handle - * @entry: the name of the entry + * @setting: the name of the entry * * Lookup the value associated to this entry in the configuration file * @@ -870,7 +870,7 @@ virConfGetValue(virConfPtr conf, const char *setting) /** * virConfSetValue: * @conf: a configuration file handle - * @entry: the name of the entry + * @setting: the name of the entry * @value: the new configuration value * * Set (or replace) the value associated to this entry in the configuration -- 2.1.0

On 18.08.2015 14:38, Cao jin wrote:
Fix the name inconsistency between func comments and parameter of virConfGetValue/virConfSetValue
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> --- src/util/virconf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
ACKed and pushed. Although, there are some more occurrences of the same problem in the file, e.g. virConfWalk. Wanna fix them too? Michal

Hi Michal On 08/19/2015 01:51 AM, Michal Privoznik wrote:
On 18.08.2015 14:38, Cao jin wrote:
Fix the name inconsistency between func comments and parameter of virConfGetValue/virConfSetValue
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> --- src/util/virconf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
ACKed and pushed. Although, there are some more occurrences of the same problem in the file, e.g. virConfWalk. Wanna fix them too?
Michal
Yup...I scaned that file with my eyes, want to see if any same issue, seems I missed the func you mentioned. thanks for your reminding, the patch is on the way:) -- Yours Sincerely, Cao Jin
participants (2)
-
Cao jin
-
Michal Privoznik