[Libvir] PATCH: Fix paravirt FB with xm driver
The code for dealing with the paravirt framebuffer was missing code to deal with an explicit vncdisplay=N setting - only working for vncunused=1. It was also not flexible enough in processing the 2 different styles of FB config. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
On Fri, Aug 10, 2007 at 04:39:03PM +0100, Daniel P. Berrange wrote:
The code for dealing with the paravirt framebuffer was missing code to deal with an explicit vncdisplay=N setting - only working for vncunused=1. It was also not flexible enough in processing the 2 different styles of FB config.
I'm not sure I undertand the logic for setting the port, why going whould xenstore there ? Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
On Fri, Aug 10, 2007 at 12:08:26PM -0400, Daniel Veillard wrote:
On Fri, Aug 10, 2007 at 04:39:03PM +0100, Daniel P. Berrange wrote:
The code for dealing with the paravirt framebuffer was missing code to deal with an explicit vncdisplay=N setting - only working for vncunused=1. It was also not flexible enough in processing the 2 different styles of FB config.
I'm not sure I undertand the logic for setting the port, why going whould xenstore there ?
I'm not sure what you mean - xenstore isn't involved in this. This is for taking the XML and writing out the /etc/xen config - the port stuff is basically making sure that port="5903" is translated into the config option 'vncdisplay=3'. Previously only port="-1" was working. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
On Fri, Aug 10, 2007 at 05:10:46PM +0100, Daniel P. Berrange wrote:
On Fri, Aug 10, 2007 at 12:08:26PM -0400, Daniel Veillard wrote:
On Fri, Aug 10, 2007 at 04:39:03PM +0100, Daniel P. Berrange wrote:
The code for dealing with the paravirt framebuffer was missing code to deal with an explicit vncdisplay=N setting - only working for vncunused=1. It was also not flexible enough in processing the 2 different styles of FB config.
I'm not sure I undertand the logic for setting the port, why going whould xenstore there ?
I'm not sure what you mean - xenstore isn't involved in this. This is for taking the XML and writing out the /etc/xen config - the port stuff is basically making sure that port="5903" is translated into the config option 'vncdisplay=3'. Previously only port="-1" was working.
Whoops reread, yeah, I don't understand why I saw a xenstore operation there ! weird ... Okay +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
Daniel P. Berrange wrote:
The code for dealing with the paravirt framebuffer was missing code to deal with an explicit vncdisplay=N setting - only working for vncunused=1. It was also not flexible enough in processing the 2 different styles of FB config.
I too am having trouble following the explanation / code. Can you explain a bit more ...? Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
On Fri, Aug 10, 2007 at 05:16:28PM +0100, Richard W.M. Jones wrote:
Daniel P. Berrange wrote:
The code for dealing with the paravirt framebuffer was missing code to deal with an explicit vncdisplay=N setting - only working for vncunused=1. It was also not flexible enough in processing the 2 different styles of FB config.
I too am having trouble following the explanation / code. Can you explain a bit more ...?
Two core issues For paravirt the framebuffer can be configured in either old style: vnc=1 vncunused=1 Or new style vfb = ["type=vnc,vncunused=1" The problem was that with Xen > 3.0.3 we were only handling the latter and not the former. We needed to process both styles for compatability. The second part of it is that while we handled <graphics type='vnc' port='-1' /> Converting to 'vncunused=1'. We did not handle <graphics type='vnc' port='5905' /> Which needs to convert to vncunused=0, and vncdisplay=5 Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
participants (3)
-
Daniel P. Berrange -
Daniel Veillard -
Richard W.M. Jones