From 9c4881c67472575c3f1982f0921a4292025a9620 Mon Sep 17 00:00:00 2001 Message-Id: <9c4881c67472575c3f1982f0921a4292025a9620.1350037981.git.cbley@av-test.de> In-Reply-To: <cover.1350037981.git.cbley@av-test.de> References: <2DA6F4A3691599408358374D182280F9141CF6@xmb-rcd-x04.cisco.com> <cover.1350037981.git.cbley@av-test.de> From: cbley@av-test.de (Claudio Bley) Date: Fri, 17 Aug 2012 14:45:26 +0200 Subject: [PATCH 01/15] Explicitly set includeAntRuntime to false for javac tasks. To: libvir-list@redhat.com Organization: AV-Test GmbH, Germany
This prevents warnings like this: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds --- build.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build.xml b/build.xml index 0b009aa..158a8a5 100644 --- a/build.xml +++ b/build.xml @@ -42,8 +42,8 @@ </target> <target name="build" depends="init" description="builds the code and jar files"> - <javac srcdir="src/main/java" includes="**/*.java" classpathref="compile.classpath" destdir="target/classes" /> - <javac srcdir="src/test/java" includes="**/*.java" classpathref="test.classpath" destdir="target/testclasses" /> + <javac srcdir="src/main/java" debug="${javac.debug}" includes="**/*.java" classpathref="compile.classpath" destdir="target/classes" includeAntRuntime="false" /> + <javac srcdir="src/test/java" debug="${javac.debug}" includes="**/*.java" classpathref="test.classpath" destdir="target/testclasses" includeAntRuntime="false" /> <jar destfile="${jar.file}" basedir="target/classes" /> </target> -- AV-Test GmbH, Henricistraße 20, 04155 Leipzig, Germany Phone: +49 341 265 310 19 Web:<http://www.av-test.org> Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076) Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern
On 10/12/2012 06:59 AM, cbley@av-test.de wrote:
From 9c4881c67472575c3f1982f0921a4292025a9620 Mon Sep 17 00:00:00 2001 Message-Id: <9c4881c67472575c3f1982f0921a4292025a9620.1350037981.git.cbley@av-test.de> In-Reply-To: <cover.1350037981.git.cbley@av-test.de> References: <2DA6F4A3691599408358374D182280F9141CF6@xmb-rcd-x04.cisco.com> <cover.1350037981.git.cbley@av-test.de> From: cbley@av-test.de (Claudio Bley) Date: Fri, 17 Aug 2012 14:45:26 +0200 Subject: [PATCH 01/15] Explicitly set includeAntRuntime to false for javac tasks.
This series is EXTREMELY hard to follow, as it hit the list unthreaded and out-of-order, due to the envelope having munged headers. Looking at the archive: https://www.redhat.com/archives/libvir-list/2012-October/thread.html#00551 I challenge you to quickly tell me which one of those messages was 1/15. Since it is too painful to have to open up 15 mails with identical subjects of "(no subject)" with no threading, just to reconstruct how the series is supposed to be applied, would you mind fixing your 'git send-email' settings and re-posting with proper subject and threading? -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
At Fri, 12 Oct 2012 07:17:01 -0600, Eric Blake wrote:
This series is EXTREMELY hard to follow, as it hit the list unthreaded and out-of-order, due to the envelope having munged headers. Looking at the archive:
https://www.redhat.com/archives/libvir-list/2012-October/thread.html#00551
I challenge you to quickly tell me which one of those messages was 1/15. Since it is too painful to have to open up 15 mails with identical subjects of "(no subject)" with no threading, just to reconstruct how the series is supposed to be applied, would you mind fixing your 'git send-email' settings and re-posting with proper subject and threading?
That's what I did. Hopefully it's OK this time... Sorry! -- AV-Test GmbH, Henricistraße 20, 04155 Leipzig, Germany Phone: +49 341 265 310 19 Web:<http://www.av-test.org> Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076) Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern
On 10/12/2012 08:29 AM, Claudio Bley wrote:
At Fri, 12 Oct 2012 07:17:01 -0600, Eric Blake wrote:
This series is EXTREMELY hard to follow, as it hit the list unthreaded and out-of-order, due to the envelope having munged headers. Looking at the archive:
https://www.redhat.com/archives/libvir-list/2012-October/thread.html#00551
I challenge you to quickly tell me which one of those messages was 1/15. Since it is too painful to have to open up 15 mails with identical subjects of "(no subject)" with no threading, just to reconstruct how the series is supposed to be applied, would you mind fixing your 'git send-email' settings and re-posting with proper subject and threading?
That's what I did. Hopefully it's OK this time...
Much better. Thanks!
Sorry!
It happens - 'git send-email' is not always the easiest to set up correctly for your own environment, which is why my advice is to send a test run to yourself, and then use 'git am' to see if you can apply your own patches, before sending to a list. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (3)
-
cbley＠av-test.de -
Claudio Bley
-
Eric Blake