On 11/27/20 12:52 PM, Roman Bolshakov wrote:
> On Fri, Nov 27, 2020 at 10:53:49AM +0100, Michal Prívozník wrote:
> > On 11/23/20 11:10 PM, Roman Bolshakov wrote:
> > > The test takes 40+ seconds on MBP 2012, MBA 2015. Cirrus completes the
> > > test within default timeout, just above 29 seconds but the error margin
> > > is narrow, under a second.
> > >
> > > It'd be good to provide reasonable default timeout to avoid test
suite
> > > failure if "meson test" is invoked without arguments.
> > >
> > > Closes
https://gitlab.com/libvirt/libvirt/-/issues/58
> > > Signed-off-by: Roman Bolshakov <r.bolshakov(a)yadro.com>
> > > ---
> > > tests/meson.build | 8 +++++++-
> > > 1 file changed, 7 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/tests/meson.build b/tests/meson.build
> > > index f88410ff33..cb06873ba5 100644
> > > --- a/tests/meson.build
> > > +++ b/tests/meson.build
> > > @@ -574,7 +574,13 @@ foreach data : tests
> > > ],
> > > export_dynamic: true,
> > > )
> > > - test(data['name'], test_bin, env: tests_env)
> > > + if data['name'] == 'qemuxml2argvtest' and
host_machine.system() == 'darwin'
> >
> > If we are doing this, then I'd say do it host arch agnostic.
> >
>
> I intended to do that but forgot about it. Thanks for catching that!
Okay, I can fix that just before pushing.
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
and pushed.
Michal
I was about to resend v3 when received the email :)
Thanks for reviewing the series.
Best regards,
Roman