[libvirt] [PATCH] qemu: remove a redundant call from qemuDomainGetPerfEvents

Calling virDomainObjUpdateModificationImpact directly inside the function body is redundant, since the same function call is embedded into virDomainObjGetOneDef. Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com> --- src/qemu/qemu_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ef2e980216..6bfbc31c1c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10339,9 +10339,6 @@ qemuDomainGetPerfEvents(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) goto cleanup; - if (virDomainObjUpdateModificationImpact(vm, &flags) < 0) - goto endjob; - if (!(def = virDomainObjGetOneDef(vm, flags))) goto endjob; -- 2.22.0

On Mon, Jul 01, 2019 at 04:15:00PM +0200, Ilias Stamatis wrote:
Calling virDomainObjUpdateModificationImpact directly inside the function body is redundant, since the same function call is embedded into virDomainObjGetOneDef.
Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>
participants (2)
-
Erik Skultety
-
Ilias Stamatis