[libvirt] [PATCH] qemu: Avoid NULL dereference in qemuSharedDiskEntryFree

At least one caller may call qemuSharedDiskEntryFree with NULL as the first argument. Let's make the function similar to other *Free functions and do nothing in such case. --- src/qemu/qemu_conf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 3ef3499..2408610 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -1045,6 +1045,9 @@ qemuSharedDiskEntryFree(void *payload, const void *name ATTRIBUTE_UNUSED) qemuSharedDiskEntryPtr entry = payload; size_t i; + if (!entry) + return; + for (i = 0; i < entry->ref; i++) { VIR_FREE(entry->domains[i]); } -- 1.8.1.5

On 03/12/13 09:13, Jiri Denemark wrote:
At least one caller may call qemuSharedDiskEntryFree with NULL as the first argument. Let's make the function similar to other *Free functions and do nothing in such case. --- src/qemu/qemu_conf.c | 3 +++ 1 file changed, 3 insertions(+)
ACK. Peter

On Tue, Mar 12, 2013 at 09:32:16 +0100, Peter Krempa wrote:
On 03/12/13 09:13, Jiri Denemark wrote:
At least one caller may call qemuSharedDiskEntryFree with NULL as the first argument. Let's make the function similar to other *Free functions and do nothing in such case. --- src/qemu/qemu_conf.c | 3 +++ 1 file changed, 3 insertions(+)
ACK.
Thanks, pushed. Jirka
participants (2)
-
Jiri Denemark
-
Peter Krempa