[libvirt] [PATCH] Fix mis-leading error message in pool delete API
When trying to delete a pool the error message claimed the volume could not be deleted. * src/storage/storage_driver.c: Error message referred to volumes instead of pools --- src/storage/storage_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 6b1045a..f3be6de 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -822,7 +822,7 @@ storagePoolDelete(virStoragePoolPtr obj, if (!backend->deletePool) { virStorageReportError(VIR_ERR_NO_SUPPORT, - "%s", _("pool does not support volume delete")); + "%s", _("pool does not support pool deletion")); goto cleanup; } if (backend->deletePool(obj->conn, pool, flags) < 0) -- 1.6.5.2
According to Daniel P. Berrange on 3/3/2010 11:49 AM:
When trying to delete a pool the error message claimed the volume could not be deleted.
- "%s", _("pool does not support volume delete")); + "%s", _("pool does not support pool deletion"));
ACK, since a volume can be a pool, but not all pools are volumes. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 03/03/2010 01:49 PM, Daniel P. Berrange wrote:
When trying to delete a pool the error message claimed the volume could not be deleted.
* src/storage/storage_driver.c: Error message referred to volumes instead of pools --- src/storage/storage_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 6b1045a..f3be6de 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -822,7 +822,7 @@ storagePoolDelete(virStoragePoolPtr obj,
if (!backend->deletePool) { virStorageReportError(VIR_ERR_NO_SUPPORT, - "%s", _("pool does not support volume delete")); + "%s", _("pool does not support pool deletion")); goto cleanup; } if (backend->deletePool(obj->conn, pool, flags)< 0)
ACK Dave
participants (3)
-
Daniel P. Berrange -
Dave Allan -
Eric Blake