[libvirt] [PATCH C#] Don't add a column per item in the Mono virConnectOpenAuth example

--- .../MonoDevelop/virConnectOpenAuth/MainWindow.cs | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/MonoDevelop/virConnectOpenAuth/MainWindow.cs b/examples/MonoDevelop/virConnectOpenAuth/MainWindow.cs index d02acd4..4a3411d 100644 --- a/examples/MonoDevelop/virConnectOpenAuth/MainWindow.cs +++ b/examples/MonoDevelop/virConnectOpenAuth/MainWindow.cs @@ -36,6 +36,10 @@ public partial class MainWindow : Gtk.Window treeview1.AppendColumn(tvcDomains); treeview1.Model = domainListStore; + + CellRendererText crtDomainCell = new CellRendererText(); + tvcDomains.PackStart(crtDomainCell, true); + tvcDomains.AddAttribute(crtDomainCell, "text", 0); } protected void OnDeleteEvent (object sender, DeleteEventArgs a) @@ -137,9 +141,6 @@ public partial class MainWindow : Gtk.Window private void AddDomainInTreeView(string domainName) { domainListStore.AppendValues(domainName); - CellRendererText crtDomainCell = new CellRendererText(); - tvcDomains.PackStart(crtDomainCell, true); - tvcDomains.AddAttribute(crtDomainCell, "text", 0); } private static int AuthCallback(ref ConnectCredential[] creds, IntPtr cbdata) -- 1.7.0.4

On Thu, Oct 28, 2010 at 12:38:51PM +0200, Matthias Bolte wrote:
--- .../MonoDevelop/virConnectOpenAuth/MainWindow.cs | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

?Hi, I don't see the patches applied on git, normal ? Arnaud -------------------------------------------------- From: "Daniel Veillard" <veillard@redhat.com> Sent: Thursday, October 28, 2010 9:33 PM To: "Matthias Bolte" <matthias.bolte@googlemail.com> Cc: <libvir-list@redhat.com> Subject: Re: [libvirt] [PATCH C#] Don't add a column per item in the Mono virConnectOpenAuth example
On Thu, Oct 28, 2010 at 12:38:51PM +0200, Matthias Bolte wrote:
--- .../MonoDevelop/virConnectOpenAuth/MainWindow.cs | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
ACK,
Daniel
-- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

2010/10/29 <arnaud.champion@devatom.fr>:
?Hi,
I don't see the patches applied on git, normal ?
Arnaud
I just hadn't pushed it yet, because I was actually waiting for you to have a look at it and give an ACK. because I'm a very unfamiliar with C#. I'm going to push this one now, because it's a simple patch that won't break something.
-------------------------------------------------- From: "Daniel Veillard" <veillard@redhat.com> Sent: Thursday, October 28, 2010 9:33 PM To: "Matthias Bolte" <matthias.bolte@googlemail.com> Cc: <libvir-list@redhat.com> Subject: Re: [libvirt] [PATCH C#] Don't add a column per item in the Mono virConnectOpenAuth example
On Thu, Oct 28, 2010 at 12:38:51PM +0200, Matthias Bolte wrote:
--- .../MonoDevelop/virConnectOpenAuth/MainWindow.cs | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
ACK,
Daniel
Thanks, pushed. Matthias

Okay, For sure I am OK this patch make things cleaner, I have just a little problem : on windows, virConnectClose always failed. -------------------------------------------------- From: "Matthias Bolte" <matthias.bolte@googlemail.com> Sent: Friday, October 29, 2010 4:43 PM To: <arnaud.champion@devatom.fr> Cc: <veillard@redhat.com>; <libvir-list@redhat.com> Subject: Re: [libvirt] [PATCH C#] Don't add a column per item in the Mono virConnectOpenAuth example
2010/10/29 <arnaud.champion@devatom.fr>:
?Hi,
I don't see the patches applied on git, normal ?
Arnaud
I just hadn't pushed it yet, because I was actually waiting for you to have a look at it and give an ACK. because I'm a very unfamiliar with C#.
I'm going to push this one now, because it's a simple patch that won't break something.
-------------------------------------------------- From: "Daniel Veillard" <veillard@redhat.com> Sent: Thursday, October 28, 2010 9:33 PM To: "Matthias Bolte" <matthias.bolte@googlemail.com> Cc: <libvir-list@redhat.com> Subject: Re: [libvirt] [PATCH C#] Don't add a column per item in the Mono virConnectOpenAuth example
On Thu, Oct 28, 2010 at 12:38:51PM +0200, Matthias Bolte wrote:
--- .../MonoDevelop/virConnectOpenAuth/MainWindow.cs | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
ACK,
Daniel
Thanks, pushed.
Matthias
participants (3)
-
arnaud.champion@devatom.fr
-
Daniel Veillard
-
Matthias Bolte