[libvirt] [PATCH] maint: update to latest gnulib
Needed to silence a valgrind detection of uninitialized memory: https://bugzilla.redhat.com/show_bug.cgi?id=1174147 * .gnulib: Update to latest. * bootstrap: Resync to gnulib. Signed-off-by: Eric Blake <eblake@redhat.com> --- I've missed RC1, so I'll wait for a review on this one (are we sure that RC2 will be enough time to ensure the gnulib update doesn't cause regressions, basically). .gnulib | 2 +- bootstrap | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.gnulib b/.gnulib index c27f1a3..8be5f2c 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit c27f1a356f2f321daa7f971ef276a1dbfa873bf8 +Subproject commit 8be5f2c10eeb05e52cc4a33cdcd37078742ff5db diff --git a/bootstrap b/bootstrap index 2fdf267..e72894c 100755 --- a/bootstrap +++ b/bootstrap @@ -915,7 +915,8 @@ if test $use_libtool = 1; then esac fi echo "$0: $gnulib_tool $gnulib_tool_options --import ..." -$gnulib_tool $gnulib_tool_options --import $gnulib_modules && +$gnulib_tool $gnulib_tool_options --import $gnulib_modules \ + || die "gnulib-tool failed" for file in $gnulib_files; do symlink_to_dir "$GNULIB_SRCDIR" $file \ -- 2.1.0
On 02/24/2015 09:00 AM, Eric Blake wrote:
Needed to silence a valgrind detection of uninitialized memory: https://bugzilla.redhat.com/show_bug.cgi?id=1174147
* .gnulib: Update to latest. * bootstrap: Resync to gnulib.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
I've missed RC1, so I'll wait for a review on this one (are we sure that RC2 will be enough time to ensure the gnulib update doesn't cause regressions, basically).
The gnulib changelog: * .gnulib c27f1a3...8be5f2c (75):
passfd: avoid valgrind uninitalised data warning uniwbrk/u32-wordbreaks-tests: fix copyright dup2: doc and test for Android bug Replace dup2() on Android Android doesn't define RLIM_SAVED_* autoupdate vasnprintf-posix-tests: use consistent test printf, isinf, etc.: noncanonical != NaN fts: remove redundant close() (trivial) getdtablesize: port better for Android poll: fixes for large fds fcntl: Fix cross compiling dup2, fcntl: cross-compiler better for Android getopt: give accurate ambiguity diagnostic on mem exhaustion getopt: don't crash on memory exhaustion tempname: allow compilation with C++ (trivial) dup2, fcntl: port to AIX getdtablesize, dup2, fcntl: port to Android localename: Implement gl_locale_name_thread_unsafe for Android More changelog fixes fts: avoid crash when a cycle is added while traversing uniname/uniname: support character alias Fix ChangeLog botches in my recent commits duplocale: Fix Android build of duplocale-tests signal_h: Fix Android build net_if: Handle content-free <net/if.h> system headers linkat_nofollow: Add fallback case for cross compiling euidaccess: Fix Android build getugroups: Fix Android build localename: Fix Android build getdtablesize: Fix Android build Assume unbroken ungetc() on Android Fix FILE struct compatibility with Android API level >= 21 tests: avoid recent -Werror=unused-variable regression in test-locale maint: various whitespace cleanups in tempname tests: provide returns_() to simplify exit status checking mountlist: only use libmount when specified uniname/unimame-tests: don't link with -lunistring fstrcmp: don't assume strlen < INT_MAX diffseq: prefer ptrdiff_t to ssize_t xalloc: fix typo that suppressed warnings full-read: fix license notice typo crypto/gc: fix a -Wswitch warning autoupdate update from texinfo tempname: new try_tempname function gnulib-tool: fix handling of patch(1) diagnostics bootstrap: exit immediately upon gnulib-tool failure symlinkat: include all required header files update from texinfo update from texinfo update from texinfo localename: support Solaris 12 and illumos locale: fix tests on illumos unictype: avoid undefined left-shift behavior libunistring: bump version of unitypes dependants unictype/category-none: fix link with libunistring unitypes: fix build with installed libunistring time: port to MinGW32 3.21 update-copyright: apply to self libunistring: update to Unicode 7.0.0 libunistring: update to Unicode 6.3.0 libunistring: update to Unicode 6.2.0 libunistring: update to Unicode 6.1.0 uniwbrk/u32-wordbreaks-tests: add conformance test uniwbrk: ignore Extended/Format characters at BOL test-strstr.c: avoid a trivial leak update-copyright: recognize groff's \(co marker maint.mk: fix compatibility with OS X nm localcharset: improve charset detection on OS/2 count-leading-zeros: use 64-bit intrinsics on 32-bit Windows count-leading-zeros: fix pragma typos autoupdate count-leading-zeros: avoid 64-bit intrinsics on 32-bit Windows uniname/uniname: update to Unicode 7.0.0
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Tue, Feb 24, 2015 at 09:04:00AM -0700, Eric Blake wrote:
On 02/24/2015 09:00 AM, Eric Blake wrote:
Needed to silence a valgrind detection of uninitialized memory: https://bugzilla.redhat.com/show_bug.cgi?id=1174147
* .gnulib: Update to latest. * bootstrap: Resync to gnulib.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
I've missed RC1, so I'll wait for a review on this one (are we sure that RC2 will be enough time to ensure the gnulib update doesn't cause regressions, basically).
Is it worth risking that due to one valgrind warning? I don't remember more than maybe one time that gnulib caused a problem, but who knows. Anyway, "my limited testing" didn't show any problems.
The gnulib changelog:
* .gnulib c27f1a3...8be5f2c (75):
passfd: avoid valgrind uninitalised data warning uniwbrk/u32-wordbreaks-tests: fix copyright dup2: doc and test for Android bug Replace dup2() on Android Android doesn't define RLIM_SAVED_* autoupdate vasnprintf-posix-tests: use consistent test printf, isinf, etc.: noncanonical != NaN fts: remove redundant close() (trivial) getdtablesize: port better for Android poll: fixes for large fds fcntl: Fix cross compiling dup2, fcntl: cross-compiler better for Android getopt: give accurate ambiguity diagnostic on mem exhaustion getopt: don't crash on memory exhaustion tempname: allow compilation with C++ (trivial) dup2, fcntl: port to AIX getdtablesize, dup2, fcntl: port to Android localename: Implement gl_locale_name_thread_unsafe for Android More changelog fixes fts: avoid crash when a cycle is added while traversing uniname/uniname: support character alias Fix ChangeLog botches in my recent commits duplocale: Fix Android build of duplocale-tests signal_h: Fix Android build net_if: Handle content-free <net/if.h> system headers linkat_nofollow: Add fallback case for cross compiling euidaccess: Fix Android build getugroups: Fix Android build localename: Fix Android build getdtablesize: Fix Android build Assume unbroken ungetc() on Android Fix FILE struct compatibility with Android API level >= 21 tests: avoid recent -Werror=unused-variable regression in test-locale maint: various whitespace cleanups in tempname tests: provide returns_() to simplify exit status checking mountlist: only use libmount when specified uniname/unimame-tests: don't link with -lunistring fstrcmp: don't assume strlen < INT_MAX diffseq: prefer ptrdiff_t to ssize_t xalloc: fix typo that suppressed warnings full-read: fix license notice typo crypto/gc: fix a -Wswitch warning autoupdate update from texinfo tempname: new try_tempname function gnulib-tool: fix handling of patch(1) diagnostics bootstrap: exit immediately upon gnulib-tool failure symlinkat: include all required header files update from texinfo update from texinfo update from texinfo localename: support Solaris 12 and illumos locale: fix tests on illumos unictype: avoid undefined left-shift behavior libunistring: bump version of unitypes dependants unictype/category-none: fix link with libunistring unitypes: fix build with installed libunistring time: port to MinGW32 3.21 update-copyright: apply to self libunistring: update to Unicode 7.0.0 libunistring: update to Unicode 6.3.0 libunistring: update to Unicode 6.2.0 libunistring: update to Unicode 6.1.0 uniwbrk/u32-wordbreaks-tests: add conformance test uniwbrk: ignore Extended/Format characters at BOL test-strstr.c: avoid a trivial leak update-copyright: recognize groff's \(co marker maint.mk: fix compatibility with OS X nm localcharset: improve charset detection on OS/2 count-leading-zeros: use 64-bit intrinsics on 32-bit Windows count-leading-zeros: fix pragma typos autoupdate count-leading-zeros: avoid 64-bit intrinsics on 32-bit Windows uniname/uniname: update to Unicode 7.0.0
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 02/25/2015 12:20 AM, Martin Kletzander wrote:
On Tue, Feb 24, 2015 at 09:04:00AM -0700, Eric Blake wrote:
On 02/24/2015 09:00 AM, Eric Blake wrote:
Needed to silence a valgrind detection of uninitialized memory: https://bugzilla.redhat.com/show_bug.cgi?id=1174147
* .gnulib: Update to latest. * bootstrap: Resync to gnulib.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
I've missed RC1, so I'll wait for a review on this one (are we sure that RC2 will be enough time to ensure the gnulib update doesn't cause regressions, basically).
Is it worth risking that due to one valgrind warning? I don't remember more than maybe one time that gnulib caused a problem, but who knows.
And the valgrind warning is harmless - it's complaining about passing uninitialized memory to a syscall, but that memory lives in the padding of a struct, and none of the code is actually acting on that memory (either on our side, or in the syscall). If we want to just live with the warning until after the release, that would also be okay - we have up until the RC2 date to make the decision.
Anyway, "my limited testing" didn't show any problems.
The gnulib changelog:
Most of the changes here are for Android, but I don't know of anyone building libvirt on that platform yet. That said,...
* .gnulib c27f1a3...8be5f2c (75):
passfd: avoid valgrind uninitalised data warning
This one fixes the valgrind warning...
gnulib-tool: fix handling of patch(1) diagnostics bootstrap: exit immediately upon gnulib-tool failure
these two are useful to us as developers, but don't affect the code base...
count-leading-zeros: use 64-bit intrinsics on 32-bit Windows count-leading-zeros: fix pragma typos
and these might affect mingw builds. Any other opinions? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Wed, Feb 25, 2015 at 06:09:42AM -0700, Eric Blake wrote:
On 02/25/2015 12:20 AM, Martin Kletzander wrote:
On Tue, Feb 24, 2015 at 09:04:00AM -0700, Eric Blake wrote:
On 02/24/2015 09:00 AM, Eric Blake wrote:
Needed to silence a valgrind detection of uninitialized memory: https://bugzilla.redhat.com/show_bug.cgi?id=1174147
* .gnulib: Update to latest. * bootstrap: Resync to gnulib.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
I've missed RC1, so I'll wait for a review on this one (are we sure that RC2 will be enough time to ensure the gnulib update doesn't cause regressions, basically).
Is it worth risking that due to one valgrind warning? I don't remember more than maybe one time that gnulib caused a problem, but who knows.
And the valgrind warning is harmless - it's complaining about passing uninitialized memory to a syscall, but that memory lives in the padding of a struct, and none of the code is actually acting on that memory (either on our side, or in the syscall). If we want to just live with the warning until after the release, that would also be okay - we have up until the RC2 date to make the decision.
Anyway, "my limited testing" didn't show any problems.
The gnulib changelog:
Most of the changes here are for Android, but I don't know of anyone building libvirt on that platform yet. That said,...
* .gnulib c27f1a3...8be5f2c (75):
passfd: avoid valgrind uninitalised data warning
This one fixes the valgrind warning...
gnulib-tool: fix handling of patch(1) diagnostics bootstrap: exit immediately upon gnulib-tool failure
these two are useful to us as developers, but don't affect the code base...
count-leading-zeros: use 64-bit intrinsics on 32-bit Windows count-leading-zeros: fix pragma typos
and these might affect mingw builds.
Any other opinions?
From the list of changes I don't see any compelling reason to push it before release. ie, we're not waiting for any particular bug fix it includes.
Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 02/25/2015 06:13 AM, Daniel P. Berrange wrote:
On Wed, Feb 25, 2015 at 06:09:42AM -0700, Eric Blake wrote:
On 02/25/2015 12:20 AM, Martin Kletzander wrote:
On Tue, Feb 24, 2015 at 09:04:00AM -0700, Eric Blake wrote:
On 02/24/2015 09:00 AM, Eric Blake wrote:
Needed to silence a valgrind detection of uninitialized memory: https://bugzilla.redhat.com/show_bug.cgi?id=1174147
I've missed RC1, so I'll wait for a review on this one (are we sure that RC2 will be enough time to ensure the gnulib update doesn't cause regressions, basically).
From the list of changes I don't see any compelling reason to push it before release. ie, we're not waiting for any particular bug fix it includes.
We deferred for 1.2.13 because I had missed RC1. But I'm in time for 1.2.14, so I'm pushing this now under the gnulib-maintenance rule. Here's the final changeset to gnulib: * .gnulib c27f1a3...106a386 (90):
quotearg-simple-tests: add missing gl_FUNC_MMAP_ANON dependency yesno: make EOL optional in ENABLE_NLS case also fdopendir-tests: test it does not close its arg gitlog-to-changelog: trim trailing white space gitlog-to-changelog: new option --ignore-matching fdopendir: port better to MinGW fdopendir: fix typo in comment error: document all entry points provided autoupdate autoupdate autoupdate vasnprintf: pacify clang 3.5.0 glob, etc.: port to MSVC v18 on MS-Windows 8.1 poll: port to MSVC v18 on MS-Windows 8.1 tests: support stderr verification with returns_() passfd: avoid valgrind uninitalised data warning uniwbrk/u32-wordbreaks-tests: fix copyright dup2: doc and test for Android bug Replace dup2() on Android Android doesn't define RLIM_SAVED_* autoupdate vasnprintf-posix-tests: use consistent test printf, isinf, etc.: noncanonical != NaN fts: remove redundant close() (trivial) getdtablesize: port better for Android poll: fixes for large fds fcntl: Fix cross compiling dup2, fcntl: cross-compiler better for Android getopt: give accurate ambiguity diagnostic on mem exhaustion getopt: don't crash on memory exhaustion tempname: allow compilation with C++ (trivial) dup2, fcntl: port to AIX getdtablesize, dup2, fcntl: port to Android localename: Implement gl_locale_name_thread_unsafe for Android More changelog fixes fts: avoid crash when a cycle is added while traversing uniname/uniname: support character alias Fix ChangeLog botches in my recent commits duplocale: Fix Android build of duplocale-tests signal_h: Fix Android build net_if: Handle content-free <net/if.h> system headers linkat_nofollow: Add fallback case for cross compiling euidaccess: Fix Android build getugroups: Fix Android build localename: Fix Android build getdtablesize: Fix Android build Assume unbroken ungetc() on Android Fix FILE struct compatibility with Android API level >= 21 tests: avoid recent -Werror=unused-variable regression in test-locale maint: various whitespace cleanups in tempname tests: provide returns_() to simplify exit status checking mountlist: only use libmount when specified uniname/unimame-tests: don't link with -lunistring fstrcmp: don't assume strlen < INT_MAX diffseq: prefer ptrdiff_t to ssize_t xalloc: fix typo that suppressed warnings full-read: fix license notice typo crypto/gc: fix a -Wswitch warning autoupdate update from texinfo tempname: new try_tempname function gnulib-tool: fix handling of patch(1) diagnostics bootstrap: exit immediately upon gnulib-tool failure symlinkat: include all required header files update from texinfo update from texinfo update from texinfo localename: support Solaris 12 and illumos locale: fix tests on illumos unictype: avoid undefined left-shift behavior libunistring: bump version of unitypes dependants unictype/category-none: fix link with libunistring unitypes: fix build with installed libunistring time: port to MinGW32 3.21 update-copyright: apply to self libunistring: update to Unicode 7.0.0 libunistring: update to Unicode 6.3.0 libunistring: update to Unicode 6.2.0 libunistring: update to Unicode 6.1.0 uniwbrk/u32-wordbreaks-tests: add conformance test uniwbrk: ignore Extended/Format characters at BOL test-strstr.c: avoid a trivial leak update-copyright: recognize groff's \(co marker maint.mk: fix compatibility with OS X nm localcharset: improve charset detection on OS/2 count-leading-zeros: use 64-bit intrinsics on 32-bit Windows count-leading-zeros: fix pragma typos autoupdate count-leading-zeros: avoid 64-bit intrinsics on 32-bit Windows uniname/uniname: update to Unicode 7.0.0
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Wed, Feb 25, 2015 at 06:09:42AM -0700, Eric Blake wrote:
On 02/25/2015 12:20 AM, Martin Kletzander wrote:
On Tue, Feb 24, 2015 at 09:04:00AM -0700, Eric Blake wrote:
On 02/24/2015 09:00 AM, Eric Blake wrote:
Needed to silence a valgrind detection of uninitialized memory: https://bugzilla.redhat.com/show_bug.cgi?id=1174147
* .gnulib: Update to latest. * bootstrap: Resync to gnulib.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
I've missed RC1, so I'll wait for a review on this one (are we sure that RC2 will be enough time to ensure the gnulib update doesn't cause regressions, basically).
Is it worth risking that due to one valgrind warning? I don't remember more than maybe one time that gnulib caused a problem, but who knows.
And the valgrind warning is harmless - it's complaining about passing uninitialized memory to a syscall, but that memory lives in the padding of a struct, and none of the code is actually acting on that memory (either on our side, or in the syscall). If we want to just live with the warning until after the release, that would also be okay - we have up until the RC2 date to make the decision.
Personally, the valgrind warning seems harmless enough to me that I'd rather wait until the gnulib update introduces a more important bugfix, only to reduce the chance of bisecting across gnulib updates. :) Jan
participants (4)
-
Daniel P. Berrange -
Eric Blake -
Ján Tomko -
Martin Kletzander