[libvirt] [PATCH] Increase initial qemu monitor read timeout

See https://bugzilla.redhat.com/show_bug.cgi?id=453491 We've been getting bug reports like the above against virt-manager for a while now: installing new VMs consistently throws an error 'Timed out while reading monitor startup output'. The user can then just retry the install and it will go off without a hitch. I only just realized that the common thread between the reports is physical install media: apparently the qemu monitor isn't too responsive while it's waiting for a cold cd drive to spin up. The attached patch jacks up the timeout from 3 seconds to 10 seconds when doing the initial monitor read. I verified that this fixes the issue. Thanks, Cole

On Mon, Dec 01, 2008 at 05:36:51PM -0500, Cole Robinson wrote:
See https://bugzilla.redhat.com/show_bug.cgi?id=453491
We've been getting bug reports like the above against virt-manager for a while now: installing new VMs consistently throws an error 'Timed out while reading monitor startup output'. The user can then just retry the install and it will go off without a hitch.
I only just realized that the common thread between the reports is physical install media: apparently the qemu monitor isn't too responsive while it's waiting for a cold cd drive to spin up.
The attached patch jacks up the timeout from 3 seconds to 10 seconds when doing the initial monitor read. I verified that this fixes the issue.
ACK, seems reasonable, although it'll block the caller for longer, this is best option with way we currently handle startup. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

Daniel P. Berrange wrote:
On Mon, Dec 01, 2008 at 05:36:51PM -0500, Cole Robinson wrote:
See https://bugzilla.redhat.com/show_bug.cgi?id=453491
We've been getting bug reports like the above against virt-manager for a while now: installing new VMs consistently throws an error 'Timed out while reading monitor startup output'. The user can then just retry the install and it will go off without a hitch.
I only just realized that the common thread between the reports is physical install media: apparently the qemu monitor isn't too responsive while it's waiting for a cold cd drive to spin up.
The attached patch jacks up the timeout from 3 seconds to 10 seconds when doing the initial monitor read. I verified that this fixes the issue.
ACK, seems reasonable, although it'll block the caller for longer, this is best option with way we currently handle startup.
Daniel
Pushed now. Thanks, Cole
participants (2)
-
Cole Robinson
-
Daniel P. Berrange