[libvirt] [PATCH] libvirt-guests: Disable shutdown timeout

Since we can't know at service start how many VMs will be running we can't calculate an apropriate shutdown timeout. So instead of killing off the service just let it use it's own internal timeout mechanism. References: http://bugs.debian.org/803714 https://bugzilla.redhat.com/show_bug.cgi?id=1195544 --- tools/libvirt-guests.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index cc04b6d..c31f663 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -13,6 +13,7 @@ ExecStop=@libexecdir@/libvirt-guests.sh stop Type=oneshot RemainAfterExit=yes StandardOutput=journal+console +TimeoutStopSec=0 [Install] WantedBy=multi-user.target -- 2.6.2

On Tue, Nov 17, 2015 at 08:43:54AM +0100, Guido Günther wrote:
Since we can't know at service start how many VMs will be running we can't calculate an apropriate shutdown timeout. So instead of killing off the service just let it use it's own internal timeout mechanism.
References: http://bugs.debian.org/803714 https://bugzilla.redhat.com/show_bug.cgi?id=1195544 --- tools/libvirt-guests.service.in | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index cc04b6d..c31f663 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -13,6 +13,7 @@ ExecStop=@libexecdir@/libvirt-guests.sh stop Type=oneshot RemainAfterExit=yes StandardOutput=journal+console +TimeoutStopSec=0
[Install] WantedBy=multi-user.target
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

On Tue, Nov 17, 2015 at 10:51:55AM +0000, Daniel P. Berrange wrote:
On Tue, Nov 17, 2015 at 08:43:54AM +0100, Guido Günther wrote:
Since we can't know at service start how many VMs will be running we can't calculate an apropriate shutdown timeout. So instead of killing off the service just let it use it's own internal timeout mechanism.
References: http://bugs.debian.org/803714 https://bugzilla.redhat.com/show_bug.cgi?id=1195544 --- tools/libvirt-guests.service.in | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index cc04b6d..c31f663 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -13,6 +13,7 @@ ExecStop=@libexecdir@/libvirt-guests.sh stop Type=oneshot RemainAfterExit=yes StandardOutput=journal+console +TimeoutStopSec=0
[Install] WantedBy=multi-user.target
ACK
Pushed. Thanks, -- Guido
participants (2)
-
Daniel P. Berrange
-
Guido Günther