[libvirt] [libvirt-glib 1/2] Use 1 GB of RAM in Python example (instead of 1 TB)
--- examples/config-demo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/config-demo.py b/examples/config-demo.py index 92e8a89..016f9bb 100644 --- a/examples/config-demo.py +++ b/examples/config-demo.py @@ -4,7 +4,7 @@ from gi.repository import LibvirtGConfig; domain = LibvirtGConfig.Domain.new() domain.set_name("foo") -domain.set_memory(1024*1024*1024) +domain.set_memory(1024*1024) domain.set_vcpus(2) domain.set_lifecycle(LibvirtGConfig.DomainLifecycleEvent.ON_POWEROFF, LibvirtGConfig.DomainLifecycleAction.DESTROY) -- 1.7.10.4
Without this creating the domain fails: gi._glib.GError: Failed to create domain: internal error missing domain type attribute --- examples/config-demo.py | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/config-demo.py b/examples/config-demo.py index 016f9bb..aa2493e 100644 --- a/examples/config-demo.py +++ b/examples/config-demo.py @@ -8,6 +8,7 @@ domain.set_memory(1024*1024) domain.set_vcpus(2) domain.set_lifecycle(LibvirtGConfig.DomainLifecycleEvent.ON_POWEROFF, LibvirtGConfig.DomainLifecycleAction.DESTROY) +domain.set_virt_type(LibvirtGConfig.DomainVirtType.KVM) clock = LibvirtGConfig.DomainClock.new() clock.set_offset(LibvirtGConfig.DomainClockOffset.UTC) -- 1.7.10.4
On Mon, Sep 10, 2012 at 04:12:44PM +0300, Timo Juhani Lindfors wrote:
Without this creating the domain fails:
gi._glib.GError: Failed to create domain: internal error missing domain type attribute --- examples/config-demo.py | 1 + 1 file changed, 1 insertion(+)
diff --git a/examples/config-demo.py b/examples/config-demo.py index 016f9bb..aa2493e 100644 --- a/examples/config-demo.py +++ b/examples/config-demo.py @@ -8,6 +8,7 @@ domain.set_memory(1024*1024) domain.set_vcpus(2) domain.set_lifecycle(LibvirtGConfig.DomainLifecycleEvent.ON_POWEROFF, LibvirtGConfig.DomainLifecycleAction.DESTROY) +domain.set_virt_type(LibvirtGConfig.DomainVirtType.KVM)
ACK
clock = LibvirtGConfig.DomainClock.new() clock.set_offset(LibvirtGConfig.DomainClockOffset.UTC) -- 1.7.10.4
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, Sep 10, 2012 at 04:12:43PM +0300, Timo Juhani Lindfors wrote:
--- examples/config-demo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/config-demo.py b/examples/config-demo.py index 92e8a89..016f9bb 100644 --- a/examples/config-demo.py +++ b/examples/config-demo.py @@ -4,7 +4,7 @@ from gi.repository import LibvirtGConfig;
domain = LibvirtGConfig.Domain.new() domain.set_name("foo") -domain.set_memory(1024*1024*1024) +domain.set_memory(1024*1024)
Maybe a comment explicitly saying it's 1GB would be helpful? +domain.set_memory(1024*1024) # 1GB ACK either way. Christophe
Christophe Fergeau <cfergeau@redhat.com> writes:
Maybe a comment explicitly saying it's 1GB would be helpful? +domain.set_memory(1024*1024) # 1GB
Good question. My first reaction is that if such a simple example needs extra comments maybe it'd be nicer if the API offered "set_memory_kb"?
On Tue, Sep 11, 2012 at 10:37:23AM +0300, Timo Juhani Lindfors wrote:
Christophe Fergeau <cfergeau@redhat.com> writes:
Maybe a comment explicitly saying it's 1GB would be helpful? +domain.set_memory(1024*1024) # 1GB
Good question. My first reaction is that if such a simple example needs extra comments maybe it'd be nicer if the API offered "set_memory_kb"?
The thing is, this simple example is special as people like you will be copy and pasting from it, so better to make it crystal-clear. If we want to add a more explicit API, I'd probably go with a function that takes an int, and a unit as its second argument, but imo that's overkill at this point :) Christophe
--- examples/config-demo.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/examples/config-demo.py b/examples/config-demo.py index 6869ec3..508bbc5 100644 --- a/examples/config-demo.py +++ b/examples/config-demo.py @@ -4,7 +4,7 @@ from gi.repository import LibvirtGConfig; domain = LibvirtGConfig.Domain.new() domain.set_name("foo") -domain.set_memory(1024*1024*1024) +domain.set_memory(1024*1024) # 1 GB domain.set_vcpus(2) domain.set_lifecycle(LibvirtGConfig.DomainLifecycleEvent.ON_POWEROFF, LibvirtGConfig.DomainLifecycleAction.DESTROY) -- 1.7.2.5
Hey, I've pushed your 2 patches and added your name to the AUTHORS file, thanks for the patches! Christophe On Mon, Sep 10, 2012 at 04:12:43PM +0300, Timo Juhani Lindfors wrote:
--- examples/config-demo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/config-demo.py b/examples/config-demo.py index 92e8a89..016f9bb 100644 --- a/examples/config-demo.py +++ b/examples/config-demo.py @@ -4,7 +4,7 @@ from gi.repository import LibvirtGConfig;
domain = LibvirtGConfig.Domain.new() domain.set_name("foo") -domain.set_memory(1024*1024*1024) +domain.set_memory(1024*1024) domain.set_vcpus(2) domain.set_lifecycle(LibvirtGConfig.DomainLifecycleEvent.ON_POWEROFF, LibvirtGConfig.DomainLifecycleAction.DESTROY) -- 1.7.10.4
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (2)
-
Christophe Fergeau -
Timo Juhani Lindfors