[libvirt] [PATCH v3] This patch gives an error when migration is attempted with both --live and --offline options.
Signed-off-by: Nitesh Konkar <nitkon12@linux.vnet.ibm.com> --- tools/virsh-domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 43c8436..b9f678f 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9838,6 +9838,8 @@ cmdMigrate(vshControl *ctl, const vshCmd *cmd) bool live_flag = false; virshCtrlData data = { .dconn = NULL }; + VSH_EXCLUSIVE_OPTIONS("live", "offline"); + if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) return false; -- 1.8.3.1
On 26.02.2016 12:52, Ján Tomko wrote:
On Wed, Feb 24, 2016 at 01:06:05AM -0500, Nitesh Konkar wrote:
Signed-off-by: Nitesh Konkar <nitkon12@linux.vnet.ibm.com> --- tools/virsh-domain.c | 2 ++ 1 file changed, 2 insertions(+)
ACK; now pushed.
The API still does not refuse these two flags when specified at once. I guess we need a follow up patch. Michal
Hello Michal, As far as I understand, the migration when requested from any of the APIs, would still succeed with both flags specified at once. Sending a follow up patch. Warm Regards, Nitesh Konkar.
participants (3)
-
Ján Tomko -
Michal Privoznik -
Nitesh Konkar