On 11/07/2014 11:27 AM, Jincheng Miao wrote:

nodeSetMemoryParameters() will call nodeSetMemoryParameterValue() to set parameters. But it just filter the return code '-2' as failure. Indeed we should report error when rc is negative.

https://bugzilla.redhat.com/show_bug.cgi?id=1161541

Signed-off-by: Jincheng Miao <jmiao@redhat.com> --- src/nodeinfo.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 2e2fffa..3c22ebc 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -1374,8 +1374,7 @@ nodeSetMemoryParameters(virTypedParameterPtr params ATTRIBUTE_UNUSED, for (i = 0; i < nparams; i++) { rc = nodeSetMemoryParameterValue(¶ms[i]);

- /* Out of memory */ - if (rc == -2) + if (rc < 0) return -1; }

ACK and pushed Pavel