[Libvir] 7/8 Remove unnecessary "#include <assert.h>"s

Enable the <assert.h>-checking test; fix violations. * Makefile.cfg (local-checks-to-skip) [sc_prohibit_assert_without_use]: Enable. * qemud/mdns.c: Don't include <assert.h>; no uses of assert here. * qemud/qemud.c: Likewise. * qemud/remote.c: Likewise. Signed-off-by: Jim Meyering <meyering@redhat.com> --- Makefile.cfg | 1 - qemud/mdns.c | 1 - qemud/qemud.c | 1 - qemud/remote.c | 1 - 4 files changed, 0 insertions(+), 4 deletions(-) diff --git a/Makefile.cfg b/Makefile.cfg index 697fde4..dfca3fc 100644 --- a/Makefile.cfg +++ b/Makefile.cfg @@ -42,7 +42,6 @@ local-checks-to-skip = \ sc_error_exit_success \ sc_file_system \ sc_obsolete_symbols \ - sc_prohibit_assert_without_use \ sc_prohibit_atoi_atof \ sc_prohibit_jm_in_m4 \ sc_prohibit_quote_without_use \ diff --git a/qemud/mdns.c b/qemud/mdns.c index 1585b5b..cebf9a4 100644 --- a/qemud/mdns.c +++ b/qemud/mdns.c @@ -29,7 +29,6 @@ #include <time.h> #include <stdio.h> #include <stdlib.h> -#include <assert.h> #include <avahi-client/client.h> #include <avahi-client/publish.h> diff --git a/qemud/qemud.c b/qemud/qemud.c index 77a2352..e853538 100644 --- a/qemud/qemud.c +++ b/qemud/qemud.c @@ -44,7 +44,6 @@ #include <string.h> #include <errno.h> #include <getopt.h> -#include <assert.h> #include <fnmatch.h> #include <grp.h> #include <signal.h> diff --git a/qemud/remote.c b/qemud/remote.c index b5b0ef6..57f8f29 100644 --- a/qemud/remote.c +++ b/qemud/remote.c @@ -43,7 +43,6 @@ #include <errno.h> #include <getopt.h> #include <ctype.h> -#include <assert.h> #include <fnmatch.h> #ifdef HAVE_POLKIT -- 1.5.4.rc4.15.g215c5

On Fri, Jan 25, 2008 at 11:22:51PM +0100, Jim Meyering wrote:
Enable the <assert.h>-checking test; fix violations.
* Makefile.cfg (local-checks-to-skip) [sc_prohibit_assert_without_use]: Enable. * qemud/mdns.c: Don't include <assert.h>; no uses of assert here. * qemud/qemud.c: Likewise. * qemud/remote.c: Likewise.
ACK. Don't know where those all came from. Probably all propagated via cut & paste from my original qemud code. Dan, -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

Jim Meyering wrote:
Enable the <assert.h>-checking test; fix violations.
* Makefile.cfg (local-checks-to-skip) [sc_prohibit_assert_without_use]: Enable. * qemud/mdns.c: Don't include <assert.h>; no uses of assert here. * qemud/qemud.c: Likewise. * qemud/remote.c: Likewise.
ACK - nice one. I'd be wary of other "minimal include" tests however since sometimes the includes are really needed on some obscure architecture ... eg. Windows :-) Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
participants (3)
-
Daniel P. Berrange
-
Jim Meyering
-
Richard W.M. Jones