[libvirt] [PATCH 0/4] travis: Various improvements
Basically my own spin on https://www.redhat.com/archives/libvir-list/2018-February/msg01106.html Patch 3/4 is actually carried over unchanged from that series. The upstart bit is missing because I'm not too sure about how to deal with it, but it can be solved as a follow-up anyway. Andrea Bolognani (3): travis: Drop precise travis: Run 'make distcheck' during build travis: Run 'make install' during build Daniel P. Berrangé (1): travis: make all builds use VPATH .travis.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.14.3
Support for building on precise is going to be dropped from Travis CI in a couple of months, let's get ahead of the game. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- .travis.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 3f26a1eeee..9219ccd173 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,12 +4,8 @@ cache: ccache matrix: include: - - compiler: gcc - dist: precise - compiler: gcc dist: trusty - - compiler: clang - dist: precise - compiler: clang dist: trusty - compiler: clang -- 2.14.3
On Wed, Feb 28, 2018 at 12:42:57PM +0100, Andrea Bolognani wrote:
Support for building on precise is going to be dropped from Travis CI in a couple of months, let's get ahead of the game.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- .travis.yml | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/.travis.yml b/.travis.yml index 3f26a1eeee..9219ccd173 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,12 +4,8 @@ cache: ccache
matrix: include: - - compiler: gcc - dist: precise - compiler: gcc dist: trusty - - compiler: clang - dist: precise - compiler: clang dist: trusty - compiler: clang
This is incomplete because there's CFLAGS defined later on to work around a bug on Precise that should also be removed. Unfortunately removing that CFLAGS then reveals the fact that building with Clang breaks "make check" on the remote protocol files. This failure has been hidden before now because the -Wno-error=variadic-args flag for some reason caused pdwtags to fail to emit any output, which accidentally caused libvirt to ignore the failure. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
The distcheck procedure exercises pretty much the entire build system, so it's a good idea to run it frequently in order to catch regressions. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 9219ccd173..638228a6ed 100644 --- a/.travis.yml +++ b/.travis.yml @@ -99,7 +99,7 @@ before_script: script: # Many unit tests still fail on macOS, and there are a bunch of issues with # syntax-check as well, so skip those steps on that platform for now - - make -j3 && if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 syntax-check && make -j3 check; fi + - make -j3 && if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 syntax-check && make -j3 check && make -j3 distcheck; fi after_failure: - echo '============================================================================' -- 2.14.3
From: Daniel P. Berrangé <berrange@redhat.com> VPATH is not well tested by developers, so ensure travis exercises VPATH in all scenarios. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 638228a6ed..6b2595edab 100644 --- a/.travis.yml +++ b/.travis.yml @@ -94,7 +94,7 @@ before_install: - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update && brew upgrade && brew install rpcgen yajl; fi before_script: - - ./autogen.sh + - mkdir build && cd build && ../autogen.sh script: # Many unit tests still fail on macOS, and there are a bunch of issues with -- 2.14.3
This part of the build system was not being exercised before. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 6b2595edab..a1f1d8b51d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -94,12 +94,12 @@ before_install: - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update && brew upgrade && brew install rpcgen yajl; fi before_script: - - mkdir build && cd build && ../autogen.sh + - mkdir build install && cd build && ../autogen.sh --prefix=$(pwd)/../install script: # Many unit tests still fail on macOS, and there are a bunch of issues with # syntax-check as well, so skip those steps on that platform for now - - make -j3 && if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 syntax-check && make -j3 check && make -j3 distcheck; fi + - make -j3 && make -j3 install && if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 syntax-check && make -j3 check && make -j3 distcheck; fi after_failure: - echo '============================================================================' -- 2.14.3
Make sure we install the same packages lcitool would install on the CentOS CI so that we have consistent results. The package list is current as of libvirt-jenkins-ci commit ad84090b6f96. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- .travis.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index a1f1d8b51d..edc6adb787 100644 --- a/.travis.yml +++ b/.travis.yml @@ -19,6 +19,7 @@ addons: - autoconf - automake - autopoint + - bash-completion - ccache - dnsmasq-base - dwarves @@ -32,9 +33,9 @@ addons: - libaudit-dev - libavahi-client-dev - libblkid-dev - - libc-dev-bin - libc6-dev - libcap-ng-dev + - libc-dev-bin - libcurl4-gnutls-dev - libdbus-1-dev - libdevmapper-dev @@ -50,10 +51,12 @@ addons: - libpciaccess-dev - librbd-dev - libreadline-dev + - libsanlock-dev - libsasl2-dev - libselinux1-dev - libssh2-1-dev - libssh-dev + - libtirpc-dev - libtool - libudev-dev - libxen-dev @@ -67,7 +70,7 @@ addons: - parted - patch - perl - - pkg-config + - pkgconf - policykit-1 - qemu-utils - radvd -- 2.14.3
On Wed, 2018-02-28 at 14:57 +0100, Andrea Bolognani wrote:
Make sure we install the same packages lcitool would install on the CentOS CI so that we have consistent results. The package list is current as of libvirt-jenkins-ci commit ad84090b6f96.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- .travis.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
Ping? Although the rest of the series is not applicable anymore, this one patch still is. -- Andrea Bolognani / Red Hat / Virtualization
On Wed, Feb 28, 2018 at 02:57:21PM +0100, Andrea Bolognani wrote:
Make sure we install the same packages lcitool would install on the CentOS CI so that we have consistent results. The package list is current as of libvirt-jenkins-ci commit ad84090b6f96.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- .travis.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml index a1f1d8b51d..edc6adb787 100644 --- a/.travis.yml +++ b/.travis.yml @@ -19,6 +19,7 @@ addons: - autoconf - automake - autopoint + - bash-completion - ccache - dnsmasq-base - dwarves @@ -32,9 +33,9 @@ addons: - libaudit-dev - libavahi-client-dev - libblkid-dev - - libc-dev-bin - libc6-dev - libcap-ng-dev + - libc-dev-bin - libcurl4-gnutls-dev - libdbus-1-dev - libdevmapper-dev @@ -50,10 +51,12 @@ addons: - libpciaccess-dev - librbd-dev - libreadline-dev + - libsanlock-dev - libsasl2-dev - libselinux1-dev - libssh2-1-dev - libssh-dev + - libtirpc-dev - libtool - libudev-dev - libxen-dev @@ -67,7 +70,7 @@ addons: - parted - patch - perl - - pkg-config + - pkgconf - policykit-1 - qemu-utils - radvd
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> (I'll assume you've pushed this through travis already on a private branch to ensure the build still succeeds) Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (2)
-
Andrea Bolognani -
Daniel P. Berrangé