[libvirt] [PATCH][Ruby] support: virNetworkUpdate
Hi Chris, I use ruby-libvirt for Vagrant and Vagrant-kvm project. A virNetworkUpdate method with libvirt ruby binding is essential in order to support network configuration among multi VMs in Vagrant. Please find an attachment that is trying to support virNetworkUpdate. https://github.com/miurahr/ruby-libvirt/tree/virNetworkUpdate -- Hiroshi Miura
On Sat, Aug 10, 2013 at 3:50 AM, Hiroshi Miura <miurahr@linux.com> wrote:
Hi Chris,
I use ruby-libvirt for Vagrant and Vagrant-kvm project.
A virNetworkUpdate method with libvirt ruby binding is essential in order to support network configuration among multi VMs in Vagrant.
Please find an attachment that is trying to support virNetworkUpdate.
https://github.com/miurahr/ruby-libvirt/tree/virNetworkUpdate
Thanks for the patch, that is great! I've now applied it to the main ruby-libvirt repository. Let me know if you have any problems with it. Chris
Hi Chris, On 2013年08月13日 09:55, Chris Lalancette wrote:
Thanks for the patch, that is great!
I've now applied it to the main ruby-libvirt repository. Let me know if you have any problems with it.
Looks good. No problem. IMHO, there are many progress from 0.4.0 release, it is chance to release 0.5.0 :-) There is a small problem that a commit in 2008 had a wrong date record. (That makes warn when pushing it on github.com) https://github.com/miurahr/ruby-libvirt/compare/master...fixInvalidCommit Hiroshi
On Tue, Aug 13, 2013 at 10:19 AM, Hiroshi Miura <miurahr@linux.com> wrote:
Hi Chris,
On 2013年08月13日 09:55, Chris Lalancette wrote:
Thanks for the patch, that is great!
I've now applied it to the main ruby-libvirt repository. Let me know if you have any problems with it.
Looks good. No problem.
IMHO, there are many progress from 0.4.0 release, it is chance to release 0.5.0 :-)
Yeah, I have a few other patches outstanding. I'll try to get to them and do a release in the near future.
There is a small problem that a commit in 2008 had a wrong date record. (That makes warn when pushing it on github.com) https://github.com/miurahr/ruby-libvirt/compare/master...fixInvalidCommit
Yeah, I see what you mean. That is unfortunate. However, I'm not inclined to rewrite the whole history of the repository, as that will break all downstream cloners. Unless it is a major problem for you, I'm just going to leave it as-is. Thanks, Chris
participants (2)
-
Chris Lalancette -
Hiroshi Miura